Attention is currently required from: Tim Crawford, SRIDHAR SIRICILLA, Furquan Shaikh, Paul Menzel, Rizwan Qureshi, Angel Pons, Subrata Banik, Sridhar Siricilla, Arthur Heymans, Evgeny Zinoviev, Patrick Rudolph, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52800 )
Change subject: soc/intel: Allow enable/disable ME via CMOS ......................................................................
Patch Set 78:
(7 comments)
File src/soc/intel/common/block/cse/cse.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130497): https://review.coreboot.org/c/coreboot/+/52800/comment/085c08c8_923b1524 PS78, Line 972: * change states after 3 attempts. Some verson of the (CS)ME need to be 'verson' may be misspelled - perhaps 'version'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130497): https://review.coreboot.org/c/coreboot/+/52800/comment/e367f45c_f8636489 PS78, Line 974: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130497): https://review.coreboot.org/c/coreboot/+/52800/comment/07296270_ea750ebb PS78, Line 976: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130497): https://review.coreboot.org/c/coreboot/+/52800/comment/3275ef08_4f05fdac PS78, Line 980: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130497): https://review.coreboot.org/c/coreboot/+/52800/comment/3eb4a99e_5b628725 PS78, Line 1027: * If the (CS)ME fails to change states after 3 attempts, it will code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130497): https://review.coreboot.org/c/coreboot/+/52800/comment/d0cc6a33_854739bf PS78, Line 1028: * likely need a cold boot, or recovering. code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130497): https://review.coreboot.org/c/coreboot/+/52800/comment/a1081468_6a809e98 PS78, Line 1029: */ code indent should use tabs where possible
-
build bot (Jenkins) (Code Review)