Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40720 )
Change subject: drivers/libgfxinit: Add Comet Lake to supported platforms ......................................................................
drivers/libgfxinit: Add Comet Lake to supported platforms
Signed-off-by: Felix Singer felixsinger@posteo.net Change-Id: I002ade555c0544e4ef738c1ad45ee3d8aa38e03e --- M src/drivers/intel/gma/Kconfig 1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/40720/1
diff --git a/src/drivers/intel/gma/Kconfig b/src/drivers/intel/gma/Kconfig index acc25fe..051cdd4 100644 --- a/src/drivers/intel/gma/Kconfig +++ b/src/drivers/intel/gma/Kconfig @@ -86,7 +86,7 @@ || NORTHBRIDGE_INTEL_HASWELL \ || SOC_INTEL_BROADWELL || SOC_INTEL_SKYLAKE || SOC_INTEL_APOLLOLAKE \ || SOC_INTEL_KABYLAKE || SOC_INTEL_COFFEELAKE \ - || SOC_INTEL_WHISKEYLAKE + || SOC_INTEL_WHISKEYLAKE || SOC_INTEL_COMETLAKE depends on MAINBOARD_USE_LIBGFXINIT || INTEL_GMA_LIBGFXINIT_EDID select RAMSTAGE_LIBHWBASE
@@ -113,7 +113,8 @@ string default "Broxton" if SOC_INTEL_APOLLOLAKE default "Skylake" if SOC_INTEL_SKYLAKE || SOC_INTEL_KABYLAKE || \ - SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE + SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE || \ + SOC_INTEL_COMETLAKE default "Haswell" if NORTHBRIDGE_INTEL_HASWELL || SOC_INTEL_BROADWELL default "Ironlake" if NORTHBRIDGE_INTEL_IRONLAKE || NORTHBRIDGE_INTEL_SANDYBRIDGE default "G45" if NORTHBRIDGE_INTEL_GM45 || NORTHBRIDGE_INTEL_X4X
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40720 )
Change subject: drivers/libgfxinit: Add Comet Lake to supported platforms ......................................................................
Patch Set 1: Code-Review+1
Tested? working? ^^
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40720 )
Change subject: drivers/libgfxinit: Add Comet Lake to supported platforms ......................................................................
Patch Set 1: Code-Review+1
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40720 )
Change subject: drivers/libgfxinit: Add Comet Lake to supported platforms ......................................................................
Patch Set 6: Code-Review+2
This change is ready for review.
Michael Niewöhner has uploaded a new patch set (#7) to the change originally created by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/40720 )
Change subject: drivers/libgfxinit: Add Comet Lake to supported platforms ......................................................................
drivers/libgfxinit: Add Comet Lake to supported platforms
Signed-off-by: Felix Singer felixsinger@posteo.net Change-Id: I002ade555c0544e4ef738c1ad45ee3d8aa38e03e --- M src/drivers/intel/gma/Kconfig 1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/40720/7
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40720 )
Change subject: drivers/libgfxinit: Add Comet Lake to supported platforms ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40720/7/src/drivers/intel/gma/Kconf... File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/40720/7/src/drivers/intel/gma/Kconf... PS7, Line 89: SOC_INTEL_COFFEELAKE \ : || SOC_INTEL_WHISKEYLAKE || SOC_INTEL_COMETLAKE let's use SOC_INTEL_CANNONLAKE_BASE
https://review.coreboot.org/c/coreboot/+/40720/7/src/drivers/intel/gma/Kconf... PS7, Line 116: SOC_INTEL_SKYLAKE || SOC_INTEL_KABYLAKE || \ : SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE || \ : SOC_INTEL_COMETLAKE let's use SOC_INTEL_CANNONLAKE_BASE
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40720 )
Change subject: drivers/libgfxinit: Add Comet Lake to supported platforms ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40720/7/src/drivers/intel/gma/Kconf... File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/40720/7/src/drivers/intel/gma/Kconf... PS7, Line 116: SOC_INTEL_SKYLAKE || SOC_INTEL_KABYLAKE || \ : SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE || \ : SOC_INTEL_COMETLAKE
let's use SOC_INTEL_CANNONLAKE_BASE
That includes Cannonlake proper too, but do we support that?
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40720 )
Change subject: drivers/libgfxinit: Add Comet Lake to supported platforms ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40720/7/src/drivers/intel/gma/Kconf... File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/40720/7/src/drivers/intel/gma/Kconf... PS7, Line 89: SOC_INTEL_COFFEELAKE \ : || SOC_INTEL_WHISKEYLAKE || SOC_INTEL_COMETLAKE
let's use SOC_INTEL_CANNONLAKE_BASE
Not here, please. As Angel mentioned below, it would draw SOC_INTEL_CANNONLAKE in.
https://review.coreboot.org/c/coreboot/+/40720/7/src/drivers/intel/gma/Kconf... PS7, Line 116: SOC_INTEL_SKYLAKE || SOC_INTEL_KABYLAKE || \ : SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE || \ : SOC_INTEL_COMETLAKE
That includes Cannonlake proper too, but do we support that?
We don't and even if ever supported, SOC_INTEL_CANNONLAKE would probably not result in "Skylake" here.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40720 )
Change subject: drivers/libgfxinit: Add Comet Lake to supported platforms ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40720/7/src/drivers/intel/gma/Kconf... File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/40720/7/src/drivers/intel/gma/Kconf... PS7, Line 89: SOC_INTEL_COFFEELAKE \ : || SOC_INTEL_WHISKEYLAKE || SOC_INTEL_COMETLAKE
Not here, please. As Angel mentioned below, it would draw SOC_INTEL_CANNONLAKE in.
Done
https://review.coreboot.org/c/coreboot/+/40720/7/src/drivers/intel/gma/Kconf... PS7, Line 116: SOC_INTEL_SKYLAKE || SOC_INTEL_KABYLAKE || \ : SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE || \ : SOC_INTEL_COMETLAKE
We don't and even if ever supported, SOC_INTEL_CANNONLAKE would probably […]
indeed, sry for the noise
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40720 )
Change subject: drivers/libgfxinit: Add Comet Lake to supported platforms ......................................................................
Patch Set 11:
This change is ready for review.
Michael Niewöhner has uploaded a new patch set (#19) to the change originally created by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/40720 )
Change subject: drivers/libgfxinit: Add Comet Lake to supported platforms ......................................................................
drivers/libgfxinit: Add Comet Lake to supported platforms
Signed-off-by: Felix Singer felixsinger@posteo.net Change-Id: I002ade555c0544e4ef738c1ad45ee3d8aa38e03e --- M src/drivers/intel/gma/Kconfig 1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/40720/19
Michael Niewöhner has uploaded a new patch set (#21) to the change originally created by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/40720 )
Change subject: drivers/libgfxinit: Add Comet Lake to supported platforms ......................................................................
drivers/libgfxinit: Add Comet Lake to supported platforms
Signed-off-by: Felix Singer felixsinger@posteo.net Change-Id: I002ade555c0544e4ef738c1ad45ee3d8aa38e03e --- M src/drivers/intel/gma/Kconfig 1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/40720/21
Michael Niewöhner has uploaded a new patch set (#22) to the change originally created by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/40720 )
Change subject: drivers/libgfxinit: Add Comet Lake to supported platforms ......................................................................
drivers/libgfxinit: Add Comet Lake to supported platforms
Signed-off-by: Felix Singer felixsinger@posteo.net Change-Id: I002ade555c0544e4ef738c1ad45ee3d8aa38e03e --- M src/drivers/intel/gma/Kconfig 1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/40720/22
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40720 )
Change subject: drivers/libgfxinit: Add Comet Lake to supported platforms ......................................................................
drivers/libgfxinit: Add Comet Lake to supported platforms
Signed-off-by: Felix Singer felixsinger@posteo.net Change-Id: I002ade555c0544e4ef738c1ad45ee3d8aa38e03e Reviewed-on: https://review.coreboot.org/c/coreboot/+/40720 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michael Niewöhner foss@mniewoehner.de Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/drivers/intel/gma/Kconfig 1 file changed, 3 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Angel Pons: Looks good to me, but someone else must approve Michael Niewöhner: Looks good to me, approved
diff --git a/src/drivers/intel/gma/Kconfig b/src/drivers/intel/gma/Kconfig index e13663f..b001fd3 100644 --- a/src/drivers/intel/gma/Kconfig +++ b/src/drivers/intel/gma/Kconfig @@ -87,7 +87,7 @@ || NORTHBRIDGE_INTEL_HASWELL \ || SOC_INTEL_BROADWELL || SOC_INTEL_SKYLAKE || SOC_INTEL_APOLLOLAKE \ || SOC_INTEL_KABYLAKE || SOC_INTEL_COFFEELAKE \ - || SOC_INTEL_WHISKEYLAKE + || SOC_INTEL_WHISKEYLAKE || SOC_INTEL_COMETLAKE depends on MAINBOARD_USE_LIBGFXINIT || INTEL_GMA_LIBGFXINIT_EDID select RAMSTAGE_LIBHWBASE
@@ -114,7 +114,8 @@ string default "Broxton" if SOC_INTEL_APOLLOLAKE default "Skylake" if SOC_INTEL_SKYLAKE || SOC_INTEL_KABYLAKE || \ - SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE + SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE || \ + SOC_INTEL_COMETLAKE default "Haswell" if NORTHBRIDGE_INTEL_HASWELL || SOC_INTEL_BROADWELL default "Ironlake" if NORTHBRIDGE_INTEL_IRONLAKE || NORTHBRIDGE_INTEL_SANDYBRIDGE default "G45" if NORTHBRIDGE_INTEL_GM45 || NORTHBRIDGE_INTEL_X4X
-
Angel Pons (Code Review) -
Felix Singer (Code Review)
-
Michael Niewöhner (Code Review)
-
Nico Huber (Code Review)