Attention is currently required from: Christian Walter, Johnny Lin, Lean Sheng Tan, Shuo Liu, Tim Chu.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81098?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/intel/xeon_sp: Further share domain creation logics in Xeon-SP
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81098/comment/5011cebb_812f1f60 :
PS5, Line 14: Additionally, the assumption of socket0/stack0 is a PCIe stack is not
: always true for future generation SoCs and hence this assumption is
: removed.
sidenote: This is still assumed in iio_pci_domain_read_resources.
Patchset:
PS5:
Looks good to me, but I do have question on how to handle the statically created devicetree structure.
The domain for stack0 socket0 is created at buildtime via devicetree.cb or chipset.cb. Would it make sense to assert that this one gets matched with at least one of the domains?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81098?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If06bb5ff41b5f04cef766cf29d38369c6022da79
Gerrit-Change-Number: 81098
Gerrit-PatchSet: 5
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Fri, 08 Mar 2024 07:40:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment