[M] Change in coreboot[master]: soc/intel/cmn/cse: Store ISH firmware version into CBMEM - coreboot-gerrit

15 Apr 2023


      Attention is currently required from: Tarun Tuli, Dinesh Gehlot, Sridhar Siricilla, Arthur Heymans.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74208 )
Change subject: soc/intel/cmn/cse: Store ISH firmware version into CBMEM
......................................................................
Patch Set 20:
(1 comment)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/74208/comment/5c5f7e97_3fb742a4 
PS20, Line 1246: This API can only be executed after memory has been initialized.
...
Make this explicit in code?
i hope u are asking to add ENV_RAMSTAGE check inside the code?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74208
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie5c5faf926c75b05d189fb1118020fff024fc3e0
Gerrit-Change-Number: 74208
Gerrit-PatchSet: 20
Gerrit-Owner: Dinesh Gehlot digehlot@google.com
Gerrit-Reviewer: Kangheui Won khwon@chromium.org
Gerrit-Reviewer: Tarun Tuli taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Sridhar Siricilla sridhar.siricilla@intel.com
Gerrit-CC: Subrata Banik subratabanik@google.com
Gerrit-Attention: Tarun Tuli taruntuli@google.com
Gerrit-Attention: Dinesh Gehlot digehlot@google.com
Gerrit-Attention: Sridhar Siricilla sridhar.siricilla@intel.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Sat, 15 Apr 2023 12:08:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment