Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson. Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60209 )
Change subject: [WIP,NOTFORMERGE] soc/amd/common/lpc/espi_util: add TODO to espi_wait_channel_ready ......................................................................
[WIP,NOTFORMERGE] soc/amd/common/lpc/espi_util: add TODO to espi_wait_channel_ready
I'm not 100% sure yet if not checking the return value is intended or not.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Iff1a0670e17b9d6c6f4daf2ea56badf6c428b8c9 --- M src/soc/amd/common/block/lpc/espi_util.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/60209/1
diff --git a/src/soc/amd/common/block/lpc/espi_util.c b/src/soc/amd/common/block/lpc/espi_util.c index 4c42c04..a823c44 100644 --- a/src/soc/amd/common/block/lpc/espi_util.c +++ b/src/soc/amd/common/block/lpc/espi_util.c @@ -771,6 +771,7 @@
stopwatch_init_usecs_expire(&sw, ESPI_CH_READY_TIMEOUT_US); do { + /* TODO: Handle espi_get_configuration failure? */ espi_get_configuration(slave_reg_addr, &config); if (espi_slave_is_channel_ready(config)) return CB_SUCCESS;