Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85951?usp=email )
Change subject: mb/google/rauru: Add edp driver in mainboard ......................................................................
Patch Set 2:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85951/comment/0f86d7ac_ea9da26c?usp... : PS2, Line 7: mb/google/rauru: Add edp driver in mainboard : : Add edp driver : Adjust training flow and turn off phy power beforce phy : configurate because maby link training fail Doesn't this patch add the panel support ?
File src/mainboard/google/rauru/gpio.h:
https://review.coreboot.org/c/coreboot/+/85951/comment/762d23bb_99dbfea2?usp... : PS2, Line 18: #define GPIO_BL_PWM_1V8 GPIO(DISP_PWM) leave one blank line on above
File src/mainboard/google/rauru/panel.c:
https://review.coreboot.org/c/coreboot/+/85951/comment/848eab88_8a3acb21?usp... : PS2, Line 3: #include <boardid.h> : #include <cbfs.h> : #include <delay.h> : #include <fw_config.h> : #include <gpio.h> : #include <soc/ddp.h> : #include <soc/dsi.h> : #include <soc/gpio_common.h> : #include <soc/mtcmos.h> remove unused headers
File src/mainboard/google/rauru/panel_navi.c:
https://review.coreboot.org/c/coreboot/+/85951/comment/645e1801_f136cc2a?usp... : PS2, Line 3: #include <boardid.h> : #include <cbfs.h> : #include <delay.h> : #include <fw_config.h> : #include <gpio.h> : #include <soc/ddp.h> : #include <soc/dsi.h> : #include <soc/gpio_common.h> : #include <soc/mtcmos.h> please remove unused headers.
https://review.coreboot.org/c/coreboot/+/85951/comment/33de5d56_91509484?usp... : PS2, Line 24: mdelay(400); Is this delay required if we enable the backlight in the payload (depthcharge) ?
https://review.coreboot.org/c/coreboot/+/85951/comment/c90369c1_b921d575?usp... : PS2, Line 25: , 1); : gpio_output(GPIO_BL_PWM_1V8, 1); I think we should pull down these two pins here and pull them up in the payload.