Attention is currently required from: Anil Kumar K, Bora Guvendik, Eran Mitrani, Eric Lai, Hannah Williams, Ivy Jian, Jakub Czapiga, Jamie Ryu, Kapil Porwal, Subrata Banik, Tarun, Tarun Tuli, Wonkyu Kim.
Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76537?usp=email )
Change subject: mb/google/rex: Fix PMC GPIO group route to GPE
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/76537/comment/20dc13b9_5c80355f :
PS4, Line 24: none
`TPM_TIS_ACPI_INTERRUPT` is GPP E03. […]
thx for pointing out. add missed bit description. For TPM_TIS_ACPI_INTERRUPT, it is not configured to route to SCI and its GPE0_EN is not set. However, its bit from GPE0_STS was checked, so I also add this pad.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76537?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3bf27c71658f177c0ba544fb90712a82a058aa1
Gerrit-Change-Number: 76537
Gerrit-PatchSet: 4
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Thu, 31 Aug 2023 22:22:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com
Gerrit-MessageType: comment