Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45338 )
Change subject: mb/intel/jasperlake_rvp: Fix wrong comments for ECT ......................................................................
mb/intel/jasperlake_rvp: Fix wrong comments for ECT
Disable -> Enable
Signed-off-by: Subrata Banik subrata.banik@intel.com Change-Id: Iccefb02fa9bf9507b9e679b3fba35c5c28d677a1 --- M src/mainboard/intel/jasperlake_rvp/variants/jslrvp/memory.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/45338/1
diff --git a/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/memory.c b/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/memory.c index 434e9dd..46499f4 100644 --- a/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/memory.c +++ b/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/memory.c @@ -42,7 +42,7 @@ /* Baseboard Rcomp target values */ .rcomp_targets = {0, 0, 0, 0, 0},
- /* Disable Early Command Training */ + /* Enable Early Command Training */ .ect = 1,
/* Set Board Type */ @@ -87,7 +87,7 @@ */ .rcomp_targets = {80, 40, 40, 40, 30},
- /* Disable Early Command Training */ + /* Enable Early Command Training */ .ect = 1,
/* Set Board Type */
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45338 )
Change subject: mb/intel/jasperlake_rvp: Fix wrong comments for ECT ......................................................................
Patch Set 1: Code-Review+2
Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45338 )
Change subject: mb/intel/jasperlake_rvp: Fix wrong comments for ECT ......................................................................
mb/intel/jasperlake_rvp: Fix wrong comments for ECT
Disable -> Enable
Signed-off-by: Subrata Banik subrata.banik@intel.com Change-Id: Iccefb02fa9bf9507b9e679b3fba35c5c28d677a1 Reviewed-on: https://review.coreboot.org/c/coreboot/+/45338 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/intel/jasperlake_rvp/variants/jslrvp/memory.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/memory.c b/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/memory.c index 434e9dd..46499f4 100644 --- a/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/memory.c +++ b/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/memory.c @@ -42,7 +42,7 @@ /* Baseboard Rcomp target values */ .rcomp_targets = {0, 0, 0, 0, 0},
- /* Disable Early Command Training */ + /* Enable Early Command Training */ .ect = 1,
/* Set Board Type */ @@ -87,7 +87,7 @@ */ .rcomp_targets = {80, 40, 40, 40, 30},
- /* Disable Early Command Training */ + /* Enable Early Command Training */ .ect = 1,
/* Set Board Type */
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45338 )
Change subject: mb/intel/jasperlake_rvp: Fix wrong comments for ECT ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 8/1/9 "QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/19431 "QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19430 "QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/19429 "QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19428 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/19427 "HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/19435 "HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/19434 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/19433 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19432
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Subrata Banik (Code Review)