Pablo Moyano has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34105 )
Change subject: payloads/external/GRUB2/Makefile: Add ./bootstrap to fix build ......................................................................
payloads/external/GRUB2/Makefile: Add ./bootstrap to fix build
At some point between Grub 2.02 and 2.04, something was added and it refuses to build without it.
Change-Id: Ia8fca13fe58be55aa4569ff58bbfd76ab7a67cdd Signed-off-by: Pablo 42.pablo.ms@gmail.com --- M payloads/external/GRUB2/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34105/1
diff --git a/payloads/external/GRUB2/Makefile b/payloads/external/GRUB2/Makefile index 31c4066..b036aeb 100644 --- a/payloads/external/GRUB2/Makefile +++ b/payloads/external/GRUB2/Makefile @@ -28,7 +28,7 @@ echo " CONFIG GRUB2 $(NAME-y)" rm -rf grub2/build mkdir grub2/build - cd grub2 && ./autogen.sh + cd grub2 && ./bootstrap && ./autogen.sh cd grub2/build && ../configure CC="$(HOSTCC)" LD="$(LD)" \ FREETYPE="pkg-config freetype2" BUILD_FREETYPE="pkg-config freetype2" \ TARGET_CC="$(CC)" TARGET_OBJCOPY="$(OBJCOPY)" TARGET_STRIP="$(STRIP)" \
Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34105 )
Change subject: payloads/external/GRUB2/Makefile: Add ./bootstrap to fix build ......................................................................
Patch Set 1:
I guess this makes sense while the GRUB2 version (in payloads/external/GRUB2/) is bumped from 2.02 to 2.04 as well.
Attention is currently required from: Pablo Moyano. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34105 )
Change subject: payloads/external/GRUB2/Makefile: Add ./bootstrap to fix build ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: Thank you for the submitting this change for review.
This is fixed since I2f95059453ca5565a38550b147590ece4d8bf5ad, isn’t it? If so, can you please abandon the change?
Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34105?usp=email )
Change subject: payloads/external/GRUB2/Makefile: Add ./bootstrap to fix build ......................................................................
Abandoned