Martin Roth has posted comments on this change. ( https://review.coreboot.org/28060 )
Change subject: intel/common/block: Fix issues found by klockwork ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/28060/1/src/soc/intel/common/block/cpu/mp_in... File src/soc/intel/common/block/cpu/mp_init.c:
https://review.coreboot.org/#/c/28060/1/src/soc/intel/common/block/cpu/mp_in... PS1, Line 137: assert
Looks like CONFIG_FATAL_ASSERTS is on. […]
I agree with Hannah's approach.
I don't understand what you mean by "it looks like CONFIG_FATAL_ASSERTS is on". It's a kconfig option. It may be on in your particular config, but that doesn't mean that it's on in all configs.
You *CANNOT* rely on asserts to guard your code in coreboot.
-
Martin Roth (Code Review)