[XS] Change in coreboot[main]: drivers/intel/gma: Don't advertise support for opregion mailbox #2 - coreboot-gerrit

4 Feb 2025


      Attention is currently required from: Intel coreboot Reviewers, Jérémy Compostella.
Matt DeVillier has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/86276?usp=email )
Change subject: drivers/intel/gma: Don't advertise support for opregion mailbox #2
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/intel/gma/opregion.h:
https://review.coreboot.org/c/coreboot/+/86276/comment/e54395cb_e5ce3235?usp... :
PS1, Line 45: #define MAILBOXES_DESKTOP (IGD_MBOX2 | IGD_MBOX4)
...
Why is okay for MAILBOXES_DESKTOP ?
it's not, but `MAILBOXES_DESKTOP` is unused. Should probably just consolidate into a single value
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/86276?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8efcf9c5d384b6e0ce159d65cb1497c2e2e47f42
Gerrit-Change-Number: 86276
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Intel coreboot Reviewers intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Attention: Intel coreboot Reviewers intel_coreboot_reviewers@intel.com
Gerrit-Attention: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Comment-Date: Tue, 04 Feb 2025 18:14:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jérémy Compostella jeremy.compostella@intel.com