Change in ...coreboot[master]: soc/intel/cannonlake: Program HD Audio SVID/SSID

[Lijian Zhao (Code Review)]

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29651 )

Change subject: soc/intel/cannonlake: Program HD Audio SVID/SSID
......................................................................


Patch Set 5:
> Is this just setting subsystem ids of a PCI device? These should be
> set in the devicetree and no blob needed.
>
> If yes, this seems backwards. Shouldn't we set the id of the PCI
> device first and when configuring the codec take the id of the PCI
> device?

From https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/soun..., line 651, we can see kernel driver is comparing the ssid with pci and verb.

	ass = codec->core.subsystem_id & 0xffff;
	if (codec->bus->pci &&
	    ass != codec->bus->pci->subsystem_device && (ass & 1))
		goto do_sku;

I believe the ssid of detail codec is fixed, then we have to modify BUS ssid to match with it. I have similar concern earlier in 29490.


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29651
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25e22313fd99479f1a2f68636a2eab83126ca488
Gerrit-Change-Number: 29651
Gerrit-PatchSet: 5
Gerrit-Owner: Lijian Zhao <[e-mail]>
Gerrit-Reviewer: Jairaj Arava <[e-mail]>
Gerrit-Reviewer: Krzysztof M Sywula <[e-mail]>
Gerrit-Reviewer: Lijian Zhao <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Pratikkumar V Prajapati <[e-mail]>
Gerrit-Reviewer: Sathyanarayana Nujella <[e-mail]>
Gerrit-Reviewer: Subrata Banik <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Duncan Laurie <[e-mail]>
Gerrit-CC: Nico Huber <[e-mail]>
Gerrit-Comment-Date: Sat, 01 Dec 2018 00:06:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment