Is this just setting subsystem ids of a PCI device? These should be
set in the devicetree and no blob needed.

If yes, this seems backwards. Shouldn't we set the id of the PCI
device first and when configuring the codec take the id of the PCI
device?

From https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/sound/pci/hda/patch_realtek.c?h=v4.20-rc4, line 651, we can see kernel driver is comparing the ssid with pci and verb.

	ass = codec->core.subsystem_id & 0xffff;
	if (codec->bus->pci &&
	    ass != codec->bus->pci->subsystem_device && (ass & 1))
		goto do_sku;

I believe the ssid of detail codec is fixed, then we have to modify BUS ssid to match with it. I have similar concern earlier in 29490.

View Change

To view, visit change 29651. To unsubscribe, or for help writing mail filters, visit settings.