Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Julius Werner, Kyösti Mälkki, Martin L Roth, Matt DeVillier, Nico Huber, Patrick Georgi, Paul Menzel, Subrata Banik, Werner Zeh.
Hello Felix Held, Fred Reitberger, Jason Glenesk, Julius Werner, Kyösti Mälkki, Matt DeVillier, Nico Huber, Patrick Georgi, Paul Menzel, Subrata Banik, Werner Zeh, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/78623?usp=email
to look at the new patch set (#12).
Change subject: Kconfig: Decrease default HEAP_SIZE from 1 MiB to 512 KiB
......................................................................
Kconfig: Decrease default HEAP_SIZE from 1 MiB to 512 KiB
Commit 44a48ce7a46c ("Kconfig: Bring HEAP_SIZE to a common, large
value") breaks S3 resume from TSEG stage cache on many platforms,
including GM45 and Ivy Bridge, so limit it to 512 KiB.
HEAP_SIZE overrides greater than 512K prior to the commit above are
restored.
Please test this against other platforms before merging!
Tested: Setting it to 0x80000 results a working S3 resume on Thinkpad
X200 and T430, with log in cbmem for S3 resume, while 0xa0000
breaks it. coreboot log during failed resume when (HEAP_SIZE
>= 0xa0000) cannot be obtained from EHCI debug, while log in
cbmem shows that ramstage is failed to be found in TSEG stage
cache, as shown in https://ticket.coreboot.org/issues/512 .
Resolves: https://ticket.coreboot.org/issues/512
Signed-off-by: Bill XIE persmule@hardenedlinux.org
Change-Id: Ib1de1eb8487df5bdf004e544d40667833a291515
---
M src/Kconfig
M src/northbridge/amd/pi/Kconfig
M src/soc/amd/picasso/Kconfig
M src/soc/amd/stoneyridge/Kconfig
4 files changed, 14 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/78623/12
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78623?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib1de1eb8487df5bdf004e544d40667833a291515
Gerrit-Change-Number: 78623
Gerrit-PatchSet: 12
Gerrit-Owner: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@9elements.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Patrick Georgi
patrick@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@9elements.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: newpatchset