Attention is currently required from: Tarun Tuli, Kapil Porwal, Sumeet R Pawnikar, Eric Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74379 )
Change subject: mb/google/rex: Add CPU power limit values
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/rex/variants/rex0/ramstage.c:
https://review.coreboot.org/c/coreboot/+/74379/comment/7418ae59_3c47b4bc
PS1, Line 17: variant_update_power_limits
I still think put a __weak function in the systemagent.c before set power_limits, like variant_update_power_limits(), and change the common name to soc_update_power_limits.
IMO, these are still SoC specific values rather board specific.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74379
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7953ce8dc0a247d440154902cef1007eb9358dc1
Gerrit-Change-Number: 74379
Gerrit-PatchSet: 2
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Fri, 21 Apr 2023 06:03:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment