Attention is currently required from: Patrick Rudolph.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78089?usp=email )
Change subject: mb/emulation/qemu-q35: Support SPI flash ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/emulation/qemu-q35/Kconfig:
https://review.coreboot.org/c/coreboot/+/78089/comment/32078feb_39e55893 : PS2, Line 17: select BOOT_DEVICE_MEMORY_MAPPED if !QEMU_HAS_SPIBAR_IMPLEMENTED
This is necessary to be able to write to the SPI flash. […]
Yes, I understand the erase and write aspect and unselecting BOOT_DEVICE_NOT_SPI_FLASH.
Clearing BOOT_DEVICE_MEMORY_MAPPED leaves the LB_TAG_SPI_FLASH memory map undefined, unlike on real hardware? CB:48185 does not really tell if this is something eg. flashrom might depend on.
Probably does not matter with QEMU, just ack if there are not ill side-effects on clearing this.
-
Kyösti Mälkki (Code Review)