Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45040 )
Change subject: soc/intel/denverton_ns: Select CPU_INTEL_COMMON ......................................................................
soc/intel/denverton_ns: Select CPU_INTEL_COMMON
This is an intermediate step to have SOC_INTEL_COMMON_BLOCK_CPU select CPU_INTEL_COMMON directly, to avoid dependency problems.
Tested with BUILD_TIMELESS=1, Scaleway Tagada does not change.
Change-Id: I70765dcc7cace1e367311824b81d3a6b21dba24c Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/denverton_ns/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/45040/1
diff --git a/src/soc/intel/denverton_ns/Kconfig b/src/soc/intel/denverton_ns/Kconfig index 3fce223..e6d3237 100644 --- a/src/soc/intel/denverton_ns/Kconfig +++ b/src/soc/intel/denverton_ns/Kconfig @@ -16,6 +16,7 @@ select BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY if BOOT_DEVICE_SPI_FLASH select BOOT_DEVICE_SUPPORTS_WRITES select DEBUG_GPIO + select CPU_INTEL_COMMON select SOC_INTEL_COMMON select SOC_INTEL_COMMON_RESET select PLATFORM_USES_FSP2_0
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45040 )
Change subject: soc/intel/denverton_ns: Select CPU_INTEL_COMMON ......................................................................
Patch Set 1: Code-Review+2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45040 )
Change subject: soc/intel/denverton_ns: Select CPU_INTEL_COMMON ......................................................................
Patch Set 1:
same question :) is VMX supported ?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45040 )
Change subject: soc/intel/denverton_ns: Select CPU_INTEL_COMMON ......................................................................
Patch Set 1:
Patch Set 1:
same question :) is VMX supported ?
I can't see any UPDs to enable it, but the ENABLE_VMX option does not have any effect on the binary. I don't see anything to hide ENABLE_VMX from showing up if not supported on a platform, but this calls for a separate patch.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45040 )
Change subject: soc/intel/denverton_ns: Select CPU_INTEL_COMMON ......................................................................
Patch Set 1: Code-Review-1
Patch Set 1:
Patch Set 1:
same question :) is VMX supported ?
I can't see any UPDs to enable it, but the ENABLE_VMX option does not have any effect on the binary. I don't see anything to hide ENABLE_VMX from showing up if not supported on a platform, but this calls for a separate patch.
CPU_INTEL_COMMON is *the* mechanism to hide it. The question is, why do you want to select it?
Angel Pons has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/45040 )
Change subject: soc/intel/denverton_ns: Select CPU_INTEL_COMMON ......................................................................
Removed Code-Review+2 by Felix Singer felixsinger@posteo.net
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45040 )
Change subject: soc/intel/denverton_ns: Select CPU_INTEL_COMMON ......................................................................
Patch Set 1:
superseeded by CB:46474, which also adds the common code call for setting vmx and locking fc
Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/45040 )
Change subject: soc/intel/denverton_ns: Select CPU_INTEL_COMMON ......................................................................
Abandoned
-
Angel Pons (Code Review) -
Felix Singer (Code Review)
-
HAOUAS Elyes (Code Review)
-
Michael Niewöhner (Code Review)
-
Nico Huber (Code Review)