Attention is currently required from: Nico Huber, Matt DeVillier, Michael Niewöhner. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50829 )
Change subject: [RFC] Address the leftover TODO in soc/intel/cannonlake ......................................................................
Patch Set 2:
(1 comment)
File Documentation/RFC/intel-gpio-cleanup.md:
https://review.coreboot.org/c/coreboot/+/50829/comment/1e3370a2_507bfa0a PS1, Line 83: - Add a Kconfig `DEBUG_GPIO_CHECK_FSP_OVERWRITE` that enables checks : in coreboot to stash GPIO pad configuration before various calls : to FSP and compares the configuration on return from FSP. : - This will have to be implemented as part of : drivers/intel/fsp/fsp2_0/ to check for the above config selection : and make callbacks `gpio_snapshot()` and `gpio_verify_snapshot()` : to identify and print information about pads that have changed : configuration after calls to FSP. : - This config can be kept disabled by default and mainboard : developers can enable them as and when required for debug. : - This will be helpful not just for the `soc/intel/cannonlake` : platforms that want to get rid of the above workaround, but also : for all future platforms using FSP to identify and catch any GPIO : misconfigurations that might slip in to any platforms (in case the : `GpioOerrvide` UPD is not honored by any code path within FSP). :
mind pushing a patch for that? :)
Pushed patches here - CB:50989, CB:50990