[S] Change in coreboot[master]: drivers/fsp2: Don't die if the FSP signature doesn't match

[Subrata Banik (Code Review)]

Attention is currently required from: Jason Glenesk, Martin L Roth, Andrey Petrov, Fred Reitberger, Felix Held.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69412 )

Change subject: drivers/fsp2: Don't die if the FSP signature doesn't match
......................................................................

Patch Set 3:

(2 comments)

Patchset:

PS3: 
IMO, this is living with a bug that existed in FSP.

why can't we fix the bug proper inside FSP rather allowing coreboot to skip the check and fail somewhere else inside FSP. wondering if u came across such situations and know where it might fail? To me it's just a compliance check that FSP should meet.

Have you consider a case with non-serial coreboot image flashed then we might miss the opportunity to catch such issue in coreboot space and pushed it into some unknown territory of FSP.

File src/drivers/intel/fsp2_0/util.c:

https://review.coreboot.org/c/coreboot/+/69412/comment/a5cc274b_95785d08 
PS3, Line 177: If it doesn't match, the
             :    FSP binaries in CBFS are for a different platform than the platform code trying to use it
IMO, it would allow some mismatch, for example: I can now stitch and call into ADL-FSP binaries for MTL platform 😊