Attention is currently required from: Arthur Heymans.
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74180 )
Change subject: nb/intel/gm45: Export EDID-reading routine as a function ......................................................................
Patch Set 2:
(1 comment)
File src/northbridge/intel/gm45/gma.c:
https://review.coreboot.org/c/coreboot/+/74180/comment/9de8d783_33c63916 PS2, Line 161: /* : * GTT base is at a 2M offset and is 2M big. If GTT is smaller than 2M : * cycles are simply not decoded which is fine. : */ : pci_or_config16(dev, PCI_COMMAND, PCI_COMMAND_MASTER); : memset(mmio + 2 * MiB, 0, 2 * MiB);
Not needed for getting EDID.
Should it be moved into gma_func0_init()?