Attention is currently required from: Lance Zhao, Martin Roth, Akshu Agrawal, Marshall Dawson, Jason Glenesk, Matt Papageorge, Karthik Ramasubramanian.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52037 )
Change subject: acpi: Add support to generate upep structure
......................................................................
Patch Set 6:
(1 comment)
File src/acpi/acpigen_upep.c:
https://review.coreboot.org/c/coreboot/+/52037/comment/23a7fa69_b96ad4cb
PS6, Line 88: acpigen_write_method
How would we feel if we instead wrote all this in .asl and only left the constraint generation or what ever needs to be dynamically generated using acpigen?
Intel has some of their PEP implementation in asl: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/thir...
Reading acpigen code is tough, and it's also not checked by the acpi compiler.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52037
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4b64ddc9ebee251f3b50e81374c1b32cf5b1aeca
Gerrit-Change-Number: 52037
Gerrit-PatchSet: 6
Gerrit-Owner: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: Akshu Agrawal
akshu.agrawal@amd.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Akshu Agrawal
akshu.agrawal@amd.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Attention: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 15 Apr 2021 22:56:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment