Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/52553 )
Change subject: soc/amd/picasso/chip.h: use boolean type for smt_disable ......................................................................
soc/amd/picasso/chip.h: use boolean type for smt_disable
Even though the UPD field this information is finally written to is an 8 bit value, the smt_disable option is only a boolean.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Iaac49944993a28ffb98a80201effe1238ec60875 Reviewed-on: https://review.coreboot.org/c/coreboot/+/52553 Reviewed-by: Raul Rangel rrangel@chromium.org Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/picasso/chip.h 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved Raul Rangel: Looks good to me, approved
diff --git a/src/soc/amd/picasso/chip.h b/src/soc/amd/picasso/chip.h index 4329bdd..e357f54 100644 --- a/src/soc/amd/picasso/chip.h +++ b/src/soc/amd/picasso/chip.h @@ -146,7 +146,7 @@ DOWNCORE_2 = 3, /* Run with two cores */ DOWNCORE_3 = 4, /* Run with three cores */ } downcore_mode; - uint8_t smt_disable; /* 1=disable SMT, 0=enable SMT */ + bool smt_disable; /* true=disable SMT on all physical cores */
/* Lower die temperature limit */ uint32_t thermctl_limit_degreeC;