Change in coreboot[master]: mb/pcengines/apu2/OemCustomize.c: make AGESA AmdInitPost happy - coreboot-gerrit

7 May 2021


      Attention is currently required from: Michał Żygowski, Piotr Król.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52759 )
Change subject: mb/pcengines/apu2/OemCustomize.c: make AGESA AmdInitPost happy
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/pcengines/apu2/OemCustomize.c:
https://review.coreboot.org/c/coreboot/+/52759/comment/44d51ee2_fd104762 
PS1, Line 92: 	if (get_spd_offset())
not really related to this patch: get_spd_offset() returns a value between 0 and 3 inclusive, but there are only two dram configurations in the makefile; is this intended? when GPIO_50 is 1 it'll probably call die() in read_ddr3_spd_from_cbfs
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52759
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I010645f53b404341895d0545855905e81c89165e
Gerrit-Change-Number: 52759
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Piotr Król piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-Attention: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Attention: Piotr Król piotr.krol@3mdeb.com
Gerrit-Comment-Date: Thu, 06 May 2021 22:48:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment