Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/51384 )
Change subject: mb/google/zork: Use SOC defines instead of magic numbers ......................................................................
mb/google/zork: Use SOC defines instead of magic numbers
BUG=b:182269526 TEST=builds
Signed-off-by: Mathew King mathewk@chromium.org Change-Id: I351fb4fc493bb92b31e2c8bc946dfb048045335c Reviewed-on: https://review.coreboot.org/c/coreboot/+/51384 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/google/zork/variants/baseboard/include/baseboard/gpio.h 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/src/mainboard/google/zork/variants/baseboard/include/baseboard/gpio.h b/src/mainboard/google/zork/variants/baseboard/include/baseboard/gpio.h index 389f0e8..87bd291 100644 --- a/src/mainboard/google/zork/variants/baseboard/include/baseboard/gpio.h +++ b/src/mainboard/google/zork/variants/baseboard/include/baseboard/gpio.h @@ -20,10 +20,10 @@ #endif /* _ACPI__ */
/* These define the GPE, not the GPIO. */ -#define EC_SCI_GPI 3 /* eSPI system event -> GPE 3 */ -#define EC_WAKE_GPI 15 /* AGPIO 24 -> GPE 15 */ +#define EC_SCI_GPI GEVENT_3 /* AGPIO 22 -> GPE 3 */ +#define EC_WAKE_GPI GEVENT_15 /* AGPIO 24 -> GPE 15 */
/* EC sync irq */ -#define EC_SYNC_IRQ 31 +#define EC_SYNC_IRQ GPIO_31
#endif /* __BASEBOARD_GPIO_H__ */