Lean Sheng Tan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74270 )
Change subject: util/cbfstool: Qualify struct e820entry as packed ......................................................................
util/cbfstool: Qualify struct e820entry as packed
In order to accord with grub (see include/grub/i386/linux.h) and comments for offsets of members of struct linux_params, struct e820entry should be defined as __packed, otherwise, sizeof(struct linux_params) will become 4224 (0x1080).
Fortunately, the affected area is usually not occupied.
Signed-off-by: Bill XIE persmule@hardenedlinux.org Change-Id: I09955c90e4eec337adca383e628a8821075381d6 Reviewed-on: https://review.coreboot.org/c/coreboot/+/74270 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Paul Menzel paulepanter@mailbox.org Reviewed-by: Nico Huber nico.h@gmx.de --- M util/cbfstool/linux.h 1 file changed, 23 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Paul Menzel: Looks good to me, but someone else must approve Arthur Heymans: Looks good to me, approved
diff --git a/util/cbfstool/linux.h b/util/cbfstool/linux.h index dc4575c..2905f35 100644 --- a/util/cbfstool/linux.h +++ b/util/cbfstool/linux.h @@ -27,7 +27,7 @@ #define E820_RESERVED 2 #define E820_ACPI 3 /* usable as RAM once ACPI tables have been read */ #define E820_NVS 4 -}; +} __packed;
/* The header of Linux/i386 kernel */ struct linux_header {