Attention is currently required from: Nico Huber. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56210 )
Change subject: console: Handle verstage as "first non-bootblock stage" ......................................................................
Patch Set 1:
(1 comment)
File src/console/init.c:
https://review.coreboot.org/c/coreboot/+/56210/comment/951d3abe_a5634812 PS1, Line 15: #endif
The idea was to give systems that don't use get_option() before the […]
Okay, I see. I'm not sure where exactly I commented on this before, but generally I'm more concerned about the console being dependent on something that may require platform-specific setup which they then don't get a chance to do. That should not be an issue if the first console output comes in romstage (because there's still a bootblock able to set things up, even if it doesn't print anything). Sounds like what you were going for is more of a "make this easier to debug if there's a bug in get_option()"... for those kinds of one-time-issue-until-it-gets-fixed problems, I think it should be okay for developers to hack around it if necessary.
If you don't care that much either way, I think I would prefer using ENV_INITIAL_STAGE here so we can consolidate all that stage ordering logic a bit more.
-
Julius Werner (Code Review)