Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35680 )
Change subject: cpu/qemu-x86: Add x86_64 bootblock support
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35680/6/src/cpu/qemu-x86/cache_as_r...
File src/cpu/qemu-x86/cache_as_ram_bootblock.S:
https://review.coreboot.org/c/coreboot/+/35680/6/src/cpu/qemu-x86/cache_as_r...
PS6, Line 44: movd %mm1, %rdi
: shld %rdi, 32
: movd %mm1, %rsi
: or %rsi, %rdi
: movd %mm2, %rsi
Same as code below, move %mm0 - %mm2 into the register that are used as arguments for bootblock_c_ […]
Ack
https://review.coreboot.org/c/coreboot/+/35680/2/src/cpu/x86/64bit/entry64.i...
File src/cpu/x86/64bit/entry64.inc:
https://review.coreboot.org/c/coreboot/+/35680/2/src/cpu/x86/64bit/entry64.i...
PS2, Line 25: $(CONFIG_ARCH_X86_64_PGTBL_LOC)
It can be located using walkcbfs, but there's no benefit, as the address is always CONFIG_ARCH_X86_6 […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35680
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec92c6cea464c97c18a0811e2e91bc22133ace42
Gerrit-Change-Number: 35680
Gerrit-PatchSet: 7
Gerrit-Owner: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Alexandru Gagniuc
alexandrux.gagniuc@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Gerd Hoffmann
kraxel@redhat.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Name of user not set #1002476
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 04 Nov 2019 11:58:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment