[coreboot-gerrit] Change in coreboot[master]: cpu/qemu-x86: Add x86_64 bootblock support

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35680 )

Change subject: cpu/qemu-x86: Add x86_64 bootblock support
......................................................................

Patch Set 7:

(2 comments)

https://review.coreboot.org/c/coreboot/+/35680/6/src/cpu/qemu-x86/cache_as_r... 
File src/cpu/qemu-x86/cache_as_ram_bootblock.S:

https://review.coreboot.org/c/coreboot/+/35680/6/src/cpu/qemu-x86/cache_as_r... 
PS6, Line 44: movd	%mm1, %rdi
            : 	shld	%rdi, 32
            : 	movd	%mm1, %rsi
            : 	or	%rsi, %rdi
            : 	movd	%mm2, %rsi
> > Same as code below, move %mm0 - %mm2 into the register that are used as arguments for bootblock_c_ […]

Ack

https://review.coreboot.org/c/coreboot/+/35680/2/src/cpu/x86/64bit/entry64.i... 
File src/cpu/x86/64bit/entry64.inc:

https://review.coreboot.org/c/coreboot/+/35680/2/src/cpu/x86/64bit/entry64.i... 
PS2, Line 25: $(CONFIG_ARCH_X86_64_PGTBL_LOC)
> It can be located using walkcbfs, but there's no benefit, as the address is always CONFIG_ARCH_X86_6 […]

Ack