Attention is currently required from: Tarun Tuli, David Wu, Kangheui Won, Ren Kuo, Tyler Wang, Nick Vaccaro, Eric Lai.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69693 )
Change subject: mb/google/nissa/var/craask: Modify functions for craaskneto/craaskino ......................................................................
Patch Set 9:
(6 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164429): https://review.coreboot.org/c/coreboot/+/69693/comment/ff702d14_24067ee1 PS9, Line 11: 2. Modfiy fw_config gpio table to skip the LTE and WFC setting from craask. Possible unwrapped commit description (prefer a maximum 72 chars per line)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164429): https://review.coreboot.org/c/coreboot/+/69693/comment/2f8d392b_5ad4355f PS9, Line 11: 2. Modfiy fw_config gpio table to skip the LTE and WFC setting from craask. 'Modfiy' may be misspelled - perhaps 'Modify'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164429): https://review.coreboot.org/c/coreboot/+/69693/comment/ec36169a_98dba6e0 PS9, Line 13: 4. Add keybaord backligt definiation for EC 'definiation' may be misspelled - perhaps 'definition'?
File src/mainboard/google/brya/variants/craask/gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164429): https://review.coreboot.org/c/coreboot/+/69693/comment/9e45bc87_fb39b161 PS9, Line 181: }else { space required after that close brace '}'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164429): https://review.coreboot.org/c/coreboot/+/69693/comment/9ac54f07_d1f16abc PS9, Line 194: }else { space required after that close brace '}'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164429): https://review.coreboot.org/c/coreboot/+/69693/comment/cfefa167_4bc43e81 PS9, Line 207: }else { space required after that close brace '}'