Change in coreboot[master]: crossgcc: Upgrade nasm to version 2.15.04

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44694 )

Change subject: crossgcc: Upgrade nasm to version 2.15.04
......................................................................

crossgcc: Upgrade nasm to version 2.15.04

Changes:
https://nasm.us/doc/nasmdocc.html
"Correct the encoding of the ENQCMDS and TILELOADT1 instructions.
Fix case where the COFF backend (the coff, win32 and win64 output
formats) would add padding bytes in the middle of a section if a
SECTION/SEGMENT directive was provided which repeated an
ALIGN= attribute. This neither matched legacy behavior, other
backends, or user expectations.
Fix SSE instructions not being recognized with an explicit memory
operation size (e.g. movsd qword [eax],xmm0)."

Change-Id: I3f9aa8e743f2dc50fce1ce68718c0ae17209a509
Signed-off-by: Elyes HAOUAS 
---
M util/crossgcc/buildgcc
D util/crossgcc/sum/nasm-2.15.03.tar.bz2.cksum
A util/crossgcc/sum/nasm-2.15.04.tar.bz2.cksum
3 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/44694/1

diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index 0f9cac5..4e23f8d 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -46,7 +46,7 @@
 # CLANG version number
 CLANG_VERSION=10.0.1
 CMAKE_VERSION=3.18.1
-NASM_VERSION=2.15.03
+NASM_VERSION=2.15.04

# GCC toolchain archive locations
 # These are sanitized by the jenkins toolchain test builder, so if
diff --git a/util/crossgcc/sum/nasm-2.15.03.tar.bz2.cksum b/util/crossgcc/sum/nasm-2.15.03.tar.bz2.cksum
deleted file mode 100644
index 6033fae..0000000
--- a/util/crossgcc/sum/nasm-2.15.03.tar.bz2.cksum
+++ /dev/null
@@ -1 +0,0 @@
-513ac3b800377f10833a02bc7f3fa8b84ca4f2b6  tarballs/nasm-2.15.03.tar.bz2
diff --git a/util/crossgcc/sum/nasm-2.15.04.tar.bz2.cksum b/util/crossgcc/sum/nasm-2.15.04.tar.bz2.cksum
new file mode 100644
index 0000000..0bbb229
--- /dev/null
+++ b/util/crossgcc/sum/nasm-2.15.04.tar.bz2.cksum
@@ -0,0 +1 @@
+062aa2dea69fcb8a2b3f387e349a80531f70475c  tarballs/nasm-2.15.04.tar.bz2

Change in coreboot[master]: crossgcc: Upgrade nasm to version 2.15.05

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins), Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44694

to look at the new patch set (#2).

Change subject: crossgcc: Upgrade nasm to version 2.15.05
......................................................................

crossgcc: Upgrade nasm to version 2.15.05

Changes (https://nasm.us/doc/nasmdocc.html):
Version 2.15.05:
Correct %ifid $ and %ifid $$ being treated as true.
Add --reproducible option to suppress NASM version numbers and
timestamps in output files.

Version 2.15.04:
"Correct the encoding of the ENQCMDS and TILELOADT1 instructions.
Fix case where the COFF backend (the coff, win32 and win64 output
formats) would add padding bytes in the middle of a section if a
SECTION/SEGMENT directive was provided which repeated an
ALIGN= attribute. This neither matched legacy behavior, other
backends, or user expectations.
Fix SSE instructions not being recognized with an explicit memory
operation size (e.g. movsd qword [eax],xmm0)."

Change-Id: I3f9aa8e743f2dc50fce1ce68718c0ae17209a509
Signed-off-by: Elyes HAOUAS 
---
M util/crossgcc/buildgcc
D util/crossgcc/sum/nasm-2.15.03.tar.bz2.cksum
A util/crossgcc/sum/nasm-2.15.05.tar.bz2.cksum
3 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/44694/2

Change in coreboot[master]: crossgcc: Upgrade nasm to version 2.15.05

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44694 )

Change subject: crossgcc: Upgrade nasm to version 2.15.05
......................................................................

Patch Set 2: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/44694/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/44694/2//COMMIT_MSG@24 
PS2, Line 24: 
Tested how? Do you have the resources to do a BUILD_TIMELESS comparison?

Change in coreboot[master]: crossgcc: Upgrade nasm to version 2.15.05

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44694 )

Change subject: crossgcc: Upgrade nasm to version 2.15.05
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44694/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/44694/2//COMMIT_MSG@24 
PS2, Line 24:
> Tested how? Do you have the resources to do a BUILD_TIMELESS comparison?

Not tested.
I think that toolchain will change binary for sure.

Change in coreboot[master]: crossgcc: Upgrade nasm to version 2.15.05

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Paul Menzel,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44694

to look at the new patch set (#3).

Change subject: crossgcc: Upgrade nasm to version 2.15.05
......................................................................

crossgcc: Upgrade nasm to version 2.15.05

Changes (https://nasm.us/doc/nasmdocc.html):
Version 2.15.05:
Correct %ifid $ and %ifid $$ being treated as true.
Add --reproducible option to suppress NASM version numbers and
timestamps in output files.

Version 2.15.04:
Correct the encoding of the ENQCMDS and TILELOADT1 instructions.
Fix case where the COFF backend (the coff, win32 and win64 output
formats) would add padding bytes in the middle of a section if a
SECTION/SEGMENT directive was provided which repeated an
ALIGN= attribute. This neither matched legacy behavior, other
backends, or user expectations.
Fix SSE instructions not being recognized with an explicit memory
operation size (e.g. movsd qword [eax],xmm0).

Change-Id: I3f9aa8e743f2dc50fce1ce68718c0ae17209a509
Signed-off-by: Elyes HAOUAS 
---
M util/crossgcc/buildgcc
D util/crossgcc/sum/nasm-2.15.03.tar.bz2.cksum
A util/crossgcc/sum/nasm-2.15.05.tar.bz2.cksum
3 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/44694/3

Change in coreboot[master]: crossgcc: Upgrade nasm to version 2.15.05

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44694 )

Change subject: crossgcc: Upgrade nasm to version 2.15.05
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44694/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/44694/2//COMMIT_MSG@24 
PS2, Line 24:
> Not tested. […]

It’d be great if you tested it for your board for example.

Change in coreboot[master]: crossgcc: Upgrade nasm to version 2.15.05

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44694 )

Change subject: crossgcc: Upgrade nasm to version 2.15.05
......................................................................

Patch Set 3:

(1 comment)

Thx

https://review.coreboot.org/c/coreboot/+/44694/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/44694/2//COMMIT_MSG@24 
PS2, Line 24:
> It’d be great if you tested it for your board for example.

tested on 945g-m4 :
27 entries total:

0:1st timestamp                                     541
  11:start of bootblock                                20,726 (20,185)
  12:end of bootblock                                  103,428 (82,701)
  13:starting to load romstage                         292,012 (188,584)
  14:finished loading romstage                         330,002 (37,989)
   1:start of romstage                                 425,534 (95,531)
   2:before RAM initialization                         667,336 (241,801)
   3:after RAM initialization                          2,252,077 (1,584,741)
   4:end of romstage                                   4,023,480 (1,771,403)
 100:start of postcar                                  4,073,464 (49,983)
 101:end of postcar                                    4,073,465 (0)
   8:starting to load ramstage                         4,084,216 (10,751)
  15:starting LZMA decompress (ignore for x86)         4,090,050 (5,833)
  16:finished LZMA decompress (ignore for x86)         4,156,885 (66,835)
   9:finished loading ramstage                         4,169,143 (12,257)
  10:start of ramstage                                 4,183,207 (14,064)
  30:device enumeration                                4,184,358 (1,150)
  40:device configuration                              4,453,923 (269,565)
  50:device enable                                     5,506,158 (1,052,235)
  60:device initialization                             5,611,621 (105,463)
  70:device setup done                                 6,756,053 (1,144,431)
  75:cbmem post                                        6,761,002 (4,948)
  80:write tables                                      6,761,005 (3)
  85:finalize chips                                    7,174,728 (413,723)
  90:load payload                                      7,180,021 (5,292)
  15:starting LZMA decompress (ignore for x86)         7,221,153 (41,132)
  16:finished LZMA decompress (ignore for x86)         7,295,898 (74,745)
  99:selfboot jump                                     7,314,360 (18,461)

Total Time: 7,313,806

and here is the log: https://pastebin.com/XjTiNgBc

Change in coreboot[master]: crossgcc: Upgrade nasm to version 2.15.05

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44694 )

Change subject: crossgcc: Upgrade nasm to version 2.15.05
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44694/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/44694/2//COMMIT_MSG@24 
PS2, Line 24:
> tested on 945g-m4 : […]

Did the BUILD_TIMELESS hash change?

Change in coreboot[master]: crossgcc: Upgrade nasm to version 2.15.05

[Stefan Reinauer (Code Review)]

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44694 )

Change subject: crossgcc: Upgrade nasm to version 2.15.05
......................................................................

Patch Set 3: Code-Review+2

Change in coreboot[master]: crossgcc: Upgrade nasm to version 2.15.05

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44694 )

Change subject: crossgcc: Upgrade nasm to version 2.15.05
......................................................................

crossgcc: Upgrade nasm to version 2.15.05

Changes (https://nasm.us/doc/nasmdocc.html):
Version 2.15.05:
Correct %ifid $ and %ifid $$ being treated as true.
Add --reproducible option to suppress NASM version numbers and
timestamps in output files.

Version 2.15.04:
Correct the encoding of the ENQCMDS and TILELOADT1 instructions.
Fix case where the COFF backend (the coff, win32 and win64 output
formats) would add padding bytes in the middle of a section if a
SECTION/SEGMENT directive was provided which repeated an
ALIGN= attribute. This neither matched legacy behavior, other
backends, or user expectations.
Fix SSE instructions not being recognized with an explicit memory
operation size (e.g. movsd qword [eax],xmm0).

Change-Id: I3f9aa8e743f2dc50fce1ce68718c0ae17209a509
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44694
Reviewed-by: Stefan Reinauer 
Reviewed-by: Paul Menzel 
Tested-by: build bot (Jenkins) 
---
M util/crossgcc/buildgcc
D util/crossgcc/sum/nasm-2.15.03.tar.bz2.cksum
A util/crossgcc/sum/nasm-2.15.05.tar.bz2.cksum
3 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Stefan Reinauer: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve

diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index 375e49d..958a541 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -46,7 +46,7 @@
 # CLANG version number
 CLANG_VERSION=10.0.1
 CMAKE_VERSION=3.18.1
-NASM_VERSION=2.15.03
+NASM_VERSION=2.15.05

# GCC toolchain archive locations
 # These are sanitized by the jenkins toolchain test builder, so if
diff --git a/util/crossgcc/sum/nasm-2.15.03.tar.bz2.cksum b/util/crossgcc/sum/nasm-2.15.03.tar.bz2.cksum
deleted file mode 100644
index 6033fae..0000000
--- a/util/crossgcc/sum/nasm-2.15.03.tar.bz2.cksum
+++ /dev/null
@@ -1 +0,0 @@
-513ac3b800377f10833a02bc7f3fa8b84ca4f2b6  tarballs/nasm-2.15.03.tar.bz2
diff --git a/util/crossgcc/sum/nasm-2.15.05.tar.bz2.cksum b/util/crossgcc/sum/nasm-2.15.05.tar.bz2.cksum
new file mode 100644
index 0000000..4ee4fec
--- /dev/null
+++ b/util/crossgcc/sum/nasm-2.15.05.tar.bz2.cksum
@@ -0,0 +1 @@
+c0869e9ac854140bf99c989a711102ce6367243f  tarballs/nasm-2.15.05.tar.bz2