Change in coreboot[master]: sb/intel/bd82x6x: Read ME MBP HWA request

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45266 )

Change subject: sb/intel/bd82x6x: Read ME MBP HWA request
......................................................................

sb/intel/bd82x6x: Read ME MBP HWA request

On AMT-enabled systems, the ME can request some information about the
hardware with a HWA request, which is a specific type of MBP item.

Read the information provided by this item into the MBP data struct.
This silences a spurious error about an unknown MBP item. Handling the
HWA request is not simple, and does not appear to be necessary anyway.

Change-Id: I4bddad6cbfaaad6854266d760f86c9a90705a200
Signed-off-by: Angel Pons 
---
M src/southbridge/intel/bd82x6x/me.h
M src/southbridge/intel/bd82x6x/me_8.x.c
2 files changed, 16 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/45266/1

diff --git a/src/southbridge/intel/bd82x6x/me.h b/src/southbridge/intel/bd82x6x/me.h
index 29089a9..2290c63 100644
--- a/src/southbridge/intel/bd82x6x/me.h
+++ b/src/southbridge/intel/bd82x6x/me.h
@@ -354,6 +354,17 @@
 }  __packed platform_type_rule_data;

typedef struct {
+	union {
+		u32 data;
+		struct {
+			u32 media_table_push :  1;
+			u32 reserved	     : 31;
+		} bits;
+	};
+	u8 available;
+}  __packed mbp_hwa_request;
+
+typedef struct {
    mefwcaps_sku fw_capabilities;
    u8      available;
 } mbp_fw_caps;
@@ -382,6 +393,7 @@
    mbp_icc_profile	    icc_profile;
    tdt_state_info	    at_state;
    u32		    mfsintegrity;
+	mbp_hwa_request	    hwa_request;
 } me_bios_payload;

typedef  struct {
diff --git a/src/southbridge/intel/bd82x6x/me_8.x.c b/src/southbridge/intel/bd82x6x/me_8.x.c
index 96e9a51..a701315 100644
--- a/src/southbridge/intel/bd82x6x/me_8.x.c
+++ b/src/southbridge/intel/bd82x6x/me_8.x.c
@@ -320,6 +320,10 @@
    	case MBP_IDENT(KERNEL, MFS_FAILURE):
    		SET_UP_COPY(mfsintegrity);

+		case MBP_IDENT(HWA, REQUEST):
+			mbp_data->hwa_request.available = 1;
+			SET_UP_COPY(hwa_request.data);
+
    	default:
    		printk(BIOS_ERR, "ME: Unknown MBP item! Skipping...\n");
    		while (copy_size--)

[Angel Pons (Code Review)]

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/45266 )

Change subject: sb/intel/bd82x6x: Read ME MBP HWA request
......................................................................

Abandoned

Rotten