Change in coreboot[master]: drivers/aspeed/common: Reduce severity of `EDID not found` log message

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Angel Pons (Code Review)

10 Sep 2020 10 Sep '20

2:15 a.m.

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45234 )

Change subject: drivers/aspeed/common: Reduce severity of `EDID not found` log message ......................................................................

drivers/aspeed/common: Reduce severity of `EDID not found` log message

Servers often run headless, so a missing EDID isn't a problem. However, we still need to initialize a framebuffer for the BMC's KVM function.

Reduce the log level to BIOS_INFO to avoid confusion.

Change-Id: Ice17bf6fdda0ce34e686dbf8f3a1fa92ba869d7c Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/drivers/aspeed/common/ast_mode_corebootfb.c 1 file changed, 5 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/45234/1

diff --git a/src/drivers/aspeed/common/ast_mode_corebootfb.c b/src/drivers/aspeed/common/ast_mode_corebootfb.c index 8418b01..92c8ada 100644 --- a/src/drivers/aspeed/common/ast_mode_corebootfb.c +++ b/src/drivers/aspeed/common/ast_mode_corebootfb.c @@ -96,7 +96,11 @@ ast_software_i2c_read(ast, raw);

if (decode_edid(raw, sizeof(raw), edid) != EDID_CONFORMANT) { - dev_err(dev->pdev, "Failed to decode EDID\n"); + /* + * Servers often run headless, so a missing EDID is not an error. + * We still need to initialize a framebuffer for KVM, though. + */ + dev_dbg(dev->pdev, "Failed to decode EDID\n"); printk(BIOS_DEBUG, "Assuming VGA for KVM\n");

memset(edid, 0, sizeof(*edid));

Attachments:

attachment.htm (text/html — 3.1 KB)

Show replies by date

Angel Pons (Code Review)

10 Sep 10 Sep

2:16 a.m.

Angel Pons has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/45234 )

Change subject: drivers/aspeed/common: Reduce severity of `EDID not found` log message ......................................................................

drivers/aspeed/common: Reduce severity of `EDID not found` log message

Servers often run headless, so a missing EDID isn't a problem. However, we still need to initialize a framebuffer for the BMC's KVM function.

Reduce the log level to BIOS_INFO to avoid confusion.

Change-Id: Ice17bf6fdda0ce34e686dbf8f3a1fa92ba869d7c Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/drivers/aspeed/common/ast_mode_corebootfb.c 1 file changed, 5 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/45234/2

Patrick Rudolph (Code Review)

4:03 a.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45234 )

Change subject: drivers/aspeed/common: Reduce severity of `EDID not found` log message ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45234 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ice17bf6fdda0ce34e686dbf8f3a1fa92ba869d7c Gerrit-Change-Number: 45234 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 10 Sep 2020 11:03:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

7:48 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45234 )

Change subject: drivers/aspeed/common: Reduce severity of `EDID not found` log message ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45234/2/src/drivers/aspeed/common/a... File src/drivers/aspeed/common/ast_mode_corebootfb.c:

https://review.coreboot.org/c/coreboot/+/45234/2/src/drivers/aspeed/common/a... PS2, Line 103: dev_info(dev->pdev, "Failed to decode EDID\n"); Extend the log message so the comment can be removed?

...

Failed to decode EDID. Fine on headless server. Initialize the framebuffer for KVM.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45234 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ice17bf6fdda0ce34e686dbf8f3a1fa92ba869d7c Gerrit-Change-Number: 45234 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 10 Sep 2020 14:48:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

7:52 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45234 )

Change subject: drivers/aspeed/common: Reduce severity of `EDID not found` log message ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45234/2/src/drivers/aspeed/common/a... File src/drivers/aspeed/common/ast_mode_corebootfb.c:

https://review.coreboot.org/c/coreboot/+/45234/2/src/drivers/aspeed/common/a... PS2, Line 103: dev_info(dev->pdev, "Failed to decode EDID\n");

...

Extend the log message so the comment can be removed? […]

I'd rather keep the comment.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45234 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ice17bf6fdda0ce34e686dbf8f3a1fa92ba869d7c Gerrit-Change-Number: 45234 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 10 Sep 2020 14:52:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Angel Pons (Code Review)

14 Sep 14 Sep

3:54 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45234 )

Change subject: drivers/aspeed/common: Reduce severity of `EDID not found` log message ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45234/2/src/drivers/aspeed/common/a... File src/drivers/aspeed/common/ast_mode_corebootfb.c:

https://review.coreboot.org/c/coreboot/+/45234/2/src/drivers/aspeed/common/a... PS2, Line 103: dev_info(dev->pdev, "Failed to decode EDID\n");

...

I'd rather keep the comment.

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/45234 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ice17bf6fdda0ce34e686dbf8f3a1fa92ba869d7c Gerrit-Change-Number: 45234 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 14 Sep 2020 10:54:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Patrick Georgi (Code Review)

16 Sep 16 Sep

12:14 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45234 )

Change subject: drivers/aspeed/common: Reduce severity of `EDID not found` log message ......................................................................

drivers/aspeed/common: Reduce severity of `EDID not found` log message

Servers often run headless, so a missing EDID isn't a problem. However, we still need to initialize a framebuffer for the BMC's KVM function.

Reduce the log level to BIOS_INFO to avoid confusion.

Change-Id: Ice17bf6fdda0ce34e686dbf8f3a1fa92ba869d7c Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45234 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org --- M src/drivers/aspeed/common/ast_mode_corebootfb.c 1 file changed, 5 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved

diff --git a/src/drivers/aspeed/common/ast_mode_corebootfb.c b/src/drivers/aspeed/common/ast_mode_corebootfb.c index 8418b01..b5f794b 100644 --- a/src/drivers/aspeed/common/ast_mode_corebootfb.c +++ b/src/drivers/aspeed/common/ast_mode_corebootfb.c @@ -96,7 +96,11 @@ ast_software_i2c_read(ast, raw);

if (decode_edid(raw, sizeof(raw), edid) != EDID_CONFORMANT) { - dev_err(dev->pdev, "Failed to decode EDID\n"); + /* + * Servers often run headless, so a missing EDID is not an error. + * We still need to initialize a framebuffer for KVM, though. + */ + dev_info(dev->pdev, "Failed to decode EDID\n"); printk(BIOS_DEBUG, "Assuming VGA for KVM\n");

memset(edid, 0, sizeof(*edid));

-- To view, visit https://review.coreboot.org/c/coreboot/+/45234 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ice17bf6fdda0ce34e686dbf8f3a1fa92ba869d7c Gerrit-Change-Number: 45234 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

9elements QA (Code Review)

2:06 a.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45234 )

Change subject: drivers/aspeed/common: Reduce severity of `EDID not found` log message ......................................................................

Patch Set 3:

Automatic boot test returned (PASS/FAIL/TOTAL): 8/1/9 "QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/19551 "QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19550 "QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/19549 "QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19548 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/19547 "HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/19555 "HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/19554 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/19553 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19552

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/45234 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ice17bf6fdda0ce34e686dbf8f3a1fa92ba869d7c Gerrit-Change-Number: 45234 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 16 Sep 2020 09:06:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1524

days inactive

1530

days old

coreboot-gerrit@coreboot.org

7 comments

5 participants

tags (0)

participants (5)

9elements QA (Code Review)
Angel Pons (Code Review)
Patrick Georgi (Code Review)
Patrick Rudolph (Code Review)
Paul Menzel (Code Review)