Attention is currently required from: Angel Pons, Arthur Heymans, Kyösti Mälkki.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78088?usp=email )
Change subject: sb/intel/common/smihandler: Support QEMU CPUs ......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78088/comment/427549df_77b33beb : PS2, Line 14: Implement the simple case where only 1 CPU is present.
What happens on multi-core systems? Looks like it would simply fail and do nothing, which is reasona […]
Yes, it fails if multiple CPUs are enabled on qemu.
File src/southbridge/intel/common/smihandler.c:
https://review.coreboot.org/c/coreboot/+/78088/comment/033dec05_7e875baf : PS2, Line 257: if (detect_num_cpus_via_cpuid() == 1) {
Satisfying this conditional requires use of QEMU commandline argument -n 1 (or was it --cpus 1) ?
Yes, but that's also the default if no argument was given.
https://review.coreboot.org/c/coreboot/+/78088/comment/90a2d2de_d87757bc : PS2, Line 274: if (CONFIG(BOARD_EMULATION_QEMU_X86_Q35)) {
+1
Looks like CB:45476 would be the best solution.
-
Patrick Rudolph (Code Review)