Attention is currently required from: Tarun Tuli, SRIDHAR SIRICILLA, Subrata Banik, Tim Wawrzynczak, Angel Pons.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67760 )
Change subject: soc/intel/alderlake: Don't send early EOP if ME is/should be disabled
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/67760/comment/e80b74a3_4333a30a
PS3, Line 8:
: This option can cause issues when the Intel ME is disabled
have u seen this code? […]
Done
Patchset:
PS3:
@subrata Any feedback on this? Or could we merge PS:1 as to avoid problems in master? […]
Done
File src/soc/intel/alderlake/chip.c:
https://review.coreboot.org/c/coreboot/+/67760/comment/68d65e80_b8fea42c
PS1, Line 207: 0)
can we use the macro instead `0` to define the ME state?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67760
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1cdb97474ba0f37bf61f22d72cd3cc840f817652
Gerrit-Change-Number: 67760
Gerrit-PatchSet: 4
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: SRIDHAR SIRICILLA
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: SRIDHAR SIRICILLA
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Comment-Date: Tue, 08 Nov 2022 15:39:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes
sean@starlabs.systems
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Tim Wawrzynczak
inforichland@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment