Change in ...coreboot[master]: mb/google/dragonegg: Pass FSP-M UPD as per dragonegg requirement

[Subrata Banik (Code Review)]

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31956

Change subject: mb/google/dragonegg: Pass FSP-M UPD as per dragonegg requirement
......................................................................

mb/google/dragonegg: Pass FSP-M UPD as per dragonegg requirement

TEST=Able to boot dragonegg board with LPDDR4 memory.

Change-Id: Idbe0aa79879f2b1a754dd1f6718ad4ba1173e760
Signed-off-by: Subrata Banik 
---
M src/mainboard/google/dragonegg/romstage_fsp_params.c
1 file changed, 62 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/31956/1

diff --git a/src/mainboard/google/dragonegg/romstage_fsp_params.c b/src/mainboard/google/dragonegg/romstage_fsp_params.c
index 633f69e..6afb7a9 100644
--- a/src/mainboard/google/dragonegg/romstage_fsp_params.c
+++ b/src/mainboard/google/dragonegg/romstage_fsp_params.c
@@ -20,6 +20,68 @@
 #include <soc/romstage.h>
 #include <string.h>

+static uintptr_t mainboard_get_spd_data(void)
+{
+	char *spd_file;
+	size_t spd_file_len;
+	int spd_index;
+	const size_t spd_len = CONFIG_DIMM_SPD_SIZE;
+	const char *spd_bin = "spd.bin";
+
+	spd_index = variant_memory_sku();
+	assert(spd_index >= 0);
+	printk(BIOS_INFO, "SPD index %d\n", spd_index);
+
+	/* Load SPD data from CBFS */
+	spd_file = cbfs_boot_map_with_leak(spd_bin, CBFS_TYPE_SPD,
+					   &spd_file_len);
+	if (!spd_file)
+		die("SPD data not found.");
+
+	/* make sure we have at least one SPD in the file. */
+	if (spd_file_len < spd_len)
+		die("Missing SPD data.");
+
+	/* Make sure we did not overrun the buffer */
+	if (spd_file_len < ((spd_index + 1) * spd_len))
+		die("Invalid SPD index.");
+
+	spd_index *= spd_len;
+
+	return (uintptr_t)(spd_file + spd_index);
+}
+
 void mainboard_memory_init_params(FSPM_UPD *mupd)
 {
+	FSP_M_CONFIG *mem_cfg = &mupd->FspmConfig;
+	struct lpddr4_config mem_params;
+
+	memset(&mem_params, 0, sizeof(mem_params));
+	variant_memory_params(&mem_params);
+
+	if (mem_params.dq_map && mem_params.dq_map_size)
+		memcpy(&mem_cfg->DqByteMapCh0, mem_params.dq_map,
+				mem_params.dq_map_size);
+
+	if (mem_params.dqs_map && mem_params.dqs_map_size)
+		memcpy(&mem_cfg->DqsMapCpu2DramCh0, mem_params.dqs_map,
+				mem_params.dqs_map_size);
+
+	memcpy(&mem_cfg->RcompResistor, mem_params.rcomp_resistor,
+		mem_params.rcomp_resistor_size);
+
+	memcpy(&mem_cfg->RcompTarget, mem_params.rcomp_target,
+			mem_params.rcomp_target_size);
+
+	mem_cfg->MemorySpdPtr00 = mainboard_get_spd_data();
+	mem_cfg->MemorySpdPtr10 = mem_cfg->MemorySpdPtr00;
+	mem_cfg->MemorySpdDataLen = CONFIG_DIMM_SPD_SIZE;
+	mem_cfg->DqPinsInterleaved = 0;
+	mem_cfg->CaVrefConfig = 0x2;
+	mem_cfg->ECT = 1; /* Early Command Training Enabled */
+	mem_cfg->RefClk = 0; /* Auto Select CLK freq */
+	mem_cfg->SpdAddressTable[0] = 0x0;
+	mem_cfg->SpdAddressTable[1] = 0x0;
+	mem_cfg->SpdAddressTable[2] = 0x0;
+	mem_cfg->SpdAddressTable[3] = 0x0;
 }

[Subrata Banik (Code Review)]

Subrata Banik has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31956 )

Change subject: mb/google/dragonegg: Pass FSP-M UPD as per dragonegg requirement
......................................................................

Abandoned

[Subrata Banik (Code Review)]

Subrata Banik has restored this change. ( https://review.coreboot.org/c/coreboot/+/31956 )

Change subject: mb/google/dragonegg: Pass FSP-M UPD as per dragonegg requirement
......................................................................

Restored

[Wonkyu Kim (Code Review)]

Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31956 )

Change subject: mb/google/dragonegg: Pass FSP-M UPD as per dragonegg requirement
......................................................................

Patch Set 18: Code-Review+2