Keith Hui has uploaded this change for review. ( https://review.coreboot.org/20868
Change subject: 440BX boards: Use combined RAM init routine. ......................................................................
440BX boards: Use combined RAM init routine.
Change all 440BX boards to use the recently combined RAM init routine[1].
A couple 440BX boards were left out of the cleanup job at [2]. They now receive this cleanup as well.
[1] https://review.coreboot.org/20676 [2] https://review.coreboot.org/20693
Change-Id: I699db882189f99018d4a6fdcb00f9438b2a7a1bc Signed-off-by: Keith Hui buurin@gmail.com --- M src/mainboard/a-trend/atc-6220/romstage.c M src/mainboard/a-trend/atc-6240/romstage.c M src/mainboard/asus/p2b-ds/romstage.c M src/mainboard/asus/p2b-ls/romstage.c M src/mainboard/asus/p2b/romstage.c M src/mainboard/asus/p3b-f/romstage.c M src/mainboard/azza/pt-6ibd/romstage.c M src/mainboard/compaq/deskpro_en_sff_p600/romstage.c M src/mainboard/gigabyte/ga-6bxc/romstage.c M src/mainboard/gigabyte/ga-6bxe/romstage.c M src/mainboard/msi/ms6119/romstage.c M src/mainboard/msi/ms6147/romstage.c M src/mainboard/msi/ms6156/romstage.c M src/mainboard/nokia/ip530/romstage.c M src/mainboard/soyo/sy-6ba-plus-iii/romstage.c M src/mainboard/tyan/s1846/romstage.c 16 files changed, 16 insertions(+), 72 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/20868/1
diff --git a/src/mainboard/a-trend/atc-6220/romstage.c b/src/mainboard/a-trend/atc-6220/romstage.c index 6cf86c1..70e4323 100644 --- a/src/mainboard/a-trend/atc-6220/romstage.c +++ b/src/mainboard/a-trend/atc-6220/romstage.c @@ -39,8 +39,5 @@ report_bist_failure(bist);
enable_smbus(); - dump_spd_registers(); - sdram_set_registers(); - sdram_set_spd_registers(); - sdram_enable(); + sdram_initialize(); } diff --git a/src/mainboard/a-trend/atc-6240/romstage.c b/src/mainboard/a-trend/atc-6240/romstage.c index cbb0207..8dd9686 100644 --- a/src/mainboard/a-trend/atc-6240/romstage.c +++ b/src/mainboard/a-trend/atc-6240/romstage.c @@ -39,8 +39,5 @@ report_bist_failure(bist);
enable_smbus(); - dump_spd_registers(); - sdram_set_registers(); - sdram_set_spd_registers(); - sdram_enable(); + sdram_initialize(); } diff --git a/src/mainboard/asus/p2b-ds/romstage.c b/src/mainboard/asus/p2b-ds/romstage.c index 809f1f6..1d34bd9 100644 --- a/src/mainboard/asus/p2b-ds/romstage.c +++ b/src/mainboard/asus/p2b-ds/romstage.c @@ -39,8 +39,5 @@ report_bist_failure(bist);
enable_smbus(); - dump_spd_registers(); - sdram_set_registers(); - sdram_set_spd_registers(); - sdram_enable(); + sdram_initialize(); } diff --git a/src/mainboard/asus/p2b-ls/romstage.c b/src/mainboard/asus/p2b-ls/romstage.c index 5ed878f..ecfc8b8 100644 --- a/src/mainboard/asus/p2b-ls/romstage.c +++ b/src/mainboard/asus/p2b-ls/romstage.c @@ -40,8 +40,5 @@ report_bist_failure(bist);
enable_smbus(); - dump_spd_registers(); - sdram_set_registers(); - sdram_set_spd_registers(); - sdram_enable(); + sdram_initialize(); } diff --git a/src/mainboard/asus/p2b/romstage.c b/src/mainboard/asus/p2b/romstage.c index 6cf86c1..70e4323 100644 --- a/src/mainboard/asus/p2b/romstage.c +++ b/src/mainboard/asus/p2b/romstage.c @@ -39,8 +39,5 @@ report_bist_failure(bist);
enable_smbus(); - dump_spd_registers(); - sdram_set_registers(); - sdram_set_spd_registers(); - sdram_enable(); + sdram_initialize(); } diff --git a/src/mainboard/asus/p3b-f/romstage.c b/src/mainboard/asus/p3b-f/romstage.c index bb16c78..0bb5bca 100644 --- a/src/mainboard/asus/p3b-f/romstage.c +++ b/src/mainboard/asus/p3b-f/romstage.c @@ -76,10 +76,7 @@
enable_spd();
- dump_spd_registers(); - sdram_set_registers(); - sdram_set_spd_registers(); - sdram_enable(); + sdram_initialize();
disable_spd(); } diff --git a/src/mainboard/azza/pt-6ibd/romstage.c b/src/mainboard/azza/pt-6ibd/romstage.c index c4cfbec..eb031e0 100644 --- a/src/mainboard/azza/pt-6ibd/romstage.c +++ b/src/mainboard/azza/pt-6ibd/romstage.c @@ -14,7 +14,6 @@ * GNU General Public License for more details. */
-#include <stdint.h> #include <device/pci_def.h> #include <device/pnp_def.h> #include <console/console.h> @@ -42,8 +41,5 @@ report_bist_failure(bist);
enable_smbus(); - dump_spd_registers(); - sdram_set_registers(); - sdram_set_spd_registers(); - sdram_enable(); + sdram_initialize(); } diff --git a/src/mainboard/compaq/deskpro_en_sff_p600/romstage.c b/src/mainboard/compaq/deskpro_en_sff_p600/romstage.c index 7a59b1b..712ea96 100644 --- a/src/mainboard/compaq/deskpro_en_sff_p600/romstage.c +++ b/src/mainboard/compaq/deskpro_en_sff_p600/romstage.c @@ -14,15 +14,11 @@ * GNU General Public License for more details. */
-#include <stdint.h> #include <device/pci_def.h> -#include <arch/io.h> #include <device/pnp_def.h> -#include <stdlib.h> #include <console/console.h> #include <southbridge/intel/i82371eb/i82371eb.h> #include <northbridge/intel/i440bx/raminit.h> -#include <delay.h> #include <cpu/x86/bist.h> #include <cpu/intel/romstage.h> /* FIXME: This should be PC97307 (but it's buggy at the moment)! */ @@ -45,8 +41,5 @@ report_bist_failure(bist);
enable_smbus(); - dump_spd_registers(); - sdram_set_registers(); - sdram_set_spd_registers(); - sdram_enable(); + sdram_initialize(); } diff --git a/src/mainboard/gigabyte/ga-6bxc/romstage.c b/src/mainboard/gigabyte/ga-6bxc/romstage.c index 425a615..7f85e0e 100644 --- a/src/mainboard/gigabyte/ga-6bxc/romstage.c +++ b/src/mainboard/gigabyte/ga-6bxc/romstage.c @@ -39,8 +39,5 @@ report_bist_failure(bist);
enable_smbus(); - dump_spd_registers(); - sdram_set_registers(); - sdram_set_spd_registers(); - sdram_enable(); + sdram_initialize(); } diff --git a/src/mainboard/gigabyte/ga-6bxe/romstage.c b/src/mainboard/gigabyte/ga-6bxe/romstage.c index 85b36b9..d4bdbe8 100644 --- a/src/mainboard/gigabyte/ga-6bxe/romstage.c +++ b/src/mainboard/gigabyte/ga-6bxe/romstage.c @@ -40,8 +40,5 @@ report_bist_failure(bist);
enable_smbus(); - dump_spd_registers(); - sdram_set_registers(); - sdram_set_spd_registers(); - sdram_enable(); + sdram_initialize(); } diff --git a/src/mainboard/msi/ms6119/romstage.c b/src/mainboard/msi/ms6119/romstage.c index 7791e91..1d34bd9 100644 --- a/src/mainboard/msi/ms6119/romstage.c +++ b/src/mainboard/msi/ms6119/romstage.c @@ -14,7 +14,6 @@ * GNU General Public License for more details. */
-#include <stdint.h> #include <device/pci_def.h> #include <device/pnp_def.h> #include <console/console.h> @@ -40,8 +39,5 @@ report_bist_failure(bist);
enable_smbus(); - dump_spd_registers(); - sdram_set_registers(); - sdram_set_spd_registers(); - sdram_enable(); + sdram_initialize(); } diff --git a/src/mainboard/msi/ms6147/romstage.c b/src/mainboard/msi/ms6147/romstage.c index 8cda4b8..6ac5ae1 100644 --- a/src/mainboard/msi/ms6147/romstage.c +++ b/src/mainboard/msi/ms6147/romstage.c @@ -40,8 +40,5 @@ report_bist_failure(bist);
enable_smbus(); - dump_spd_registers(); - sdram_set_registers(); - sdram_set_spd_registers(); - sdram_enable(); + sdram_initialize(); } diff --git a/src/mainboard/msi/ms6156/romstage.c b/src/mainboard/msi/ms6156/romstage.c index cf39f52..6a3b7f4 100644 --- a/src/mainboard/msi/ms6156/romstage.c +++ b/src/mainboard/msi/ms6156/romstage.c @@ -14,7 +14,6 @@ * GNU General Public License for more details. */
-#include <stdint.h> #include <device/pci_def.h> #include <device/pnp_def.h> #include <console/console.h> @@ -40,8 +39,5 @@ report_bist_failure(bist);
enable_smbus(); - dump_spd_registers(); - sdram_set_registers(); - sdram_set_spd_registers(); - sdram_enable(); + sdram_initialize(); } diff --git a/src/mainboard/nokia/ip530/romstage.c b/src/mainboard/nokia/ip530/romstage.c index e647aae..fa0585d 100644 --- a/src/mainboard/nokia/ip530/romstage.c +++ b/src/mainboard/nokia/ip530/romstage.c @@ -38,8 +38,5 @@ report_bist_failure(bist);
enable_smbus(); - dump_spd_registers(); - sdram_set_registers(); - sdram_set_spd_registers(); - sdram_enable(); + sdram_initialize(); } diff --git a/src/mainboard/soyo/sy-6ba-plus-iii/romstage.c b/src/mainboard/soyo/sy-6ba-plus-iii/romstage.c index 770a7cb..0bb1ab2 100644 --- a/src/mainboard/soyo/sy-6ba-plus-iii/romstage.c +++ b/src/mainboard/soyo/sy-6ba-plus-iii/romstage.c @@ -14,7 +14,6 @@ * GNU General Public License for more details. */
-#include <stdint.h> #include <device/pci_def.h> #include <device/pnp_def.h> #include <console/console.h> @@ -39,8 +38,5 @@ report_bist_failure(bist);
enable_smbus(); - dump_spd_registers(); - sdram_set_registers(); - sdram_set_spd_registers(); - sdram_enable(); + sdram_initialize(); } diff --git a/src/mainboard/tyan/s1846/romstage.c b/src/mainboard/tyan/s1846/romstage.c index 4819b8a..28aac5d 100644 --- a/src/mainboard/tyan/s1846/romstage.c +++ b/src/mainboard/tyan/s1846/romstage.c @@ -38,8 +38,5 @@ report_bist_failure(bist);
enable_smbus(); - dump_spd_registers(); - sdram_set_registers(); - sdram_set_spd_registers(); - sdram_enable(); + sdram_initialize(); }
-
Keith Hui (Code Review)