Change in coreboot[master]: configs: Add a sample config for scaleway tagada

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Julien Viard de Galbert (Code Review)

7 Nov 2020 7 Nov '20

11:48 p.m.

Julien Viard de Galbert has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47341 )

Change subject: configs: Add a sample config for scaleway tagada ......................................................................

configs: Add a sample config for scaleway tagada

Signed-off-by: Julien Viard de Galbert julien@vdg.name Change-Id: I39fd9aabe7285d39e1883622ee9d6a60c6651b6e --- A configs/config.scaleway_tagada 1 file changed, 14 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/47341/1

diff --git a/configs/config.scaleway_tagada b/configs/config.scaleway_tagada new file mode 100644 index 0000000..1ec73c4 --- /dev/null +++ b/configs/config.scaleway_tagada @@ -0,0 +1,14 @@ +CONFIG_VENDOR_SCALEWAY=y +CONFIG_CBFS_SIZE=0x400000 +CONFIG_CONSOLE_POST=y +# CONFIG_DRIVERS_INTEL_WIFI is not set +# CONFIG_IQAT_ENABLE is not set +CONFIG_ENABLE_HSUART=y +CONFIG_USE_DENVERTON_NS_FSP_CAR=y +CONFIG_SPI_FLASH_NO_FAST_READ=y +CONFIG_PAYLOAD_ELF=y +CONFIG_PAYLOAD_FILE="UEFIPAYLOAD.fd" +CONFIG_DISPLAY_FSP_CALLS_AND_STATUS=y +CONFIG_DISPLAY_FSP_HEADER=y +CONFIG_DEBUG_CBFS=y +CONFIG_DEBUG_BOOT_STATE=y

Attachments:

attachment.htm (text/html — 3.1 KB)

Show replies by date

Julien Viard de Galbert (Code Review)

11 Nov 11 Nov

11:09 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47341

to look at the new patch set (#2).

Change subject: configs: Add a sample config for scaleway tagada ......................................................................

configs: Add a sample config for scaleway tagada

Signed-off-by: Julien Viard de Galbert julien@vdg.name Change-Id: I39fd9aabe7285d39e1883622ee9d6a60c6651b6e --- A configs/config.scaleway_tagada 1 file changed, 14 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/47341/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/47341 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39fd9aabe7285d39e1883622ee9d6a60c6651b6e Gerrit-Change-Number: 47341 Gerrit-PatchSet: 2 Gerrit-Owner: Julien Viard de Galbert coreboot-review-ju@vdg.name Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

12 Nov 12 Nov

12:14 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47341 )

Change subject: configs: Add a sample config for scaleway tagada ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47341/2/configs/config.scaleway_tag... File configs/config.scaleway_tagada:

https://review.coreboot.org/c/coreboot/+/47341/2/configs/config.scaleway_tag... PS2, Line 1: CONFIG_VENDOR_SCALEWAY=y I know this is probably what `make savedefconfig` produced, but I would expect that a config for Scaleway Tagada actually selects the mainboard. This avoids problems should a new Scaleway board ever gets added.

-- To view, visit https://review.coreboot.org/c/coreboot/+/47341 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39fd9aabe7285d39e1883622ee9d6a60c6651b6e Gerrit-Change-Number: 47341 Gerrit-PatchSet: 2 Gerrit-Owner: Julien Viard de Galbert coreboot-review-ju@vdg.name Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 11 Nov 2020 23:14:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Julien Viard de Galbert (Code Review)

9:53 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47341

to look at the new patch set (#3).

Change subject: configs: Add a sample config for scaleway tagada ......................................................................

configs: Add a sample config for scaleway tagada

Signed-off-by: Julien Viard de Galbert julien@vdg.name Change-Id: I39fd9aabe7285d39e1883622ee9d6a60c6651b6e --- A configs/config.scaleway_tagada 1 file changed, 15 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/47341/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/47341 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39fd9aabe7285d39e1883622ee9d6a60c6651b6e Gerrit-Change-Number: 47341 Gerrit-PatchSet: 3 Gerrit-Owner: Julien Viard de Galbert coreboot-review-ju@vdg.name Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Julien Viard de Galbert (Code Review)

9:56 p.m.

Julien Viard de Galbert has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47341 )

Change subject: configs: Add a sample config for scaleway tagada ......................................................................

Patch Set 3:

(1 comment)

Updated to select the board.

https://review.coreboot.org/c/coreboot/+/47341/2/configs/config.scaleway_tag... File configs/config.scaleway_tagada:

https://review.coreboot.org/c/coreboot/+/47341/2/configs/config.scaleway_tag... PS2, Line 1: CONFIG_VENDOR_SCALEWAY=y

...

I know this is probably what `make savedefconfig` produced, but I would expect that a config for Sca […]

Yes makes sense, updated.

-- To view, visit https://review.coreboot.org/c/coreboot/+/47341 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39fd9aabe7285d39e1883622ee9d6a60c6651b6e Gerrit-Change-Number: 47341 Gerrit-PatchSet: 3 Gerrit-Owner: Julien Viard de Galbert coreboot-review-ju@vdg.name Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 12 Nov 2020 20:56:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Angel Pons (Code Review)

13 Nov 13 Nov

12:41 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47341 )

Change subject: configs: Add a sample config for scaleway tagada ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/47341 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39fd9aabe7285d39e1883622ee9d6a60c6651b6e Gerrit-Change-Number: 47341 Gerrit-PatchSet: 3 Gerrit-Owner: Julien Viard de Galbert coreboot-review-ju@vdg.name Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 13 Nov 2020 11:41:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

20 Nov 20 Nov

1:45 a.m.

Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47341 )

Change subject: configs: Add a sample config for scaleway tagada ......................................................................

configs: Add a sample config for scaleway tagada

Signed-off-by: Julien Viard de Galbert julien@vdg.name Change-Id: I39fd9aabe7285d39e1883622ee9d6a60c6651b6e Reviewed-on: https://review.coreboot.org/c/coreboot/+/47341 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- A configs/config.scaleway_tagada 1 file changed, 15 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved

diff --git a/configs/config.scaleway_tagada b/configs/config.scaleway_tagada new file mode 100644 index 0000000..eaa4288 --- /dev/null +++ b/configs/config.scaleway_tagada @@ -0,0 +1,15 @@ +CONFIG_VENDOR_SCALEWAY=y +CONFIG_BOARD_SCALEWAY_TAGADA=y +CONFIG_CBFS_SIZE=0x400000 +CONFIG_CONSOLE_POST=y +# CONFIG_DRIVERS_INTEL_WIFI is not set +# CONFIG_IQAT_ENABLE is not set +CONFIG_LEGACY_UART_MODE=y +CONFIG_USE_DENVERTON_NS_FSP_CAR=y +CONFIG_SPI_FLASH_NO_FAST_READ=y +CONFIG_PAYLOAD_ELF=y +CONFIG_PAYLOAD_FILE="UEFIPAYLOAD.fd" +CONFIG_DISPLAY_FSP_CALLS_AND_STATUS=y +CONFIG_DISPLAY_FSP_HEADER=y +CONFIG_DEBUG_CBFS=y +CONFIG_DEBUG_BOOT_STATE=y

-- To view, visit https://review.coreboot.org/c/coreboot/+/47341 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39fd9aabe7285d39e1883622ee9d6a60c6651b6e Gerrit-Change-Number: 47341 Gerrit-PatchSet: 5 Gerrit-Owner: Julien Viard de Galbert coreboot-review-ju@vdg.name Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1513

days inactive

1526

days old

coreboot-gerrit@coreboot.org

6 comments

2 participants

tags (0)

participants (2)

Angel Pons (Code Review)
Julien Viard de Galbert (Code Review)