Change in coreboot[master]: src/soc/intel/common/itss: Add support to get interrupt table for PCI...

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34089 )

Change subject: src/soc/intel/common/itss: Add support to get interrupt table for PCI devices
......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34089/8/src/soc/intel/common/block/... 
File src/soc/intel/common/block/itss/irq.c:

https://review.coreboot.org/c/coreboot/+/34089/8/src/soc/intel/common/block/... 
PS8, Line 150: while (irq_config) {
             : 		memcpy(dev, &(irq_config->irq), sizeof(struct dev_irq));
             : 		tmp = irq_config;
             : 		irq_config = irq_config->next;
             : 		free(tmp);
             : 		dev++;
             : 		int_dev_entry++;
             : 	}
> Yes, so this is incorrect, working on passing the list to SOC callee, memcpy into a static array and […]

I think the basic question here would be why do you need the list at all? The caller knows how many devices it wants to set up the IRQ for. And it can pass in a static table of the appropriate size. It should be possible for this driver to directly add entries into that static array instead of maintaining a list and then doing a memcpy.