Attention is currently required from: Arthur Heymans, Christian Walter, Stefan Reinauer.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78651?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: payloads/LinuxBoot: Hide the path of the kernel and initrd when building
......................................................................
Patch Set 1: -Code-Review
(1 comment)
File payloads/external/LinuxBoot/Kconfig:
https://review.coreboot.org/c/coreboot/+/78651/comment/785220d8_fcf65cd4 :
PS1, Line 59: string "Path to kernel" if !LINUXBOOT_COMPILE_KERNEL
I know I previously gave this a +2, but I've reconsidered. Let's change this to two lines, both here and below:
```
config LINUXBOOT_KERNEL_PATH
string
prompt "Path to kernel" if !LINUXBOOT_COMPILE_KERNEL
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78651?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7958e419e314a7018f84bf9c5c332c90f4a319df
Gerrit-Change-Number: 78651
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 03 Nov 2023 15:42:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment