Wim Vervoorn has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35963 )
Change subject: mb/facebook/fbg1701: correct clang issues ......................................................................
mb/facebook/fbg1701: correct clang issues
Corrected clang issues in fbg1701 dicretory.
BUG=N/A TEST=build
Change-Id: I968bf8418aa457a7ebd28096bd92a64211bf86dd Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/mainboard/facebook/fbg1701/logo.c M src/mainboard/facebook/fbg1701/onboard.h M src/mainboard/facebook/fbg1701/ramstage.c M src/mainboard/facebook/fbg1701/romstage.c 4 files changed, 278 insertions(+), 281 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/35963/1
diff --git a/src/mainboard/facebook/fbg1701/logo.c b/src/mainboard/facebook/fbg1701/logo.c index 678d2e2..10c72c7 100644 --- a/src/mainboard/facebook/fbg1701/logo.c +++ b/src/mainboard/facebook/fbg1701/logo.c @@ -32,16 +32,15 @@ return (void *)logo_data; }
- logo_data_sz = cbfs_boot_load_file(filename, logo_data, - sizeof(logo_data), CBFS_TYPE_RAW); + logo_data_sz = + cbfs_boot_load_file(filename, logo_data, sizeof(logo_data), CBFS_TYPE_RAW); if (logo_data_sz == 0) return NULL;
if (logo_size) *logo_size = logo_data_sz;
- printk(BIOS_DEBUG, "Found a Logo of %zu bytes after decompression\n", - logo_data_sz); + printk(BIOS_DEBUG, "Found a Logo of %zu bytes after decompression\n", logo_data_sz);
return (void *)logo_data; } diff --git a/src/mainboard/facebook/fbg1701/onboard.h b/src/mainboard/facebook/fbg1701/onboard.h index 330fe0f..2c78d15 100644 --- a/src/mainboard/facebook/fbg1701/onboard.h +++ b/src/mainboard/facebook/fbg1701/onboard.h @@ -19,10 +19,8 @@ #define ONBOARD_H
/* SD CARD gpio */ -#define SDCARD_CD 81 /* Not used */ +#define SDCARD_CD 81 /* Not used */
-#define ITE8528_CMD_PORT 0x6E -#define ITE8528_DATA_PORT 0x6F
/* CPLD definitions */ #define CPLD_PCB_VERSION_PORT 0x283 @@ -32,15 +30,17 @@ #define CPLD_RESET_PORT 0x287 #define CPLD_CMD_RESET_DSI_BRIDGE_ACTIVE 0x20 #define CPLD_CMD_RESET_DSI_BRIDGE_INACTIVE 0x00 +#define ITE8528_CMD_PORT 0x6E +#define ITE8528_DATA_PORT 0x6F
/* Define the items to be measured or verified */ -#define FSP (const char *)"fsp.bin" -#define CMOS_LAYOUT (const char *)"cmos_layout.bin" -#define RAMSTAGE (const char *)"fallback/ramstage" -#define ROMSTAGE (const char *)"fallback/romstage" -#define PAYLOAD (const char *)"fallback/payload" -#define POSTCAR (const char *)"fallback/postcar" -#define OP_ROM_VBT (const char *)"vbt.bin" -#define MICROCODE (const char *)"cpu_microcode_blob.bin" +#define FSP (const char *)"fsp.bin" +#define CMOS_LAYOUT (const char *)"cmos_layout.bin" +#define RAMSTAGE (const char *)"fallback/ramstage" +#define ROMSTAGE (const char *)"fallback/romstage" +#define PAYLOAD (const char *)"fallback/payload" +#define POSTCAR (const char *)"fallback/postcar" +#define OP_ROM_VBT (const char *)"vbt.bin" +#define MICROCODE (const char *)"cpu_microcode_blob.bin"
#endif diff --git a/src/mainboard/facebook/fbg1701/ramstage.c b/src/mainboard/facebook/fbg1701/ramstage.c index c5fb798..7171c48 100644 --- a/src/mainboard/facebook/fbg1701/ramstage.c +++ b/src/mainboard/facebook/fbg1701/ramstage.c @@ -31,295 +31,295 @@ static const struct edp_data b101uan01_table[] = { /* set eDP bridge to 1200x1920 */ /* IO */ - { 6, 0x68, { 0x08, 0x00, 0x01, 0x00, 0x00, 0x00 } }, + {6, 0x68, {0x08, 0x00, 0x01, 0x00, 0x00, 0x00}}, /* Boot */ - { 6, 0x68, { 0x10, 0x00, 0x78, 0x69, 0x00, 0x00 } }, - { 6, 0x68, { 0x10, 0x04, 0x02, 0x08, 0x02, 0x00 } }, - { 6, 0x68, { 0x10, 0x08, 0x23, 0x00, 0x87, 0x02 } }, - { 6, 0x68, { 0x10, 0x0C, 0x19, 0x04, 0x00, 0x23 } }, - { 6, 0x68, { 0x10, 0x10, 0x06, 0x00, 0x67, 0x00 } }, - { 6, 0x68, { 0x10, 0x14, 0x01, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x10, 0x18, 0xFF, 0xFF, 0xFF, 0xFF } }, + {6, 0x68, {0x10, 0x00, 0x78, 0x69, 0x00, 0x00}}, + {6, 0x68, {0x10, 0x04, 0x02, 0x08, 0x02, 0x00}}, + {6, 0x68, {0x10, 0x08, 0x23, 0x00, 0x87, 0x02}}, + {6, 0x68, {0x10, 0x0C, 0x19, 0x04, 0x00, 0x23}}, + {6, 0x68, {0x10, 0x10, 0x06, 0x00, 0x67, 0x00}}, + {6, 0x68, {0x10, 0x14, 0x01, 0x00, 0x00, 0x00}}, + {6, 0x68, {0x10, 0x18, 0xFF, 0xFF, 0xFF, 0xFF}}, /* Internal */ - { 3, 0x68, { 0xB0, 0x05, 0x0A, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB0, 0x06, 0x03, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB0, 0x07, 0x16, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB0, 0x08, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB0, 0x09, 0x21, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB0, 0x0A, 0x07, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x10, 0x14, 0x03, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x10, 0x18, 0xFF, 0xFF, 0xFF, 0xFF } }, + {3, 0x68, {0xB0, 0x05, 0x0A, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB0, 0x06, 0x03, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB0, 0x07, 0x16, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB0, 0x08, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB0, 0x09, 0x21, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB0, 0x0A, 0x07, 0x00, 0x00, 0x00}}, + {6, 0x68, {0x10, 0x14, 0x03, 0x00, 0x00, 0x00}}, + {6, 0x68, {0x10, 0x18, 0xFF, 0xFF, 0xFF, 0xFF}}, /* eDP */ - { 3, 0x68, { 0x80, 0x03, 0x41, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB4, 0x00, 0x0D, 0x00, 0x00, 0x00 } }, + {3, 0x68, {0x80, 0x03, 0x41, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB4, 0x00, 0x0D, 0x00, 0x00, 0x00}}, /* DPRX */ - { 3, 0x68, { 0xB8, 0x8E, 0xFF, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x8F, 0xFF, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x9A, 0xFF, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x9B, 0xFF, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x00, 0x0E, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x26, 0x02, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x01, 0x20, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0xC0, 0xF1, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0xC1, 0xF1, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0xC2, 0xF0, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0xC3, 0xF0, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0xC4, 0xF0, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0xC5, 0xF0, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0xC6, 0xF0, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0xC7, 0xF0, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x0B, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x33, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x5B, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x10, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x38, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x60, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x15, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x3D, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x65, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x1A, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x42, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x6A, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x1F, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x47, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x6F, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x24, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x4C, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x74, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x29, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x51, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x79, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x2E, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x56, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x7E, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x90, 0x10, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x91, 0x0F, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x92, 0xF6, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x93, 0x10, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x94, 0x0F, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x95, 0xF6, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x96, 0x10, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x97, 0x0F, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x98, 0xF6, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x99, 0x10, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x9A, 0x0F, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x9B, 0xF6, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x8A, 0x03, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x96, 0x03, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0xD1, 0x07, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0xB0, 0x07, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x8B, 0x04, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x8C, 0x45, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x8D, 0x05, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x97, 0x04, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x98, 0xE0, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x99, 0x2E, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0x80, 0x0E, 0x00, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x10, 0x14, 0x07, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x10, 0x18, 0xFF, 0xFF, 0xFF, 0xFF } }, + {3, 0x68, {0xB8, 0x8E, 0xFF, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x8F, 0xFF, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x9A, 0xFF, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x9B, 0xFF, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x00, 0x0E, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xBB, 0x26, 0x02, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xBB, 0x01, 0x20, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0xC0, 0xF1, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0xC1, 0xF1, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0xC2, 0xF0, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0xC3, 0xF0, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0xC4, 0xF0, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0xC5, 0xF0, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0xC6, 0xF0, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0xC7, 0xF0, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x0B, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x33, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x5B, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x10, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x38, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x60, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x15, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x3D, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x65, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x1A, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x42, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x6A, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x1F, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x47, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x6F, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x24, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x4C, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x74, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x29, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x51, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x79, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x2E, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x56, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x7E, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xBB, 0x90, 0x10, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xBB, 0x91, 0x0F, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xBB, 0x92, 0xF6, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xBB, 0x93, 0x10, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xBB, 0x94, 0x0F, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xBB, 0x95, 0xF6, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xBB, 0x96, 0x10, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xBB, 0x97, 0x0F, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xBB, 0x98, 0xF6, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xBB, 0x99, 0x10, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xBB, 0x9A, 0x0F, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xBB, 0x9B, 0xF6, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x8A, 0x03, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x96, 0x03, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xBB, 0xD1, 0x07, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xBB, 0xB0, 0x07, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x8B, 0x04, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x8C, 0x45, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x8D, 0x05, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x97, 0x04, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x98, 0xE0, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x99, 0x2E, 0x00, 0x00, 0x00}}, + {3, 0x68, {0x80, 0x0E, 0x00, 0x00, 0x00, 0x00}}, + {6, 0x68, {0x10, 0x14, 0x07, 0x00, 0x00, 0x00}}, + {6, 0x68, {0x10, 0x18, 0xFF, 0xFF, 0xFF, 0xFF}}, /* Video size */ - { 6, 0x68, { 0x01, 0x48, 0xB0, 0x04, 0x00, 0x00 } }, - { 6, 0x68, { 0x29, 0x20, 0x10, 0x0E, 0x0B, 0x3E } }, + {6, 0x68, {0x01, 0x48, 0xB0, 0x04, 0x00, 0x00}}, + {6, 0x68, {0x29, 0x20, 0x10, 0x0E, 0x0B, 0x3E}}, /* eDP */ - { 3, 0x68, { 0xB6, 0x31, 0xFF, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0x80, 0x01, 0x14, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0x80, 0x02, 0x02, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB6, 0x08, 0x0B, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x00, 0x1E, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0x87, 0x00, 0x00, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x50, 0x10, 0x00, 0x00, 0x9D, 0x00 } }, - { 6, 0x68, { 0x00, 0x8C, 0x40, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x00, 0x80, 0x02, 0x00, 0x00, 0x00 } }, + {3, 0x68, {0xB6, 0x31, 0xFF, 0x00, 0x00, 0x00}}, + {3, 0x68, {0x80, 0x01, 0x14, 0x00, 0x00, 0x00}}, + {3, 0x68, {0x80, 0x02, 0x02, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB6, 0x08, 0x0B, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x00, 0x1E, 0x00, 0x00, 0x00}}, + {3, 0x68, {0x87, 0x00, 0x00, 0x00, 0x00, 0x00}}, + {6, 0x68, {0x50, 0x10, 0x00, 0x00, 0x9D, 0x00}}, + {6, 0x68, {0x00, 0x8C, 0x40, 0x00, 0x00, 0x00}}, + {6, 0x68, {0x00, 0x80, 0x02, 0x00, 0x00, 0x00}}, /* Link Training */ - { 3, 0x68, { 0x82, 0x02, 0xFF, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0x82, 0x03, 0xFF, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0x82, 0x04, 0xFF, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x21, 0x58, 0x09, 0x00, 0x28, 0x00 } }, - { 6, 0x68, { 0x21, 0x60, 0x07, 0x00, 0x0F, 0x00 } }, - { 6, 0x68, { 0x21, 0x64, 0x28, 0x23, 0x00, 0x00 } }, - { 6, 0x68, { 0x21, 0x68, 0x0E, 0x00, 0x00, 0x00 } }, + {3, 0x68, {0x82, 0x02, 0xFF, 0x00, 0x00, 0x00}}, + {3, 0x68, {0x82, 0x03, 0xFF, 0x00, 0x00, 0x00}}, + {3, 0x68, {0x82, 0x04, 0xFF, 0x00, 0x00, 0x00}}, + {6, 0x68, {0x21, 0x58, 0x09, 0x00, 0x28, 0x00}}, + {6, 0x68, {0x21, 0x60, 0x07, 0x00, 0x0F, 0x00}}, + {6, 0x68, {0x21, 0x64, 0x28, 0x23, 0x00, 0x00}}, + {6, 0x68, {0x21, 0x68, 0x0E, 0x00, 0x00, 0x00}}, /* DSI */ - { 6, 0x68, { 0x20, 0x7C, 0x81, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x20, 0x50, 0x00, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x20, 0x1C, 0x01, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x20, 0x60, 0xFF, 0xFF, 0xFF, 0xFF } }, + {6, 0x68, {0x20, 0x7C, 0x81, 0x00, 0x00, 0x00}}, + {6, 0x68, {0x20, 0x50, 0x00, 0x00, 0x00, 0x00}}, + {6, 0x68, {0x20, 0x1C, 0x01, 0x00, 0x00, 0x00}}, + {6, 0x68, {0x20, 0x60, 0xFF, 0xFF, 0xFF, 0xFF}}, /* GPIO */ - { 6, 0x68, { 0x08, 0x04, 0x00, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x00, 0x80, 0x0F, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x00, 0x84, 0x0F, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x00, 0x84, 0x00, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x00, 0x84, 0x0F, 0x00, 0x00, 0x00 } }, + {6, 0x68, {0x08, 0x04, 0x00, 0x00, 0x00, 0x00}}, + {6, 0x68, {0x00, 0x80, 0x0F, 0x00, 0x00, 0x00}}, + {6, 0x68, {0x00, 0x84, 0x0F, 0x00, 0x00, 0x00}}, + {6, 0x68, {0x00, 0x84, 0x00, 0x00, 0x00, 0x00}}, + {6, 0x68, {0x00, 0x84, 0x0F, 0x00, 0x00, 0x00}}, /* DSI clock */ - { 6, 0x68, { 0x20, 0x50, 0x20, 0x00, 0x00, 0x00 } }, + {6, 0x68, {0x20, 0x50, 0x20, 0x00, 0x00, 0x00}}, /* LCD init */ - { 6, 0x68, { 0x22, 0xFC, 0x15, 0x01, 0x00, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x15, 0x8C, 0x80, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x15, 0xC7, 0x50, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x15, 0xC5, 0x50, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x15, 0x85, 0x04, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x15, 0x86, 0x08, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x15, 0x83, 0xAA, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x15, 0x84, 0x11, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x15, 0x9C, 0x10, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x15, 0xA9, 0x4B, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x05, 0x11, 0x00, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x05, 0x29, 0x00, 0x81 } }, - { 6, 0x68, { 0x2A, 0x10, 0x10, 0x00, 0x04, 0x80 } }, - { 6, 0x68, { 0x2A, 0x04, 0x01, 0x00, 0x00, 0x00 } }, + {6, 0x68, {0x22, 0xFC, 0x15, 0x01, 0x00, 0x81}}, + {6, 0x68, {0x22, 0xFC, 0x15, 0x8C, 0x80, 0x81}}, + {6, 0x68, {0x22, 0xFC, 0x15, 0xC7, 0x50, 0x81}}, + {6, 0x68, {0x22, 0xFC, 0x15, 0xC5, 0x50, 0x81}}, + {6, 0x68, {0x22, 0xFC, 0x15, 0x85, 0x04, 0x81}}, + {6, 0x68, {0x22, 0xFC, 0x15, 0x86, 0x08, 0x81}}, + {6, 0x68, {0x22, 0xFC, 0x15, 0x83, 0xAA, 0x81}}, + {6, 0x68, {0x22, 0xFC, 0x15, 0x84, 0x11, 0x81}}, + {6, 0x68, {0x22, 0xFC, 0x15, 0x9C, 0x10, 0x81}}, + {6, 0x68, {0x22, 0xFC, 0x15, 0xA9, 0x4B, 0x81}}, + {6, 0x68, {0x22, 0xFC, 0x05, 0x11, 0x00, 0x81}}, + {6, 0x68, {0x22, 0xFC, 0x05, 0x29, 0x00, 0x81}}, + {6, 0x68, {0x2A, 0x10, 0x10, 0x00, 0x04, 0x80}}, + {6, 0x68, {0x2A, 0x04, 0x01, 0x00, 0x00, 0x00}}, /* Check Video */ - { 6, 0x68, { 0x01, 0x54, 0x01, 0x00, 0x00, 0x00 } }, + {6, 0x68, {0x01, 0x54, 0x01, 0x00, 0x00, 0x00}}, /* End of table */ - { 0, 0x00, { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 } }, + {0, 0x00, {0x00, 0x00, 0x00, 0x00, 0x00, 0x00}}, };
static const struct edp_data b101uan08_table[] = { /* set eDP bridge to 1200x1920 */ /* IO Voltage Setting */ - { 6, 0x68, { 0x08, 0x00, 0x01, 0x00, 0x00, 0x00 } }, + {6, 0x68, {0x08, 0x00, 0x01, 0x00, 0x00, 0x00}}, /* Boot Settings */ - { 6, 0x68, { 0x10, 0x00, 0x78, 0x69, 0x00, 0x00 } }, - { 6, 0x68, { 0x10, 0x04, 0x02, 0x08, 0x02, 0x00 } }, - { 6, 0x68, { 0x10, 0x08, 0x22, 0x00, 0xA0, 0x02 } }, - { 6, 0x68, { 0x10, 0x0C, 0x50, 0x04, 0x00, 0x03 } }, - { 6, 0x68, { 0x10, 0x10, 0x10, 0x0D, 0x06, 0x01 } }, - { 6, 0x68, { 0x10, 0x14, 0x01, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x10, 0x18, 0xFF, 0xFF, 0xFF, 0xFF } }, + {6, 0x68, {0x10, 0x00, 0x78, 0x69, 0x00, 0x00}}, + {6, 0x68, {0x10, 0x04, 0x02, 0x08, 0x02, 0x00}}, + {6, 0x68, {0x10, 0x08, 0x22, 0x00, 0xA0, 0x02}}, + {6, 0x68, {0x10, 0x0C, 0x50, 0x04, 0x00, 0x03}}, + {6, 0x68, {0x10, 0x10, 0x10, 0x0D, 0x06, 0x01}}, + {6, 0x68, {0x10, 0x14, 0x01, 0x00, 0x00, 0x00}}, + {6, 0x68, {0x10, 0x18, 0xFF, 0xFF, 0xFF, 0xFF}}, /* Internal PCLK settings for Non Present or REFCLK=26MHz */ - { 3, 0x68, { 0xB0, 0x05, 0x0A, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB0, 0x06, 0x03, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB0, 0x07, 0x16, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB0, 0x08, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB0, 0x09, 0x21, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB0, 0x0A, 0x07, 0x00, 0x00, 0x00 } }, + {3, 0x68, {0xB0, 0x05, 0x0A, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB0, 0x06, 0x03, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB0, 0x07, 0x16, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB0, 0x08, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB0, 0x09, 0x21, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB0, 0x0A, 0x07, 0x00, 0x00, 0x00}}, /* DSI Clock setting for Non Preset or REFCLK=26MHz */ - { 6, 0x68, { 0x41, 0xB0, 0xC1, 0x22, 0x04, 0x00 } }, - { 6, 0x68, { 0x41, 0xBC, 0x01, 0x0E, 0x00, 0x00 } }, - { 6, 0x68, { 0x41, 0xC0, 0x30, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x10, 0x14, 0x03, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x10, 0x18, 0xFF, 0xFF, 0xFF, 0xFF } }, + {6, 0x68, {0x41, 0xB0, 0xC1, 0x22, 0x04, 0x00}}, + {6, 0x68, {0x41, 0xBC, 0x01, 0x0E, 0x00, 0x00}}, + {6, 0x68, {0x41, 0xC0, 0x30, 0x00, 0x00, 0x00}}, + {6, 0x68, {0x10, 0x14, 0x03, 0x00, 0x00, 0x00}}, + {6, 0x68, {0x10, 0x18, 0xFF, 0xFF, 0xFF, 0xFF}}, /* Additional Settng for eDP */ - { 3, 0x68, { 0x80, 0x03, 0x41, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB4, 0x00, 0x0D, 0x00, 0x00, 0x00 } }, + {3, 0x68, {0x80, 0x03, 0x41, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB4, 0x00, 0x0D, 0x00, 0x00, 0x00}}, /* DPRX CAD Register Setting */ - { 3, 0x68, { 0xB8, 0x8E, 0xFF, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x8F, 0xFF, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x9A, 0xFF, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x9B, 0xFF, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x00, 0x0E, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x26, 0x02, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x01, 0x20, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0xC0, 0xF1, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0xC1, 0xF1, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0xC2, 0xF0, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0xC3, 0xF0, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0xC4, 0xF0, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0xC5, 0xF0, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0xC6, 0xF0, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0xC7, 0xF0, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x0B, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x33, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x5B, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x10, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x38, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x60, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x15, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x3D, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x65, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x1A, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x42, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x6A, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x1F, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x47, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x6F, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x24, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x4C, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x74, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x29, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x51, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x79, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x2E, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x56, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x7E, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x90, 0x10, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x91, 0x0F, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x92, 0xF6, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x93, 0x10, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x94, 0x0F, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x95, 0xF6, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x96, 0x10, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x97, 0x0F, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x98, 0xF6, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x99, 0x10, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x9A, 0x0F, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x9B, 0xF6, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x8A, 0x03, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x96, 0x03, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0xD1, 0x07, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0xB0, 0x07, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x8B, 0x04, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x8C, 0x45, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x8D, 0x05, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x97, 0x04, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x98, 0xE0, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x99, 0x2E, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0x80, 0x0E, 0x00, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x10, 0x14, 0x07, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x10, 0x18, 0xFF, 0xFF, 0xFF, 0xFF } }, + {3, 0x68, {0xB8, 0x8E, 0xFF, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x8F, 0xFF, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x9A, 0xFF, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x9B, 0xFF, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x00, 0x0E, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xBB, 0x26, 0x02, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xBB, 0x01, 0x20, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0xC0, 0xF1, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0xC1, 0xF1, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0xC2, 0xF0, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0xC3, 0xF0, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0xC4, 0xF0, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0xC5, 0xF0, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0xC6, 0xF0, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0xC7, 0xF0, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x0B, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x33, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x5B, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x10, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x38, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x60, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x15, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x3D, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x65, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x1A, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x42, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x6A, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x1F, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x47, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x6F, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x24, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x4C, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x74, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x29, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x51, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x79, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x2E, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x56, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x7E, 0x00, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xBB, 0x90, 0x10, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xBB, 0x91, 0x0F, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xBB, 0x92, 0xF6, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xBB, 0x93, 0x10, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xBB, 0x94, 0x0F, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xBB, 0x95, 0xF6, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xBB, 0x96, 0x10, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xBB, 0x97, 0x0F, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xBB, 0x98, 0xF6, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xBB, 0x99, 0x10, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xBB, 0x9A, 0x0F, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xBB, 0x9B, 0xF6, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x8A, 0x03, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x96, 0x03, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xBB, 0xD1, 0x07, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xBB, 0xB0, 0x07, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x8B, 0x04, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x8C, 0x45, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x8D, 0x05, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x97, 0x04, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x98, 0xE0, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x99, 0x2E, 0x00, 0x00, 0x00}}, + {3, 0x68, {0x80, 0x0E, 0x00, 0x00, 0x00, 0x00}}, + {6, 0x68, {0x10, 0x14, 0x07, 0x00, 0x00, 0x00}}, + {6, 0x68, {0x10, 0x18, 0xFF, 0xFF, 0xFF, 0xFF}}, /* Video size Related Settings for Non Present */ - { 6, 0x68, { 0x01, 0x48, 0xB0, 0x04, 0x00, 0x00 } }, - { 6, 0x68, { 0x29, 0x20, 0x10, 0x0E, 0x0B, 0x3E } }, + {6, 0x68, {0x01, 0x48, 0xB0, 0x04, 0x00, 0x00}}, + {6, 0x68, {0x29, 0x20, 0x10, 0x0E, 0x0B, 0x3E}}, /* eDP Settings for Link Training*/ - { 3, 0x68, { 0xB6, 0x31, 0xFF, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0x80, 0x01, 0x14, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0x80, 0x02, 0x02, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB6, 0x08, 0x0B, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x00, 0x1E, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0x87, 0x00, 0x00, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x50, 0x10, 0x00, 0x00, 0x9D, 0x00 } }, - { 6, 0x68, { 0x00, 0x8C, 0x40, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x00, 0x80, 0x02, 0x00, 0x00, 0x00 } }, + {3, 0x68, {0xB6, 0x31, 0xFF, 0x00, 0x00, 0x00}}, + {3, 0x68, {0x80, 0x01, 0x14, 0x00, 0x00, 0x00}}, + {3, 0x68, {0x80, 0x02, 0x02, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB6, 0x08, 0x0B, 0x00, 0x00, 0x00}}, + {3, 0x68, {0xB8, 0x00, 0x1E, 0x00, 0x00, 0x00}}, + {3, 0x68, {0x87, 0x00, 0x00, 0x00, 0x00, 0x00}}, + {6, 0x68, {0x50, 0x10, 0x00, 0x00, 0x9D, 0x00}}, + {6, 0x68, {0x00, 0x8C, 0x40, 0x00, 0x00, 0x00}}, + {6, 0x68, {0x00, 0x80, 0x02, 0x00, 0x00, 0x00}}, /* Link Training */ - { 3, 0x68, { 0x82, 0x02, 0xFF, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0x82, 0x03, 0xFF, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0x82, 0x04, 0xFF, 0x00, 0x00, 0x00 } }, + {3, 0x68, {0x82, 0x02, 0xFF, 0x00, 0x00, 0x00}}, + {3, 0x68, {0x82, 0x03, 0xFF, 0x00, 0x00, 0x00}}, + {3, 0x68, {0x82, 0x04, 0xFF, 0x00, 0x00, 0x00}}, /* DSI Transition Time Setting for Non Preset */ - { 6, 0x68, { 0x21, 0x54, 0x0D, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x21, 0x58, 0x06, 0x00, 0x2A, 0x00 } }, - { 6, 0x68, { 0x21, 0x5C, 0x07, 0x00, 0x0E, 0x00 } }, - { 6, 0x68, { 0x21, 0x60, 0x07, 0x00, 0x10, 0x00 } }, - { 6, 0x68, { 0x21, 0x64, 0x10, 0x27, 0x00, 0x00 } }, - { 6, 0x68, { 0x21, 0x68, 0x0E, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x21, 0x6C, 0x0A, 0x00, 0x0E, 0x00 } }, - { 6, 0x68, { 0x21, 0x78, 0x0E, 0x00, 0x0D, 0x00 } }, + {6, 0x68, {0x21, 0x54, 0x0D, 0x00, 0x00, 0x00}}, + {6, 0x68, {0x21, 0x58, 0x06, 0x00, 0x2A, 0x00}}, + {6, 0x68, {0x21, 0x5C, 0x07, 0x00, 0x0E, 0x00}}, + {6, 0x68, {0x21, 0x60, 0x07, 0x00, 0x10, 0x00}}, + {6, 0x68, {0x21, 0x64, 0x10, 0x27, 0x00, 0x00}}, + {6, 0x68, {0x21, 0x68, 0x0E, 0x00, 0x00, 0x00}}, + {6, 0x68, {0x21, 0x6C, 0x0A, 0x00, 0x0E, 0x00}}, + {6, 0x68, {0x21, 0x78, 0x0E, 0x00, 0x0D, 0x00}}, /* DSI Start */ - { 6, 0x68, { 0x20, 0x7C, 0x81, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x20, 0x50, 0x00, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x20, 0x1C, 0x01, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x20, 0x60, 0xFF, 0xFF, 0xFF, 0xFF } }, + {6, 0x68, {0x20, 0x7C, 0x81, 0x00, 0x00, 0x00}}, + {6, 0x68, {0x20, 0x50, 0x00, 0x00, 0x00, 0x00}}, + {6, 0x68, {0x20, 0x1C, 0x01, 0x00, 0x00, 0x00}}, + {6, 0x68, {0x20, 0x60, 0xFF, 0xFF, 0xFF, 0xFF}}, /* GPIO for LCD control*/ - { 6, 0x68, { 0x08, 0x04, 0x00, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x00, 0x80, 0x0F, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x00, 0x84, 0x0F, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x00, 0x84, 0x00, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x00, 0x84, 0x0F, 0x00, 0x00, 0x00 } }, + {6, 0x68, {0x08, 0x04, 0x00, 0x00, 0x00, 0x00}}, + {6, 0x68, {0x00, 0x80, 0x0F, 0x00, 0x00, 0x00}}, + {6, 0x68, {0x00, 0x84, 0x0F, 0x00, 0x00, 0x00}}, + {6, 0x68, {0x00, 0x84, 0x00, 0x00, 0x00, 0x00}}, + {6, 0x68, {0x00, 0x84, 0x0F, 0x00, 0x00, 0x00}}, /* DSI Hs Clock Mode */ - { 6, 0x68, { 0x20, 0x50, 0x20, 0x00, 0x00, 0x00 } }, + {6, 0x68, {0x20, 0x50, 0x20, 0x00, 0x00, 0x00}}, /* LCD Initialization */ - { 6, 0x68, { 0x22, 0xFC, 0x15, 0xBF, 0xA5, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x15, 0x01, 0x00, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x15, 0x8F, 0xA5, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x15, 0x83, 0xAA, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x15, 0x84, 0x11, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x15, 0xA9, 0x48, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x15, 0x83, 0x00, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x15, 0x84, 0x00, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x15, 0x8F, 0x00, 0x81 } }, - { 6, 0x68, { 0x2A, 0x10, 0x10, 0x00, 0x04, 0x80 } }, - { 6, 0x68, { 0x2A, 0x04, 0x01, 0x00, 0x00, 0x00 } }, + {6, 0x68, {0x22, 0xFC, 0x15, 0xBF, 0xA5, 0x81}}, + {6, 0x68, {0x22, 0xFC, 0x15, 0x01, 0x00, 0x81}}, + {6, 0x68, {0x22, 0xFC, 0x15, 0x8F, 0xA5, 0x81}}, + {6, 0x68, {0x22, 0xFC, 0x15, 0x83, 0xAA, 0x81}}, + {6, 0x68, {0x22, 0xFC, 0x15, 0x84, 0x11, 0x81}}, + {6, 0x68, {0x22, 0xFC, 0x15, 0xA9, 0x48, 0x81}}, + {6, 0x68, {0x22, 0xFC, 0x15, 0x83, 0x00, 0x81}}, + {6, 0x68, {0x22, 0xFC, 0x15, 0x84, 0x00, 0x81}}, + {6, 0x68, {0x22, 0xFC, 0x15, 0x8F, 0x00, 0x81}}, + {6, 0x68, {0x2A, 0x10, 0x10, 0x00, 0x04, 0x80}}, + {6, 0x68, {0x2A, 0x04, 0x01, 0x00, 0x00, 0x00}}, /* Check if eDP video is coming */ - { 6, 0x68, { 0x01, 0x54, 0x01, 0x00, 0x00, 0x00 } }, + {6, 0x68, {0x01, 0x54, 0x01, 0x00, 0x00, 0x00}}, /* End of table */ - { 0, 0x00, { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 } }, + {0, 0x00, {0x00, 0x00, 0x00, 0x00, 0x00, 0x00}}, };
static void mainboard_configure_edp_bridge(void) @@ -341,8 +341,8 @@ loops = 5; do { status = smbus_i2c_block_write(edptable->address, - edptable->payload_length, - (u8 *)&edptable->data[0]); + edptable->payload_length, + (u8 *)&edptable->data[0]); } while (--loops && (status < 0));
if (loops == 0) { diff --git a/src/mainboard/facebook/fbg1701/romstage.c b/src/mainboard/facebook/fbg1701/romstage.c index 879cc9a..2b3a0e7 100644 --- a/src/mainboard/facebook/fbg1701/romstage.c +++ b/src/mainboard/facebook/fbg1701/romstage.c @@ -30,7 +30,7 @@ #include <stdint.h>
void mainboard_memory_init_params(struct romstage_params *params, - MEMORY_INIT_UPD *memory_params) + MEMORY_INIT_UPD *memory_params) { struct region_device spd_rdev; u8 spd_index = 0; @@ -68,8 +68,8 @@ */
static const uint8_t crtm_version[] = - CONFIG_VENDORCODE_ELTAN_CRTM_VERSION_STRING - COREBOOT_VERSION COREBOOT_EXTRA_VERSION " " COREBOOT_BUILD; + CONFIG_VENDORCODE_ELTAN_CRTM_VERSION_STRING COREBOOT_VERSION COREBOOT_EXTRA_VERSION + " " COREBOOT_BUILD;
int mb_crtm(EFI_TCG2_EVENT_ALGORITHM_BITMAP activePcr) { @@ -79,18 +79,16 @@ /* Use FirmwareVersion string to represent CRTM version. */ printk(BIOS_DEBUG, "%s: Measure CRTM Version\n", __func__); memset(&tcgEventHdr, 0, sizeof(tcgEventHdr)); - tcgEventHdr.pcrIndex = MBOOT_PCR_INDEX_0; + tcgEventHdr.pcrIndex = MBOOT_PCR_INDEX_0; tcgEventHdr.eventType = EV_S_CRTM_VERSION; tcgEventHdr.eventSize = sizeof(crtm_version); - printk(BIOS_DEBUG, "%s: EventSize - %u\n", __func__, - tcgEventHdr.eventSize); + printk(BIOS_DEBUG, "%s: EventSize - %u\n", __func__, tcgEventHdr.eventSize);
status = mboot_hash_extend_log(activePcr, 0, (uint8_t *)crtm_version, tcgEventHdr.eventSize, &tcgEventHdr, (uint8_t *)crtm_version, 0); if (status) { - printk(BIOS_DEBUG, "Measure CRTM Version returned 0x%x\n", - status); + printk(BIOS_DEBUG, "Measure CRTM Version returned 0x%x\n", status); }
return status;
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35963 )
Change subject: mb/facebook/fbg1701: correct clang issues ......................................................................
Patch Set 1:
(256 comments)
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... File src/mainboard/facebook/fbg1701/ramstage.c:
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 34: {6, 0x68, {0x08, 0x00, 0x01, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 36: {6, 0x68, {0x10, 0x00, 0x78, 0x69, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 37: {6, 0x68, {0x10, 0x04, 0x02, 0x08, 0x02, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 38: {6, 0x68, {0x10, 0x08, 0x23, 0x00, 0x87, 0x02}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 39: {6, 0x68, {0x10, 0x0C, 0x19, 0x04, 0x00, 0x23}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 40: {6, 0x68, {0x10, 0x10, 0x06, 0x00, 0x67, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 41: {6, 0x68, {0x10, 0x14, 0x01, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 42: {6, 0x68, {0x10, 0x18, 0xFF, 0xFF, 0xFF, 0xFF}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 44: {3, 0x68, {0xB0, 0x05, 0x0A, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 45: {3, 0x68, {0xB0, 0x06, 0x03, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 46: {3, 0x68, {0xB0, 0x07, 0x16, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 47: {3, 0x68, {0xB0, 0x08, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 48: {3, 0x68, {0xB0, 0x09, 0x21, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 49: {3, 0x68, {0xB0, 0x0A, 0x07, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 50: {6, 0x68, {0x10, 0x14, 0x03, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 51: {6, 0x68, {0x10, 0x18, 0xFF, 0xFF, 0xFF, 0xFF}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 53: {3, 0x68, {0x80, 0x03, 0x41, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 54: {3, 0x68, {0xB4, 0x00, 0x0D, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 56: {3, 0x68, {0xB8, 0x8E, 0xFF, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 57: {3, 0x68, {0xB8, 0x8F, 0xFF, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 58: {3, 0x68, {0xB8, 0x9A, 0xFF, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 59: {3, 0x68, {0xB8, 0x9B, 0xFF, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 60: {3, 0x68, {0xB8, 0x00, 0x0E, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 61: {3, 0x68, {0xBB, 0x26, 0x02, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 62: {3, 0x68, {0xBB, 0x01, 0x20, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 63: {3, 0x68, {0xB8, 0xC0, 0xF1, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 64: {3, 0x68, {0xB8, 0xC1, 0xF1, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 65: {3, 0x68, {0xB8, 0xC2, 0xF0, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 66: {3, 0x68, {0xB8, 0xC3, 0xF0, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 67: {3, 0x68, {0xB8, 0xC4, 0xF0, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 68: {3, 0x68, {0xB8, 0xC5, 0xF0, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 69: {3, 0x68, {0xB8, 0xC6, 0xF0, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 70: {3, 0x68, {0xB8, 0xC7, 0xF0, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 71: {3, 0x68, {0xB8, 0x0B, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 72: {3, 0x68, {0xB8, 0x33, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 73: {3, 0x68, {0xB8, 0x5B, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 74: {3, 0x68, {0xB8, 0x10, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 75: {3, 0x68, {0xB8, 0x38, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 76: {3, 0x68, {0xB8, 0x60, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 77: {3, 0x68, {0xB8, 0x15, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 78: {3, 0x68, {0xB8, 0x3D, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 79: {3, 0x68, {0xB8, 0x65, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 80: {3, 0x68, {0xB8, 0x1A, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 81: {3, 0x68, {0xB8, 0x42, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 82: {3, 0x68, {0xB8, 0x6A, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 83: {3, 0x68, {0xB8, 0x1F, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 84: {3, 0x68, {0xB8, 0x47, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 85: {3, 0x68, {0xB8, 0x6F, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 86: {3, 0x68, {0xB8, 0x24, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 87: {3, 0x68, {0xB8, 0x4C, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 88: {3, 0x68, {0xB8, 0x74, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 89: {3, 0x68, {0xB8, 0x29, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 90: {3, 0x68, {0xB8, 0x51, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 91: {3, 0x68, {0xB8, 0x79, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 92: {3, 0x68, {0xB8, 0x2E, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 93: {3, 0x68, {0xB8, 0x56, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 94: {3, 0x68, {0xB8, 0x7E, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 95: {3, 0x68, {0xBB, 0x90, 0x10, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 96: {3, 0x68, {0xBB, 0x91, 0x0F, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 97: {3, 0x68, {0xBB, 0x92, 0xF6, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 98: {3, 0x68, {0xBB, 0x93, 0x10, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 99: {3, 0x68, {0xBB, 0x94, 0x0F, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 100: {3, 0x68, {0xBB, 0x95, 0xF6, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 101: {3, 0x68, {0xBB, 0x96, 0x10, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 102: {3, 0x68, {0xBB, 0x97, 0x0F, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 103: {3, 0x68, {0xBB, 0x98, 0xF6, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 104: {3, 0x68, {0xBB, 0x99, 0x10, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 105: {3, 0x68, {0xBB, 0x9A, 0x0F, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 106: {3, 0x68, {0xBB, 0x9B, 0xF6, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 107: {3, 0x68, {0xB8, 0x8A, 0x03, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 108: {3, 0x68, {0xB8, 0x96, 0x03, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 109: {3, 0x68, {0xBB, 0xD1, 0x07, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 110: {3, 0x68, {0xBB, 0xB0, 0x07, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 111: {3, 0x68, {0xB8, 0x8B, 0x04, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 112: {3, 0x68, {0xB8, 0x8C, 0x45, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 113: {3, 0x68, {0xB8, 0x8D, 0x05, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 114: {3, 0x68, {0xB8, 0x97, 0x04, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 115: {3, 0x68, {0xB8, 0x98, 0xE0, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 116: {3, 0x68, {0xB8, 0x99, 0x2E, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 117: {3, 0x68, {0x80, 0x0E, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 118: {6, 0x68, {0x10, 0x14, 0x07, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 119: {6, 0x68, {0x10, 0x18, 0xFF, 0xFF, 0xFF, 0xFF}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 121: {6, 0x68, {0x01, 0x48, 0xB0, 0x04, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 122: {6, 0x68, {0x29, 0x20, 0x10, 0x0E, 0x0B, 0x3E}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 124: {3, 0x68, {0xB6, 0x31, 0xFF, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 125: {3, 0x68, {0x80, 0x01, 0x14, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 126: {3, 0x68, {0x80, 0x02, 0x02, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 127: {3, 0x68, {0xB6, 0x08, 0x0B, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 128: {3, 0x68, {0xB8, 0x00, 0x1E, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 129: {3, 0x68, {0x87, 0x00, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 130: {6, 0x68, {0x50, 0x10, 0x00, 0x00, 0x9D, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 131: {6, 0x68, {0x00, 0x8C, 0x40, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 132: {6, 0x68, {0x00, 0x80, 0x02, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 134: {3, 0x68, {0x82, 0x02, 0xFF, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 135: {3, 0x68, {0x82, 0x03, 0xFF, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 136: {3, 0x68, {0x82, 0x04, 0xFF, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 137: {6, 0x68, {0x21, 0x58, 0x09, 0x00, 0x28, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 138: {6, 0x68, {0x21, 0x60, 0x07, 0x00, 0x0F, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 139: {6, 0x68, {0x21, 0x64, 0x28, 0x23, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 140: {6, 0x68, {0x21, 0x68, 0x0E, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 142: {6, 0x68, {0x20, 0x7C, 0x81, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 143: {6, 0x68, {0x20, 0x50, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 144: {6, 0x68, {0x20, 0x1C, 0x01, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 145: {6, 0x68, {0x20, 0x60, 0xFF, 0xFF, 0xFF, 0xFF}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 147: {6, 0x68, {0x08, 0x04, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 148: {6, 0x68, {0x00, 0x80, 0x0F, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 149: {6, 0x68, {0x00, 0x84, 0x0F, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 150: {6, 0x68, {0x00, 0x84, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 151: {6, 0x68, {0x00, 0x84, 0x0F, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 153: {6, 0x68, {0x20, 0x50, 0x20, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 155: {6, 0x68, {0x22, 0xFC, 0x15, 0x01, 0x00, 0x81}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 156: {6, 0x68, {0x22, 0xFC, 0x15, 0x8C, 0x80, 0x81}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 157: {6, 0x68, {0x22, 0xFC, 0x15, 0xC7, 0x50, 0x81}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 158: {6, 0x68, {0x22, 0xFC, 0x15, 0xC5, 0x50, 0x81}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 159: {6, 0x68, {0x22, 0xFC, 0x15, 0x85, 0x04, 0x81}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 160: {6, 0x68, {0x22, 0xFC, 0x15, 0x86, 0x08, 0x81}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 161: {6, 0x68, {0x22, 0xFC, 0x15, 0x83, 0xAA, 0x81}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 162: {6, 0x68, {0x22, 0xFC, 0x15, 0x84, 0x11, 0x81}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 163: {6, 0x68, {0x22, 0xFC, 0x15, 0x9C, 0x10, 0x81}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 164: {6, 0x68, {0x22, 0xFC, 0x15, 0xA9, 0x4B, 0x81}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 165: {6, 0x68, {0x22, 0xFC, 0x05, 0x11, 0x00, 0x81}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 166: {6, 0x68, {0x22, 0xFC, 0x05, 0x29, 0x00, 0x81}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 167: {6, 0x68, {0x2A, 0x10, 0x10, 0x00, 0x04, 0x80}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 168: {6, 0x68, {0x2A, 0x04, 0x01, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 170: {6, 0x68, {0x01, 0x54, 0x01, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 172: {0, 0x00, {0x00, 0x00, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 178: {6, 0x68, {0x08, 0x00, 0x01, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 180: {6, 0x68, {0x10, 0x00, 0x78, 0x69, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 181: {6, 0x68, {0x10, 0x04, 0x02, 0x08, 0x02, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 182: {6, 0x68, {0x10, 0x08, 0x22, 0x00, 0xA0, 0x02}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 183: {6, 0x68, {0x10, 0x0C, 0x50, 0x04, 0x00, 0x03}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 184: {6, 0x68, {0x10, 0x10, 0x10, 0x0D, 0x06, 0x01}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 185: {6, 0x68, {0x10, 0x14, 0x01, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 186: {6, 0x68, {0x10, 0x18, 0xFF, 0xFF, 0xFF, 0xFF}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 188: {3, 0x68, {0xB0, 0x05, 0x0A, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 189: {3, 0x68, {0xB0, 0x06, 0x03, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 190: {3, 0x68, {0xB0, 0x07, 0x16, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 191: {3, 0x68, {0xB0, 0x08, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 192: {3, 0x68, {0xB0, 0x09, 0x21, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 193: {3, 0x68, {0xB0, 0x0A, 0x07, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 195: {6, 0x68, {0x41, 0xB0, 0xC1, 0x22, 0x04, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 196: {6, 0x68, {0x41, 0xBC, 0x01, 0x0E, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 197: {6, 0x68, {0x41, 0xC0, 0x30, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 198: {6, 0x68, {0x10, 0x14, 0x03, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 199: {6, 0x68, {0x10, 0x18, 0xFF, 0xFF, 0xFF, 0xFF}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 201: {3, 0x68, {0x80, 0x03, 0x41, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 202: {3, 0x68, {0xB4, 0x00, 0x0D, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 204: {3, 0x68, {0xB8, 0x8E, 0xFF, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 205: {3, 0x68, {0xB8, 0x8F, 0xFF, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 206: {3, 0x68, {0xB8, 0x9A, 0xFF, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 207: {3, 0x68, {0xB8, 0x9B, 0xFF, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 208: {3, 0x68, {0xB8, 0x00, 0x0E, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 209: {3, 0x68, {0xBB, 0x26, 0x02, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 210: {3, 0x68, {0xBB, 0x01, 0x20, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 211: {3, 0x68, {0xB8, 0xC0, 0xF1, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 212: {3, 0x68, {0xB8, 0xC1, 0xF1, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 213: {3, 0x68, {0xB8, 0xC2, 0xF0, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 214: {3, 0x68, {0xB8, 0xC3, 0xF0, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 215: {3, 0x68, {0xB8, 0xC4, 0xF0, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 216: {3, 0x68, {0xB8, 0xC5, 0xF0, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 217: {3, 0x68, {0xB8, 0xC6, 0xF0, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 218: {3, 0x68, {0xB8, 0xC7, 0xF0, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 219: {3, 0x68, {0xB8, 0x0B, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 220: {3, 0x68, {0xB8, 0x33, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 221: {3, 0x68, {0xB8, 0x5B, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 222: {3, 0x68, {0xB8, 0x10, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 223: {3, 0x68, {0xB8, 0x38, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 224: {3, 0x68, {0xB8, 0x60, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 225: {3, 0x68, {0xB8, 0x15, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 226: {3, 0x68, {0xB8, 0x3D, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 227: {3, 0x68, {0xB8, 0x65, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 228: {3, 0x68, {0xB8, 0x1A, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 229: {3, 0x68, {0xB8, 0x42, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 230: {3, 0x68, {0xB8, 0x6A, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 231: {3, 0x68, {0xB8, 0x1F, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 232: {3, 0x68, {0xB8, 0x47, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 233: {3, 0x68, {0xB8, 0x6F, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 234: {3, 0x68, {0xB8, 0x24, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 235: {3, 0x68, {0xB8, 0x4C, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 236: {3, 0x68, {0xB8, 0x74, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 237: {3, 0x68, {0xB8, 0x29, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 238: {3, 0x68, {0xB8, 0x51, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 239: {3, 0x68, {0xB8, 0x79, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 240: {3, 0x68, {0xB8, 0x2E, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 241: {3, 0x68, {0xB8, 0x56, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 242: {3, 0x68, {0xB8, 0x7E, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 243: {3, 0x68, {0xBB, 0x90, 0x10, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 244: {3, 0x68, {0xBB, 0x91, 0x0F, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 245: {3, 0x68, {0xBB, 0x92, 0xF6, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 246: {3, 0x68, {0xBB, 0x93, 0x10, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 247: {3, 0x68, {0xBB, 0x94, 0x0F, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 248: {3, 0x68, {0xBB, 0x95, 0xF6, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 249: {3, 0x68, {0xBB, 0x96, 0x10, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 250: {3, 0x68, {0xBB, 0x97, 0x0F, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 251: {3, 0x68, {0xBB, 0x98, 0xF6, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 252: {3, 0x68, {0xBB, 0x99, 0x10, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 253: {3, 0x68, {0xBB, 0x9A, 0x0F, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 254: {3, 0x68, {0xBB, 0x9B, 0xF6, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 255: {3, 0x68, {0xB8, 0x8A, 0x03, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 256: {3, 0x68, {0xB8, 0x96, 0x03, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 257: {3, 0x68, {0xBB, 0xD1, 0x07, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 258: {3, 0x68, {0xBB, 0xB0, 0x07, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 259: {3, 0x68, {0xB8, 0x8B, 0x04, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 260: {3, 0x68, {0xB8, 0x8C, 0x45, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 261: {3, 0x68, {0xB8, 0x8D, 0x05, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 262: {3, 0x68, {0xB8, 0x97, 0x04, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 263: {3, 0x68, {0xB8, 0x98, 0xE0, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 264: {3, 0x68, {0xB8, 0x99, 0x2E, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 265: {3, 0x68, {0x80, 0x0E, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 266: {6, 0x68, {0x10, 0x14, 0x07, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 267: {6, 0x68, {0x10, 0x18, 0xFF, 0xFF, 0xFF, 0xFF}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 269: {6, 0x68, {0x01, 0x48, 0xB0, 0x04, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 270: {6, 0x68, {0x29, 0x20, 0x10, 0x0E, 0x0B, 0x3E}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 272: {3, 0x68, {0xB6, 0x31, 0xFF, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 273: {3, 0x68, {0x80, 0x01, 0x14, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 274: {3, 0x68, {0x80, 0x02, 0x02, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 275: {3, 0x68, {0xB6, 0x08, 0x0B, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 276: {3, 0x68, {0xB8, 0x00, 0x1E, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 277: {3, 0x68, {0x87, 0x00, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 278: {6, 0x68, {0x50, 0x10, 0x00, 0x00, 0x9D, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 279: {6, 0x68, {0x00, 0x8C, 0x40, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 280: {6, 0x68, {0x00, 0x80, 0x02, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 282: {3, 0x68, {0x82, 0x02, 0xFF, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 283: {3, 0x68, {0x82, 0x03, 0xFF, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 284: {3, 0x68, {0x82, 0x04, 0xFF, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 286: {6, 0x68, {0x21, 0x54, 0x0D, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 287: {6, 0x68, {0x21, 0x58, 0x06, 0x00, 0x2A, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 288: {6, 0x68, {0x21, 0x5C, 0x07, 0x00, 0x0E, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 289: {6, 0x68, {0x21, 0x60, 0x07, 0x00, 0x10, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 290: {6, 0x68, {0x21, 0x64, 0x10, 0x27, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 291: {6, 0x68, {0x21, 0x68, 0x0E, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 292: {6, 0x68, {0x21, 0x6C, 0x0A, 0x00, 0x0E, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 293: {6, 0x68, {0x21, 0x78, 0x0E, 0x00, 0x0D, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 295: {6, 0x68, {0x20, 0x7C, 0x81, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 296: {6, 0x68, {0x20, 0x50, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 297: {6, 0x68, {0x20, 0x1C, 0x01, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 298: {6, 0x68, {0x20, 0x60, 0xFF, 0xFF, 0xFF, 0xFF}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 300: {6, 0x68, {0x08, 0x04, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 301: {6, 0x68, {0x00, 0x80, 0x0F, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 302: {6, 0x68, {0x00, 0x84, 0x0F, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 303: {6, 0x68, {0x00, 0x84, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 304: {6, 0x68, {0x00, 0x84, 0x0F, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 306: {6, 0x68, {0x20, 0x50, 0x20, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 308: {6, 0x68, {0x22, 0xFC, 0x15, 0xBF, 0xA5, 0x81}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 309: {6, 0x68, {0x22, 0xFC, 0x15, 0x01, 0x00, 0x81}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 310: {6, 0x68, {0x22, 0xFC, 0x15, 0x8F, 0xA5, 0x81}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 311: {6, 0x68, {0x22, 0xFC, 0x15, 0x83, 0xAA, 0x81}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 312: {6, 0x68, {0x22, 0xFC, 0x15, 0x84, 0x11, 0x81}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 313: {6, 0x68, {0x22, 0xFC, 0x15, 0xA9, 0x48, 0x81}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 314: {6, 0x68, {0x22, 0xFC, 0x15, 0x83, 0x00, 0x81}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 315: {6, 0x68, {0x22, 0xFC, 0x15, 0x84, 0x00, 0x81}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 316: {6, 0x68, {0x22, 0xFC, 0x15, 0x8F, 0x00, 0x81}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 317: {6, 0x68, {0x2A, 0x10, 0x10, 0x00, 0x04, 0x80}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 318: {6, 0x68, {0x2A, 0x04, 0x01, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 320: {6, 0x68, {0x01, 0x54, 0x01, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/1/src/mainboard/facebook/fbg1... PS1, Line 322: {0, 0x00, {0x00, 0x00, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35963 )
Change subject: mb/facebook/fbg1701: correct clang issues ......................................................................
Patch Set 1:
Patch Set 1:
(256 comments)
There seems to be a difference between the clang checking on the coreboot tree. (I initialized a fresh one) and jenkins. This commit passes the clang check locally. If I add the required space the test fails locally!
Hello Frans Hendriks, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35963
to look at the new patch set (#2).
Change subject: mb/facebook/fbg1701: correct clang issues ......................................................................
mb/facebook/fbg1701: correct clang issues
Corrected clang issues in fbg1701 dicretory.
BUG=N/A TEST=build
Change-Id: I968bf8418aa457a7ebd28096bd92a64211bf86dd Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/mainboard/facebook/fbg1701/logo.c M src/mainboard/facebook/fbg1701/onboard.h M src/mainboard/facebook/fbg1701/ramstage.c M src/mainboard/facebook/fbg1701/romstage.c 4 files changed, 278 insertions(+), 281 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/35963/2
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35963 )
Change subject: mb/facebook/fbg1701: correct clang issues ......................................................................
Patch Set 2:
(130 comments)
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... File src/mainboard/facebook/fbg1701/ramstage.c:
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 178: {6, 0x68, {0x08, 0x00, 0x01, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 180: {6, 0x68, {0x10, 0x00, 0x78, 0x69, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 181: {6, 0x68, {0x10, 0x04, 0x02, 0x08, 0x02, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 182: {6, 0x68, {0x10, 0x08, 0x22, 0x00, 0xA0, 0x02}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 183: {6, 0x68, {0x10, 0x0C, 0x50, 0x04, 0x00, 0x03}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 184: {6, 0x68, {0x10, 0x10, 0x10, 0x0D, 0x06, 0x01}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 185: {6, 0x68, {0x10, 0x14, 0x01, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 186: {6, 0x68, {0x10, 0x18, 0xFF, 0xFF, 0xFF, 0xFF}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 188: {3, 0x68, {0xB0, 0x05, 0x0A, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 189: {3, 0x68, {0xB0, 0x06, 0x03, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 190: {3, 0x68, {0xB0, 0x07, 0x16, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 191: {3, 0x68, {0xB0, 0x08, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 192: {3, 0x68, {0xB0, 0x09, 0x21, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 193: {3, 0x68, {0xB0, 0x0A, 0x07, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 195: {6, 0x68, {0x41, 0xB0, 0xC1, 0x22, 0x04, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 196: {6, 0x68, {0x41, 0xBC, 0x01, 0x0E, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 197: {6, 0x68, {0x41, 0xC0, 0x30, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 198: {6, 0x68, {0x10, 0x14, 0x03, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 199: {6, 0x68, {0x10, 0x18, 0xFF, 0xFF, 0xFF, 0xFF}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 201: {3, 0x68, {0x80, 0x03, 0x41, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 202: {3, 0x68, {0xB4, 0x00, 0x0D, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 204: {3, 0x68, {0xB8, 0x8E, 0xFF, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 205: {3, 0x68, {0xB8, 0x8F, 0xFF, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 206: {3, 0x68, {0xB8, 0x9A, 0xFF, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 207: {3, 0x68, {0xB8, 0x9B, 0xFF, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 208: {3, 0x68, {0xB8, 0x00, 0x0E, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 209: {3, 0x68, {0xBB, 0x26, 0x02, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 210: {3, 0x68, {0xBB, 0x01, 0x20, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 211: {3, 0x68, {0xB8, 0xC0, 0xF1, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 212: {3, 0x68, {0xB8, 0xC1, 0xF1, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 213: {3, 0x68, {0xB8, 0xC2, 0xF0, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 214: {3, 0x68, {0xB8, 0xC3, 0xF0, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 215: {3, 0x68, {0xB8, 0xC4, 0xF0, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 216: {3, 0x68, {0xB8, 0xC5, 0xF0, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 217: {3, 0x68, {0xB8, 0xC6, 0xF0, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 218: {3, 0x68, {0xB8, 0xC7, 0xF0, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 219: {3, 0x68, {0xB8, 0x0B, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 220: {3, 0x68, {0xB8, 0x33, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 221: {3, 0x68, {0xB8, 0x5B, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 222: {3, 0x68, {0xB8, 0x10, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 223: {3, 0x68, {0xB8, 0x38, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 224: {3, 0x68, {0xB8, 0x60, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 225: {3, 0x68, {0xB8, 0x15, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 226: {3, 0x68, {0xB8, 0x3D, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 227: {3, 0x68, {0xB8, 0x65, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 228: {3, 0x68, {0xB8, 0x1A, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 229: {3, 0x68, {0xB8, 0x42, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 230: {3, 0x68, {0xB8, 0x6A, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 231: {3, 0x68, {0xB8, 0x1F, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 232: {3, 0x68, {0xB8, 0x47, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 233: {3, 0x68, {0xB8, 0x6F, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 234: {3, 0x68, {0xB8, 0x24, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 235: {3, 0x68, {0xB8, 0x4C, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 236: {3, 0x68, {0xB8, 0x74, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 237: {3, 0x68, {0xB8, 0x29, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 238: {3, 0x68, {0xB8, 0x51, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 239: {3, 0x68, {0xB8, 0x79, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 240: {3, 0x68, {0xB8, 0x2E, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 241: {3, 0x68, {0xB8, 0x56, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 242: {3, 0x68, {0xB8, 0x7E, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 243: {3, 0x68, {0xBB, 0x90, 0x10, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 244: {3, 0x68, {0xBB, 0x91, 0x0F, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 245: {3, 0x68, {0xBB, 0x92, 0xF6, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 246: {3, 0x68, {0xBB, 0x93, 0x10, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 247: {3, 0x68, {0xBB, 0x94, 0x0F, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 248: {3, 0x68, {0xBB, 0x95, 0xF6, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 249: {3, 0x68, {0xBB, 0x96, 0x10, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 250: {3, 0x68, {0xBB, 0x97, 0x0F, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 251: {3, 0x68, {0xBB, 0x98, 0xF6, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 252: {3, 0x68, {0xBB, 0x99, 0x10, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 253: {3, 0x68, {0xBB, 0x9A, 0x0F, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 254: {3, 0x68, {0xBB, 0x9B, 0xF6, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 255: {3, 0x68, {0xB8, 0x8A, 0x03, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 256: {3, 0x68, {0xB8, 0x96, 0x03, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 257: {3, 0x68, {0xBB, 0xD1, 0x07, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 258: {3, 0x68, {0xBB, 0xB0, 0x07, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 259: {3, 0x68, {0xB8, 0x8B, 0x04, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 260: {3, 0x68, {0xB8, 0x8C, 0x45, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 261: {3, 0x68, {0xB8, 0x8D, 0x05, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 262: {3, 0x68, {0xB8, 0x97, 0x04, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 263: {3, 0x68, {0xB8, 0x98, 0xE0, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 264: {3, 0x68, {0xB8, 0x99, 0x2E, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 265: {3, 0x68, {0x80, 0x0E, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 266: {6, 0x68, {0x10, 0x14, 0x07, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 267: {6, 0x68, {0x10, 0x18, 0xFF, 0xFF, 0xFF, 0xFF}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 269: {6, 0x68, {0x01, 0x48, 0xB0, 0x04, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 270: {6, 0x68, {0x29, 0x20, 0x10, 0x0E, 0x0B, 0x3E}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 272: {3, 0x68, {0xB6, 0x31, 0xFF, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 273: {3, 0x68, {0x80, 0x01, 0x14, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 274: {3, 0x68, {0x80, 0x02, 0x02, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 275: {3, 0x68, {0xB6, 0x08, 0x0B, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 276: {3, 0x68, {0xB8, 0x00, 0x1E, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 277: {3, 0x68, {0x87, 0x00, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 278: {6, 0x68, {0x50, 0x10, 0x00, 0x00, 0x9D, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 279: {6, 0x68, {0x00, 0x8C, 0x40, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 280: {6, 0x68, {0x00, 0x80, 0x02, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 282: {3, 0x68, {0x82, 0x02, 0xFF, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 283: {3, 0x68, {0x82, 0x03, 0xFF, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 284: {3, 0x68, {0x82, 0x04, 0xFF, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 286: {6, 0x68, {0x21, 0x54, 0x0D, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 287: {6, 0x68, {0x21, 0x58, 0x06, 0x00, 0x2A, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 288: {6, 0x68, {0x21, 0x5C, 0x07, 0x00, 0x0E, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 289: {6, 0x68, {0x21, 0x60, 0x07, 0x00, 0x10, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 290: {6, 0x68, {0x21, 0x64, 0x10, 0x27, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 291: {6, 0x68, {0x21, 0x68, 0x0E, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 292: {6, 0x68, {0x21, 0x6C, 0x0A, 0x00, 0x0E, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 293: {6, 0x68, {0x21, 0x78, 0x0E, 0x00, 0x0D, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 295: {6, 0x68, {0x20, 0x7C, 0x81, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 296: {6, 0x68, {0x20, 0x50, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 297: {6, 0x68, {0x20, 0x1C, 0x01, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 298: {6, 0x68, {0x20, 0x60, 0xFF, 0xFF, 0xFF, 0xFF}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 300: {6, 0x68, {0x08, 0x04, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 301: {6, 0x68, {0x00, 0x80, 0x0F, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 302: {6, 0x68, {0x00, 0x84, 0x0F, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 303: {6, 0x68, {0x00, 0x84, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 304: {6, 0x68, {0x00, 0x84, 0x0F, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 306: {6, 0x68, {0x20, 0x50, 0x20, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 308: {6, 0x68, {0x22, 0xFC, 0x15, 0xBF, 0xA5, 0x81}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 309: {6, 0x68, {0x22, 0xFC, 0x15, 0x01, 0x00, 0x81}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 310: {6, 0x68, {0x22, 0xFC, 0x15, 0x8F, 0xA5, 0x81}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 311: {6, 0x68, {0x22, 0xFC, 0x15, 0x83, 0xAA, 0x81}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 312: {6, 0x68, {0x22, 0xFC, 0x15, 0x84, 0x11, 0x81}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 313: {6, 0x68, {0x22, 0xFC, 0x15, 0xA9, 0x48, 0x81}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 314: {6, 0x68, {0x22, 0xFC, 0x15, 0x83, 0x00, 0x81}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 315: {6, 0x68, {0x22, 0xFC, 0x15, 0x84, 0x00, 0x81}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 316: {6, 0x68, {0x22, 0xFC, 0x15, 0x8F, 0x00, 0x81}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 317: {6, 0x68, {0x2A, 0x10, 0x10, 0x00, 0x04, 0x80}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 318: {6, 0x68, {0x2A, 0x04, 0x01, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 320: {6, 0x68, {0x01, 0x54, 0x01, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/35963/2/src/mainboard/facebook/fbg1... PS2, Line 322: {0, 0x00, {0x00, 0x00, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
Hello Frans Hendriks, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35963
to look at the new patch set (#3).
Change subject: mb/facebook/fbg1701: correct clang issues ......................................................................
mb/facebook/fbg1701: correct clang issues
Corrected clang issues in fbg1701 directory.
BUG=N/A TEST=build
Change-Id: I968bf8418aa457a7ebd28096bd92a64211bf86dd Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/mainboard/facebook/fbg1701/logo.c M src/mainboard/facebook/fbg1701/onboard.h M src/mainboard/facebook/fbg1701/ramstage.c M src/mainboard/facebook/fbg1701/romstage.c 4 files changed, 278 insertions(+), 281 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/35963/3
Hello Frans Hendriks, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35963
to look at the new patch set (#4).
Change subject: mb/facebook/fbg1701: correct clang issues ......................................................................
mb/facebook/fbg1701: correct clang issues
Corrected clang issues in fbg1701 directory.
BUG=N/A TEST=build
Change-Id: I968bf8418aa457a7ebd28096bd92a64211bf86dd Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/mainboard/facebook/fbg1701/logo.c M src/mainboard/facebook/fbg1701/onboard.h M src/mainboard/facebook/fbg1701/ramstage.c M src/mainboard/facebook/fbg1701/romstage.c 4 files changed, 278 insertions(+), 281 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/35963/4
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35963 )
Change subject: mb/facebook/fbg1701: correct clang issues ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35963 )
Change subject: mb/facebook/fbg1701: correct clang issues ......................................................................
mb/facebook/fbg1701: correct clang issues
Corrected clang issues in fbg1701 directory.
BUG=N/A TEST=build
Change-Id: I968bf8418aa457a7ebd28096bd92a64211bf86dd Signed-off-by: Wim Vervoorn wvervoorn@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35963 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Frans Hendriks fhendriks@eltan.com --- M src/mainboard/facebook/fbg1701/logo.c M src/mainboard/facebook/fbg1701/onboard.h M src/mainboard/facebook/fbg1701/ramstage.c M src/mainboard/facebook/fbg1701/romstage.c 4 files changed, 278 insertions(+), 281 deletions(-)
Approvals: build bot (Jenkins): Verified Frans Hendriks: Looks good to me, approved
diff --git a/src/mainboard/facebook/fbg1701/logo.c b/src/mainboard/facebook/fbg1701/logo.c index 678d2e2..10c72c7 100644 --- a/src/mainboard/facebook/fbg1701/logo.c +++ b/src/mainboard/facebook/fbg1701/logo.c @@ -32,16 +32,15 @@ return (void *)logo_data; }
- logo_data_sz = cbfs_boot_load_file(filename, logo_data, - sizeof(logo_data), CBFS_TYPE_RAW); + logo_data_sz = + cbfs_boot_load_file(filename, logo_data, sizeof(logo_data), CBFS_TYPE_RAW); if (logo_data_sz == 0) return NULL;
if (logo_size) *logo_size = logo_data_sz;
- printk(BIOS_DEBUG, "Found a Logo of %zu bytes after decompression\n", - logo_data_sz); + printk(BIOS_DEBUG, "Found a Logo of %zu bytes after decompression\n", logo_data_sz);
return (void *)logo_data; } diff --git a/src/mainboard/facebook/fbg1701/onboard.h b/src/mainboard/facebook/fbg1701/onboard.h index 330fe0f..2c78d15 100644 --- a/src/mainboard/facebook/fbg1701/onboard.h +++ b/src/mainboard/facebook/fbg1701/onboard.h @@ -19,10 +19,8 @@ #define ONBOARD_H
/* SD CARD gpio */ -#define SDCARD_CD 81 /* Not used */ +#define SDCARD_CD 81 /* Not used */
-#define ITE8528_CMD_PORT 0x6E -#define ITE8528_DATA_PORT 0x6F
/* CPLD definitions */ #define CPLD_PCB_VERSION_PORT 0x283 @@ -32,15 +30,17 @@ #define CPLD_RESET_PORT 0x287 #define CPLD_CMD_RESET_DSI_BRIDGE_ACTIVE 0x20 #define CPLD_CMD_RESET_DSI_BRIDGE_INACTIVE 0x00 +#define ITE8528_CMD_PORT 0x6E +#define ITE8528_DATA_PORT 0x6F
/* Define the items to be measured or verified */ -#define FSP (const char *)"fsp.bin" -#define CMOS_LAYOUT (const char *)"cmos_layout.bin" -#define RAMSTAGE (const char *)"fallback/ramstage" -#define ROMSTAGE (const char *)"fallback/romstage" -#define PAYLOAD (const char *)"fallback/payload" -#define POSTCAR (const char *)"fallback/postcar" -#define OP_ROM_VBT (const char *)"vbt.bin" -#define MICROCODE (const char *)"cpu_microcode_blob.bin" +#define FSP (const char *)"fsp.bin" +#define CMOS_LAYOUT (const char *)"cmos_layout.bin" +#define RAMSTAGE (const char *)"fallback/ramstage" +#define ROMSTAGE (const char *)"fallback/romstage" +#define PAYLOAD (const char *)"fallback/payload" +#define POSTCAR (const char *)"fallback/postcar" +#define OP_ROM_VBT (const char *)"vbt.bin" +#define MICROCODE (const char *)"cpu_microcode_blob.bin"
#endif diff --git a/src/mainboard/facebook/fbg1701/ramstage.c b/src/mainboard/facebook/fbg1701/ramstage.c index c5fb798..980a6cc 100644 --- a/src/mainboard/facebook/fbg1701/ramstage.c +++ b/src/mainboard/facebook/fbg1701/ramstage.c @@ -31,295 +31,295 @@ static const struct edp_data b101uan01_table[] = { /* set eDP bridge to 1200x1920 */ /* IO */ - { 6, 0x68, { 0x08, 0x00, 0x01, 0x00, 0x00, 0x00 } }, + {6, 0x68, {0x08, 0x00, 0x01, 0x00, 0x00, 0x00} }, /* Boot */ - { 6, 0x68, { 0x10, 0x00, 0x78, 0x69, 0x00, 0x00 } }, - { 6, 0x68, { 0x10, 0x04, 0x02, 0x08, 0x02, 0x00 } }, - { 6, 0x68, { 0x10, 0x08, 0x23, 0x00, 0x87, 0x02 } }, - { 6, 0x68, { 0x10, 0x0C, 0x19, 0x04, 0x00, 0x23 } }, - { 6, 0x68, { 0x10, 0x10, 0x06, 0x00, 0x67, 0x00 } }, - { 6, 0x68, { 0x10, 0x14, 0x01, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x10, 0x18, 0xFF, 0xFF, 0xFF, 0xFF } }, + {6, 0x68, {0x10, 0x00, 0x78, 0x69, 0x00, 0x00} }, + {6, 0x68, {0x10, 0x04, 0x02, 0x08, 0x02, 0x00} }, + {6, 0x68, {0x10, 0x08, 0x23, 0x00, 0x87, 0x02} }, + {6, 0x68, {0x10, 0x0C, 0x19, 0x04, 0x00, 0x23} }, + {6, 0x68, {0x10, 0x10, 0x06, 0x00, 0x67, 0x00} }, + {6, 0x68, {0x10, 0x14, 0x01, 0x00, 0x00, 0x00} }, + {6, 0x68, {0x10, 0x18, 0xFF, 0xFF, 0xFF, 0xFF} }, /* Internal */ - { 3, 0x68, { 0xB0, 0x05, 0x0A, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB0, 0x06, 0x03, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB0, 0x07, 0x16, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB0, 0x08, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB0, 0x09, 0x21, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB0, 0x0A, 0x07, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x10, 0x14, 0x03, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x10, 0x18, 0xFF, 0xFF, 0xFF, 0xFF } }, + {3, 0x68, {0xB0, 0x05, 0x0A, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB0, 0x06, 0x03, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB0, 0x07, 0x16, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB0, 0x08, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB0, 0x09, 0x21, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB0, 0x0A, 0x07, 0x00, 0x00, 0x00} }, + {6, 0x68, {0x10, 0x14, 0x03, 0x00, 0x00, 0x00} }, + {6, 0x68, {0x10, 0x18, 0xFF, 0xFF, 0xFF, 0xFF} }, /* eDP */ - { 3, 0x68, { 0x80, 0x03, 0x41, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB4, 0x00, 0x0D, 0x00, 0x00, 0x00 } }, + {3, 0x68, {0x80, 0x03, 0x41, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB4, 0x00, 0x0D, 0x00, 0x00, 0x00} }, /* DPRX */ - { 3, 0x68, { 0xB8, 0x8E, 0xFF, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x8F, 0xFF, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x9A, 0xFF, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x9B, 0xFF, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x00, 0x0E, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x26, 0x02, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x01, 0x20, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0xC0, 0xF1, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0xC1, 0xF1, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0xC2, 0xF0, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0xC3, 0xF0, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0xC4, 0xF0, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0xC5, 0xF0, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0xC6, 0xF0, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0xC7, 0xF0, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x0B, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x33, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x5B, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x10, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x38, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x60, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x15, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x3D, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x65, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x1A, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x42, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x6A, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x1F, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x47, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x6F, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x24, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x4C, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x74, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x29, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x51, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x79, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x2E, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x56, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x7E, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x90, 0x10, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x91, 0x0F, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x92, 0xF6, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x93, 0x10, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x94, 0x0F, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x95, 0xF6, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x96, 0x10, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x97, 0x0F, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x98, 0xF6, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x99, 0x10, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x9A, 0x0F, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x9B, 0xF6, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x8A, 0x03, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x96, 0x03, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0xD1, 0x07, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0xB0, 0x07, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x8B, 0x04, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x8C, 0x45, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x8D, 0x05, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x97, 0x04, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x98, 0xE0, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x99, 0x2E, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0x80, 0x0E, 0x00, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x10, 0x14, 0x07, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x10, 0x18, 0xFF, 0xFF, 0xFF, 0xFF } }, + {3, 0x68, {0xB8, 0x8E, 0xFF, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x8F, 0xFF, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x9A, 0xFF, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x9B, 0xFF, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x00, 0x0E, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xBB, 0x26, 0x02, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xBB, 0x01, 0x20, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0xC0, 0xF1, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0xC1, 0xF1, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0xC2, 0xF0, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0xC3, 0xF0, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0xC4, 0xF0, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0xC5, 0xF0, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0xC6, 0xF0, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0xC7, 0xF0, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x0B, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x33, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x5B, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x10, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x38, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x60, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x15, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x3D, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x65, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x1A, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x42, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x6A, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x1F, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x47, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x6F, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x24, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x4C, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x74, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x29, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x51, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x79, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x2E, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x56, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x7E, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xBB, 0x90, 0x10, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xBB, 0x91, 0x0F, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xBB, 0x92, 0xF6, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xBB, 0x93, 0x10, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xBB, 0x94, 0x0F, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xBB, 0x95, 0xF6, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xBB, 0x96, 0x10, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xBB, 0x97, 0x0F, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xBB, 0x98, 0xF6, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xBB, 0x99, 0x10, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xBB, 0x9A, 0x0F, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xBB, 0x9B, 0xF6, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x8A, 0x03, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x96, 0x03, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xBB, 0xD1, 0x07, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xBB, 0xB0, 0x07, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x8B, 0x04, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x8C, 0x45, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x8D, 0x05, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x97, 0x04, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x98, 0xE0, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x99, 0x2E, 0x00, 0x00, 0x00} }, + {3, 0x68, {0x80, 0x0E, 0x00, 0x00, 0x00, 0x00} }, + {6, 0x68, {0x10, 0x14, 0x07, 0x00, 0x00, 0x00} }, + {6, 0x68, {0x10, 0x18, 0xFF, 0xFF, 0xFF, 0xFF} }, /* Video size */ - { 6, 0x68, { 0x01, 0x48, 0xB0, 0x04, 0x00, 0x00 } }, - { 6, 0x68, { 0x29, 0x20, 0x10, 0x0E, 0x0B, 0x3E } }, + {6, 0x68, {0x01, 0x48, 0xB0, 0x04, 0x00, 0x00} }, + {6, 0x68, {0x29, 0x20, 0x10, 0x0E, 0x0B, 0x3E} }, /* eDP */ - { 3, 0x68, { 0xB6, 0x31, 0xFF, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0x80, 0x01, 0x14, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0x80, 0x02, 0x02, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB6, 0x08, 0x0B, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x00, 0x1E, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0x87, 0x00, 0x00, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x50, 0x10, 0x00, 0x00, 0x9D, 0x00 } }, - { 6, 0x68, { 0x00, 0x8C, 0x40, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x00, 0x80, 0x02, 0x00, 0x00, 0x00 } }, + {3, 0x68, {0xB6, 0x31, 0xFF, 0x00, 0x00, 0x00} }, + {3, 0x68, {0x80, 0x01, 0x14, 0x00, 0x00, 0x00} }, + {3, 0x68, {0x80, 0x02, 0x02, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB6, 0x08, 0x0B, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x00, 0x1E, 0x00, 0x00, 0x00} }, + {3, 0x68, {0x87, 0x00, 0x00, 0x00, 0x00, 0x00} }, + {6, 0x68, {0x50, 0x10, 0x00, 0x00, 0x9D, 0x00} }, + {6, 0x68, {0x00, 0x8C, 0x40, 0x00, 0x00, 0x00} }, + {6, 0x68, {0x00, 0x80, 0x02, 0x00, 0x00, 0x00} }, /* Link Training */ - { 3, 0x68, { 0x82, 0x02, 0xFF, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0x82, 0x03, 0xFF, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0x82, 0x04, 0xFF, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x21, 0x58, 0x09, 0x00, 0x28, 0x00 } }, - { 6, 0x68, { 0x21, 0x60, 0x07, 0x00, 0x0F, 0x00 } }, - { 6, 0x68, { 0x21, 0x64, 0x28, 0x23, 0x00, 0x00 } }, - { 6, 0x68, { 0x21, 0x68, 0x0E, 0x00, 0x00, 0x00 } }, + {3, 0x68, {0x82, 0x02, 0xFF, 0x00, 0x00, 0x00} }, + {3, 0x68, {0x82, 0x03, 0xFF, 0x00, 0x00, 0x00} }, + {3, 0x68, {0x82, 0x04, 0xFF, 0x00, 0x00, 0x00} }, + {6, 0x68, {0x21, 0x58, 0x09, 0x00, 0x28, 0x00} }, + {6, 0x68, {0x21, 0x60, 0x07, 0x00, 0x0F, 0x00} }, + {6, 0x68, {0x21, 0x64, 0x28, 0x23, 0x00, 0x00} }, + {6, 0x68, {0x21, 0x68, 0x0E, 0x00, 0x00, 0x00} }, /* DSI */ - { 6, 0x68, { 0x20, 0x7C, 0x81, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x20, 0x50, 0x00, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x20, 0x1C, 0x01, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x20, 0x60, 0xFF, 0xFF, 0xFF, 0xFF } }, + {6, 0x68, {0x20, 0x7C, 0x81, 0x00, 0x00, 0x00} }, + {6, 0x68, {0x20, 0x50, 0x00, 0x00, 0x00, 0x00} }, + {6, 0x68, {0x20, 0x1C, 0x01, 0x00, 0x00, 0x00} }, + {6, 0x68, {0x20, 0x60, 0xFF, 0xFF, 0xFF, 0xFF} }, /* GPIO */ - { 6, 0x68, { 0x08, 0x04, 0x00, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x00, 0x80, 0x0F, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x00, 0x84, 0x0F, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x00, 0x84, 0x00, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x00, 0x84, 0x0F, 0x00, 0x00, 0x00 } }, + {6, 0x68, {0x08, 0x04, 0x00, 0x00, 0x00, 0x00} }, + {6, 0x68, {0x00, 0x80, 0x0F, 0x00, 0x00, 0x00} }, + {6, 0x68, {0x00, 0x84, 0x0F, 0x00, 0x00, 0x00} }, + {6, 0x68, {0x00, 0x84, 0x00, 0x00, 0x00, 0x00} }, + {6, 0x68, {0x00, 0x84, 0x0F, 0x00, 0x00, 0x00} }, /* DSI clock */ - { 6, 0x68, { 0x20, 0x50, 0x20, 0x00, 0x00, 0x00 } }, + {6, 0x68, {0x20, 0x50, 0x20, 0x00, 0x00, 0x00} }, /* LCD init */ - { 6, 0x68, { 0x22, 0xFC, 0x15, 0x01, 0x00, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x15, 0x8C, 0x80, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x15, 0xC7, 0x50, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x15, 0xC5, 0x50, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x15, 0x85, 0x04, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x15, 0x86, 0x08, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x15, 0x83, 0xAA, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x15, 0x84, 0x11, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x15, 0x9C, 0x10, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x15, 0xA9, 0x4B, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x05, 0x11, 0x00, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x05, 0x29, 0x00, 0x81 } }, - { 6, 0x68, { 0x2A, 0x10, 0x10, 0x00, 0x04, 0x80 } }, - { 6, 0x68, { 0x2A, 0x04, 0x01, 0x00, 0x00, 0x00 } }, + {6, 0x68, {0x22, 0xFC, 0x15, 0x01, 0x00, 0x81} }, + {6, 0x68, {0x22, 0xFC, 0x15, 0x8C, 0x80, 0x81} }, + {6, 0x68, {0x22, 0xFC, 0x15, 0xC7, 0x50, 0x81} }, + {6, 0x68, {0x22, 0xFC, 0x15, 0xC5, 0x50, 0x81} }, + {6, 0x68, {0x22, 0xFC, 0x15, 0x85, 0x04, 0x81} }, + {6, 0x68, {0x22, 0xFC, 0x15, 0x86, 0x08, 0x81} }, + {6, 0x68, {0x22, 0xFC, 0x15, 0x83, 0xAA, 0x81} }, + {6, 0x68, {0x22, 0xFC, 0x15, 0x84, 0x11, 0x81} }, + {6, 0x68, {0x22, 0xFC, 0x15, 0x9C, 0x10, 0x81} }, + {6, 0x68, {0x22, 0xFC, 0x15, 0xA9, 0x4B, 0x81} }, + {6, 0x68, {0x22, 0xFC, 0x05, 0x11, 0x00, 0x81} }, + {6, 0x68, {0x22, 0xFC, 0x05, 0x29, 0x00, 0x81} }, + {6, 0x68, {0x2A, 0x10, 0x10, 0x00, 0x04, 0x80} }, + {6, 0x68, {0x2A, 0x04, 0x01, 0x00, 0x00, 0x00} }, /* Check Video */ - { 6, 0x68, { 0x01, 0x54, 0x01, 0x00, 0x00, 0x00 } }, + {6, 0x68, {0x01, 0x54, 0x01, 0x00, 0x00, 0x00} }, /* End of table */ - { 0, 0x00, { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 } }, + {0, 0x00, {0x00, 0x00, 0x00, 0x00, 0x00, 0x00} }, };
static const struct edp_data b101uan08_table[] = { /* set eDP bridge to 1200x1920 */ /* IO Voltage Setting */ - { 6, 0x68, { 0x08, 0x00, 0x01, 0x00, 0x00, 0x00 } }, + {6, 0x68, {0x08, 0x00, 0x01, 0x00, 0x00, 0x00} }, /* Boot Settings */ - { 6, 0x68, { 0x10, 0x00, 0x78, 0x69, 0x00, 0x00 } }, - { 6, 0x68, { 0x10, 0x04, 0x02, 0x08, 0x02, 0x00 } }, - { 6, 0x68, { 0x10, 0x08, 0x22, 0x00, 0xA0, 0x02 } }, - { 6, 0x68, { 0x10, 0x0C, 0x50, 0x04, 0x00, 0x03 } }, - { 6, 0x68, { 0x10, 0x10, 0x10, 0x0D, 0x06, 0x01 } }, - { 6, 0x68, { 0x10, 0x14, 0x01, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x10, 0x18, 0xFF, 0xFF, 0xFF, 0xFF } }, + {6, 0x68, {0x10, 0x00, 0x78, 0x69, 0x00, 0x00} }, + {6, 0x68, {0x10, 0x04, 0x02, 0x08, 0x02, 0x00} }, + {6, 0x68, {0x10, 0x08, 0x22, 0x00, 0xA0, 0x02} }, + {6, 0x68, {0x10, 0x0C, 0x50, 0x04, 0x00, 0x03} }, + {6, 0x68, {0x10, 0x10, 0x10, 0x0D, 0x06, 0x01} }, + {6, 0x68, {0x10, 0x14, 0x01, 0x00, 0x00, 0x00} }, + {6, 0x68, {0x10, 0x18, 0xFF, 0xFF, 0xFF, 0xFF} }, /* Internal PCLK settings for Non Present or REFCLK=26MHz */ - { 3, 0x68, { 0xB0, 0x05, 0x0A, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB0, 0x06, 0x03, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB0, 0x07, 0x16, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB0, 0x08, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB0, 0x09, 0x21, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB0, 0x0A, 0x07, 0x00, 0x00, 0x00 } }, + {3, 0x68, {0xB0, 0x05, 0x0A, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB0, 0x06, 0x03, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB0, 0x07, 0x16, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB0, 0x08, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB0, 0x09, 0x21, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB0, 0x0A, 0x07, 0x00, 0x00, 0x00} }, /* DSI Clock setting for Non Preset or REFCLK=26MHz */ - { 6, 0x68, { 0x41, 0xB0, 0xC1, 0x22, 0x04, 0x00 } }, - { 6, 0x68, { 0x41, 0xBC, 0x01, 0x0E, 0x00, 0x00 } }, - { 6, 0x68, { 0x41, 0xC0, 0x30, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x10, 0x14, 0x03, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x10, 0x18, 0xFF, 0xFF, 0xFF, 0xFF } }, + {6, 0x68, {0x41, 0xB0, 0xC1, 0x22, 0x04, 0x00} }, + {6, 0x68, {0x41, 0xBC, 0x01, 0x0E, 0x00, 0x00} }, + {6, 0x68, {0x41, 0xC0, 0x30, 0x00, 0x00, 0x00} }, + {6, 0x68, {0x10, 0x14, 0x03, 0x00, 0x00, 0x00} }, + {6, 0x68, {0x10, 0x18, 0xFF, 0xFF, 0xFF, 0xFF} }, /* Additional Settng for eDP */ - { 3, 0x68, { 0x80, 0x03, 0x41, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB4, 0x00, 0x0D, 0x00, 0x00, 0x00 } }, + {3, 0x68, {0x80, 0x03, 0x41, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB4, 0x00, 0x0D, 0x00, 0x00, 0x00} }, /* DPRX CAD Register Setting */ - { 3, 0x68, { 0xB8, 0x8E, 0xFF, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x8F, 0xFF, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x9A, 0xFF, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x9B, 0xFF, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x00, 0x0E, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x26, 0x02, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x01, 0x20, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0xC0, 0xF1, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0xC1, 0xF1, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0xC2, 0xF0, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0xC3, 0xF0, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0xC4, 0xF0, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0xC5, 0xF0, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0xC6, 0xF0, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0xC7, 0xF0, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x0B, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x33, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x5B, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x10, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x38, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x60, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x15, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x3D, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x65, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x1A, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x42, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x6A, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x1F, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x47, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x6F, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x24, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x4C, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x74, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x29, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x51, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x79, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x2E, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x56, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x7E, 0x00, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x90, 0x10, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x91, 0x0F, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x92, 0xF6, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x93, 0x10, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x94, 0x0F, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x95, 0xF6, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x96, 0x10, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x97, 0x0F, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x98, 0xF6, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x99, 0x10, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x9A, 0x0F, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0x9B, 0xF6, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x8A, 0x03, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x96, 0x03, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0xD1, 0x07, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xBB, 0xB0, 0x07, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x8B, 0x04, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x8C, 0x45, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x8D, 0x05, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x97, 0x04, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x98, 0xE0, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x99, 0x2E, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0x80, 0x0E, 0x00, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x10, 0x14, 0x07, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x10, 0x18, 0xFF, 0xFF, 0xFF, 0xFF } }, + {3, 0x68, {0xB8, 0x8E, 0xFF, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x8F, 0xFF, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x9A, 0xFF, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x9B, 0xFF, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x00, 0x0E, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xBB, 0x26, 0x02, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xBB, 0x01, 0x20, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0xC0, 0xF1, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0xC1, 0xF1, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0xC2, 0xF0, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0xC3, 0xF0, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0xC4, 0xF0, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0xC5, 0xF0, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0xC6, 0xF0, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0xC7, 0xF0, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x0B, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x33, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x5B, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x10, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x38, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x60, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x15, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x3D, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x65, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x1A, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x42, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x6A, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x1F, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x47, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x6F, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x24, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x4C, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x74, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x29, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x51, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x79, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x2E, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x56, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x7E, 0x00, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xBB, 0x90, 0x10, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xBB, 0x91, 0x0F, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xBB, 0x92, 0xF6, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xBB, 0x93, 0x10, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xBB, 0x94, 0x0F, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xBB, 0x95, 0xF6, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xBB, 0x96, 0x10, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xBB, 0x97, 0x0F, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xBB, 0x98, 0xF6, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xBB, 0x99, 0x10, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xBB, 0x9A, 0x0F, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xBB, 0x9B, 0xF6, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x8A, 0x03, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x96, 0x03, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xBB, 0xD1, 0x07, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xBB, 0xB0, 0x07, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x8B, 0x04, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x8C, 0x45, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x8D, 0x05, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x97, 0x04, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x98, 0xE0, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x99, 0x2E, 0x00, 0x00, 0x00} }, + {3, 0x68, {0x80, 0x0E, 0x00, 0x00, 0x00, 0x00} }, + {6, 0x68, {0x10, 0x14, 0x07, 0x00, 0x00, 0x00} }, + {6, 0x68, {0x10, 0x18, 0xFF, 0xFF, 0xFF, 0xFF} }, /* Video size Related Settings for Non Present */ - { 6, 0x68, { 0x01, 0x48, 0xB0, 0x04, 0x00, 0x00 } }, - { 6, 0x68, { 0x29, 0x20, 0x10, 0x0E, 0x0B, 0x3E } }, + {6, 0x68, {0x01, 0x48, 0xB0, 0x04, 0x00, 0x00} }, + {6, 0x68, {0x29, 0x20, 0x10, 0x0E, 0x0B, 0x3E} }, /* eDP Settings for Link Training*/ - { 3, 0x68, { 0xB6, 0x31, 0xFF, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0x80, 0x01, 0x14, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0x80, 0x02, 0x02, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB6, 0x08, 0x0B, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0xB8, 0x00, 0x1E, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0x87, 0x00, 0x00, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x50, 0x10, 0x00, 0x00, 0x9D, 0x00 } }, - { 6, 0x68, { 0x00, 0x8C, 0x40, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x00, 0x80, 0x02, 0x00, 0x00, 0x00 } }, + {3, 0x68, {0xB6, 0x31, 0xFF, 0x00, 0x00, 0x00} }, + {3, 0x68, {0x80, 0x01, 0x14, 0x00, 0x00, 0x00} }, + {3, 0x68, {0x80, 0x02, 0x02, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB6, 0x08, 0x0B, 0x00, 0x00, 0x00} }, + {3, 0x68, {0xB8, 0x00, 0x1E, 0x00, 0x00, 0x00} }, + {3, 0x68, {0x87, 0x00, 0x00, 0x00, 0x00, 0x00} }, + {6, 0x68, {0x50, 0x10, 0x00, 0x00, 0x9D, 0x00} }, + {6, 0x68, {0x00, 0x8C, 0x40, 0x00, 0x00, 0x00} }, + {6, 0x68, {0x00, 0x80, 0x02, 0x00, 0x00, 0x00} }, /* Link Training */ - { 3, 0x68, { 0x82, 0x02, 0xFF, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0x82, 0x03, 0xFF, 0x00, 0x00, 0x00 } }, - { 3, 0x68, { 0x82, 0x04, 0xFF, 0x00, 0x00, 0x00 } }, + {3, 0x68, {0x82, 0x02, 0xFF, 0x00, 0x00, 0x00} }, + {3, 0x68, {0x82, 0x03, 0xFF, 0x00, 0x00, 0x00} }, + {3, 0x68, {0x82, 0x04, 0xFF, 0x00, 0x00, 0x00} }, /* DSI Transition Time Setting for Non Preset */ - { 6, 0x68, { 0x21, 0x54, 0x0D, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x21, 0x58, 0x06, 0x00, 0x2A, 0x00 } }, - { 6, 0x68, { 0x21, 0x5C, 0x07, 0x00, 0x0E, 0x00 } }, - { 6, 0x68, { 0x21, 0x60, 0x07, 0x00, 0x10, 0x00 } }, - { 6, 0x68, { 0x21, 0x64, 0x10, 0x27, 0x00, 0x00 } }, - { 6, 0x68, { 0x21, 0x68, 0x0E, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x21, 0x6C, 0x0A, 0x00, 0x0E, 0x00 } }, - { 6, 0x68, { 0x21, 0x78, 0x0E, 0x00, 0x0D, 0x00 } }, + {6, 0x68, {0x21, 0x54, 0x0D, 0x00, 0x00, 0x00} }, + {6, 0x68, {0x21, 0x58, 0x06, 0x00, 0x2A, 0x00} }, + {6, 0x68, {0x21, 0x5C, 0x07, 0x00, 0x0E, 0x00} }, + {6, 0x68, {0x21, 0x60, 0x07, 0x00, 0x10, 0x00} }, + {6, 0x68, {0x21, 0x64, 0x10, 0x27, 0x00, 0x00} }, + {6, 0x68, {0x21, 0x68, 0x0E, 0x00, 0x00, 0x00} }, + {6, 0x68, {0x21, 0x6C, 0x0A, 0x00, 0x0E, 0x00} }, + {6, 0x68, {0x21, 0x78, 0x0E, 0x00, 0x0D, 0x00} }, /* DSI Start */ - { 6, 0x68, { 0x20, 0x7C, 0x81, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x20, 0x50, 0x00, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x20, 0x1C, 0x01, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x20, 0x60, 0xFF, 0xFF, 0xFF, 0xFF } }, + {6, 0x68, {0x20, 0x7C, 0x81, 0x00, 0x00, 0x00} }, + {6, 0x68, {0x20, 0x50, 0x00, 0x00, 0x00, 0x00} }, + {6, 0x68, {0x20, 0x1C, 0x01, 0x00, 0x00, 0x00} }, + {6, 0x68, {0x20, 0x60, 0xFF, 0xFF, 0xFF, 0xFF} }, /* GPIO for LCD control*/ - { 6, 0x68, { 0x08, 0x04, 0x00, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x00, 0x80, 0x0F, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x00, 0x84, 0x0F, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x00, 0x84, 0x00, 0x00, 0x00, 0x00 } }, - { 6, 0x68, { 0x00, 0x84, 0x0F, 0x00, 0x00, 0x00 } }, + {6, 0x68, {0x08, 0x04, 0x00, 0x00, 0x00, 0x00} }, + {6, 0x68, {0x00, 0x80, 0x0F, 0x00, 0x00, 0x00} }, + {6, 0x68, {0x00, 0x84, 0x0F, 0x00, 0x00, 0x00} }, + {6, 0x68, {0x00, 0x84, 0x00, 0x00, 0x00, 0x00} }, + {6, 0x68, {0x00, 0x84, 0x0F, 0x00, 0x00, 0x00} }, /* DSI Hs Clock Mode */ - { 6, 0x68, { 0x20, 0x50, 0x20, 0x00, 0x00, 0x00 } }, + {6, 0x68, {0x20, 0x50, 0x20, 0x00, 0x00, 0x00} }, /* LCD Initialization */ - { 6, 0x68, { 0x22, 0xFC, 0x15, 0xBF, 0xA5, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x15, 0x01, 0x00, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x15, 0x8F, 0xA5, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x15, 0x83, 0xAA, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x15, 0x84, 0x11, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x15, 0xA9, 0x48, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x15, 0x83, 0x00, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x15, 0x84, 0x00, 0x81 } }, - { 6, 0x68, { 0x22, 0xFC, 0x15, 0x8F, 0x00, 0x81 } }, - { 6, 0x68, { 0x2A, 0x10, 0x10, 0x00, 0x04, 0x80 } }, - { 6, 0x68, { 0x2A, 0x04, 0x01, 0x00, 0x00, 0x00 } }, + {6, 0x68, {0x22, 0xFC, 0x15, 0xBF, 0xA5, 0x81} }, + {6, 0x68, {0x22, 0xFC, 0x15, 0x01, 0x00, 0x81} }, + {6, 0x68, {0x22, 0xFC, 0x15, 0x8F, 0xA5, 0x81} }, + {6, 0x68, {0x22, 0xFC, 0x15, 0x83, 0xAA, 0x81} }, + {6, 0x68, {0x22, 0xFC, 0x15, 0x84, 0x11, 0x81} }, + {6, 0x68, {0x22, 0xFC, 0x15, 0xA9, 0x48, 0x81} }, + {6, 0x68, {0x22, 0xFC, 0x15, 0x83, 0x00, 0x81} }, + {6, 0x68, {0x22, 0xFC, 0x15, 0x84, 0x00, 0x81} }, + {6, 0x68, {0x22, 0xFC, 0x15, 0x8F, 0x00, 0x81} }, + {6, 0x68, {0x2A, 0x10, 0x10, 0x00, 0x04, 0x80} }, + {6, 0x68, {0x2A, 0x04, 0x01, 0x00, 0x00, 0x00} }, /* Check if eDP video is coming */ - { 6, 0x68, { 0x01, 0x54, 0x01, 0x00, 0x00, 0x00 } }, + {6, 0x68, {0x01, 0x54, 0x01, 0x00, 0x00, 0x00} }, /* End of table */ - { 0, 0x00, { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 } }, + {0, 0x00, {0x00, 0x00, 0x00, 0x00, 0x00, 0x00} }, };
static void mainboard_configure_edp_bridge(void) @@ -341,8 +341,8 @@ loops = 5; do { status = smbus_i2c_block_write(edptable->address, - edptable->payload_length, - (u8 *)&edptable->data[0]); + edptable->payload_length, + (u8 *)&edptable->data[0]); } while (--loops && (status < 0));
if (loops == 0) { diff --git a/src/mainboard/facebook/fbg1701/romstage.c b/src/mainboard/facebook/fbg1701/romstage.c index 879cc9a..2b3a0e7 100644 --- a/src/mainboard/facebook/fbg1701/romstage.c +++ b/src/mainboard/facebook/fbg1701/romstage.c @@ -30,7 +30,7 @@ #include <stdint.h>
void mainboard_memory_init_params(struct romstage_params *params, - MEMORY_INIT_UPD *memory_params) + MEMORY_INIT_UPD *memory_params) { struct region_device spd_rdev; u8 spd_index = 0; @@ -68,8 +68,8 @@ */
static const uint8_t crtm_version[] = - CONFIG_VENDORCODE_ELTAN_CRTM_VERSION_STRING - COREBOOT_VERSION COREBOOT_EXTRA_VERSION " " COREBOOT_BUILD; + CONFIG_VENDORCODE_ELTAN_CRTM_VERSION_STRING COREBOOT_VERSION COREBOOT_EXTRA_VERSION + " " COREBOOT_BUILD;
int mb_crtm(EFI_TCG2_EVENT_ALGORITHM_BITMAP activePcr) { @@ -79,18 +79,16 @@ /* Use FirmwareVersion string to represent CRTM version. */ printk(BIOS_DEBUG, "%s: Measure CRTM Version\n", __func__); memset(&tcgEventHdr, 0, sizeof(tcgEventHdr)); - tcgEventHdr.pcrIndex = MBOOT_PCR_INDEX_0; + tcgEventHdr.pcrIndex = MBOOT_PCR_INDEX_0; tcgEventHdr.eventType = EV_S_CRTM_VERSION; tcgEventHdr.eventSize = sizeof(crtm_version); - printk(BIOS_DEBUG, "%s: EventSize - %u\n", __func__, - tcgEventHdr.eventSize); + printk(BIOS_DEBUG, "%s: EventSize - %u\n", __func__, tcgEventHdr.eventSize);
status = mboot_hash_extend_log(activePcr, 0, (uint8_t *)crtm_version, tcgEventHdr.eventSize, &tcgEventHdr, (uint8_t *)crtm_version, 0); if (status) { - printk(BIOS_DEBUG, "Measure CRTM Version returned 0x%x\n", - status); + printk(BIOS_DEBUG, "Measure CRTM Version returned 0x%x\n", status); }
return status;
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35963 )
Change subject: mb/facebook/fbg1701: correct clang issues ......................................................................
Patch Set 5:
(2 comments)
The result is a little strange.
https://review.coreboot.org/c/coreboot/+/35963/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35963/5//COMMIT_MSG@7 PS5, Line 7: mb/facebook/fbg1701: correct clang issues clang format?
https://review.coreboot.org/c/coreboot/+/35963/5/src/mainboard/facebook/fbg1... File src/mainboard/facebook/fbg1701/ramstage.c:
https://review.coreboot.org/c/coreboot/+/35963/5/src/mainboard/facebook/fbg1... PS5, Line 34: {6, 0x68, {0x08, 0x00, 0x01, 0x00, 0x00, 0x00} }, The unsymmetric space looks strange.
-
build bot (Jenkins) (Code Review) -
Frans Hendriks (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Wim Vervoorn (Code Review)