Eric Lai has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69683 )
Change subject: mb/google/nissa: Modify FMD to redistribute buffer ......................................................................
mb/google/nissa: Modify FMD to redistribute buffer
Modify the chromeos FMD file for nissa variants to redistribute the buffer in SI_ME region obtained due to CSE size optimizations to SI_BIOS region.
1. Modify SI_ALL region size to 3712K. SI_DESC remains at 4K and SI_ME is 3708K. 2. Modify SI_BIOS region to 12672K. This results in an addition of 32K buffer each to FW_MAIN_A/B regions.
BUG=b:228936671 BRANCH=firmware-nissa-15217.B TEST=Verify CSE FW update with new FMD and ME RW blobs on craask.
Cq-Depend: chrome-internal:5094491 Change-Id: I5ead2f81850a2aa79e677c7f271db672e235750a Signed-off-by: Krishna P Bhat D krishna.p.bhat.d@intel.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/69683 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Reka Norman rekanorman@chromium.org Reviewed-by: Eric Lai eric_lai@quanta.corp-partner.google.com --- M src/mainboard/google/brya/chromeos-nissa-16MiB-debugfsp.fmd M src/mainboard/google/brya/chromeos-nissa-16MiB.fmd M src/mainboard/google/brya/chromeos-nissa-32MiB.fmd 3 files changed, 42 insertions(+), 14 deletions(-)
Approvals: build bot (Jenkins): Verified Reka Norman: Looks good to me, approved Eric Lai: Looks good to me, approved
diff --git a/src/mainboard/google/brya/chromeos-nissa-16MiB-debugfsp.fmd b/src/mainboard/google/brya/chromeos-nissa-16MiB-debugfsp.fmd index a6da8d1..ee92f2a 100644 --- a/src/mainboard/google/brya/chromeos-nissa-16MiB-debugfsp.fmd +++ b/src/mainboard/google/brya/chromeos-nissa-16MiB-debugfsp.fmd @@ -1,10 +1,10 @@ FLASH 16M { - SI_ALL 3776K { + SI_ALL 3712K { SI_DESC 4K SI_ME } - SI_BIOS 12608K { - RW_SECTION_A 4180K { + SI_BIOS 12672K { + RW_SECTION_A 4212K { VBLOCK_A 8K FW_MAIN_A(CBFS) RW_FWID_A 64 @@ -22,7 +22,7 @@ RW_VPD(PRESERVE) 8K RW_NVRAM(PRESERVE) 8K } - RW_SECTION_B 4180K { + RW_SECTION_B 4212K { VBLOCK_B 8K FW_MAIN_B(CBFS) RW_FWID_B 64 diff --git a/src/mainboard/google/brya/chromeos-nissa-16MiB.fmd b/src/mainboard/google/brya/chromeos-nissa-16MiB.fmd index f4f9d31..af69207 100644 --- a/src/mainboard/google/brya/chromeos-nissa-16MiB.fmd +++ b/src/mainboard/google/brya/chromeos-nissa-16MiB.fmd @@ -1,10 +1,10 @@ FLASH 16M { - SI_ALL 3776K { + SI_ALL 3712K { SI_DESC 4K SI_ME } - SI_BIOS 12608K { - RW_SECTION_A 3668K { + SI_BIOS 12672K { + RW_SECTION_A 3700K { VBLOCK_A 8K FW_MAIN_A(CBFS) RW_FWID_A 64 @@ -23,7 +23,7 @@ RW_VPD(PRESERVE) 8K RW_NVRAM(PRESERVE) 8K } - RW_SECTION_B 3668K { + RW_SECTION_B 3700K { VBLOCK_B 8K FW_MAIN_B(CBFS) RW_FWID_B 64 diff --git a/src/mainboard/google/brya/chromeos-nissa-32MiB.fmd b/src/mainboard/google/brya/chromeos-nissa-32MiB.fmd index 48406b9..1662600 100644 --- a/src/mainboard/google/brya/chromeos-nissa-32MiB.fmd +++ b/src/mainboard/google/brya/chromeos-nissa-32MiB.fmd @@ -1,10 +1,10 @@ FLASH 32M { - SI_ALL 3776K { + SI_ALL 3712K { SI_DESC 4K SI_ME } - SI_BIOS 28992K { - RW_SECTION_A 4344K { + SI_BIOS 29056K { + RW_SECTION_A 4376K { VBLOCK_A 8K FW_MAIN_A(CBFS) RW_FWID_A 64 @@ -24,19 +24,19 @@ RW_NVRAM(PRESERVE) 8K } # RW UNUSED Region 1. - RW_UNUSED_1 7088K + RW_UNUSED_1 7120K # This section starts at the 16M boundary in SPI flash. # ADL does not support a region crossing this boundary, # because the SPI flash is memory-mapped into two non- # contiguous windows. - RW_SECTION_B 4344K { + RW_SECTION_B 4376K { VBLOCK_B 8K FW_MAIN_B(CBFS) RW_FWID_B 64 ME_RW_B(CBFS) 1434K } # RW UNUSED Region 2. - RW_UNUSED_2 7944K + RW_UNUSED_2 7912K # Make WP_RO region align with SPI vendor # memory protected range specification. WP_RO 4M {