Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36087 )
Change subject: soc/intel/tigerlake: Do initial SoC commit till ramstage ......................................................................
Patch Set 17:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36087/16/src/soc/intel/tigerlake/fs... File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/36087/16/src/soc/intel/tigerlake/fs... PS16, Line 36: FSPS_UPD
not defined in any header
https://review.coreboot.org/c/coreboot/+/36243 CL should take care
https://review.coreboot.org/c/coreboot/+/36087/16/src/soc/intel/tigerlake/in... File src/soc/intel/tigerlake/include/soc/pmc.h:
https://review.coreboot.org/c/coreboot/+/36087/16/src/soc/intel/tigerlake/in... PS16, Line 16: _SOC_ICELAKE_PMC_H_
_SOC_TIGERLAKE_PMC_H_?
thanks for catching this, it was a mistake during last rebase