Peter Lemenkov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43905 )
Change subject: intelvbttool: small typos ......................................................................
intelvbttool: small typos
Change-Id: Id6298883c39c21179b13696dab630818b81026ff Signed-off-by: Peter Lemenkov lemenkov@gmail.com --- M util/intelvbttool/intelvbttool.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/43905/1
diff --git a/util/intelvbttool/intelvbttool.c b/util/intelvbttool/intelvbttool.c index 7d23c86..c8d7a08 100644 --- a/util/intelvbttool/intelvbttool.c +++ b/util/intelvbttool/intelvbttool.c @@ -736,7 +736,7 @@ *vbt = NULL;
if (fo->size < sizeof(struct vbt_header)) { - printerr("image is to small\n"); + printerr("image is too small\n"); return; }
@@ -810,12 +810,12 @@ static int is_valid_vbios(const struct fileobject *fo) { if (fo->size > 64 * 2 * KiB) { - printerr("VBIOS is to big\n"); + printerr("VBIOS is too big\n"); return 0; }
if (fo->size < sizeof(optionrom_header_t)) { - printerr("VBIOS is to small\n"); + printerr("VBIOS is too small\n"); return 0; }
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43905 )
Change subject: intelvbttool: small typos ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/43905/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43905/1//COMMIT_MSG@7 PS1, Line 7: small typos Fix some typos
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43905
to look at the new patch set (#2).
Change subject: intelvbttool: Fix some typos ......................................................................
intelvbttool: Fix some typos
Change-Id: Id6298883c39c21179b13696dab630818b81026ff Signed-off-by: Peter Lemenkov lemenkov@gmail.com --- M util/intelvbttool/intelvbttool.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/43905/2
Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43905 )
Change subject: intelvbttool: Fix some typos ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43905/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43905/1//COMMIT_MSG@7 PS1, Line 7: small typos
Fix some typos
Done
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43905 )
Change subject: intelvbttool: Fix some typos ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/43905/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43905/2//COMMIT_MSG@7 PS2, Line 7: intelvbttool: Fix some typos
… in error messages
(So, it’s clear, it won’t result in a “functional” change.)
Hello build bot (Jenkins), Paul Menzel, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43905
to look at the new patch set (#3).
Change subject: intelvbttool: Fix some typos in error messages ......................................................................
intelvbttool: Fix some typos in error messages
Change-Id: Id6298883c39c21179b13696dab630818b81026ff Signed-off-by: Peter Lemenkov lemenkov@gmail.com --- M util/intelvbttool/intelvbttool.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/43905/3
Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43905 )
Change subject: intelvbttool: Fix some typos in error messages ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43905/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43905/1//COMMIT_MSG@7 PS1, Line 7: small typos
Done
Done
https://review.coreboot.org/c/coreboot/+/43905/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43905/2//COMMIT_MSG@7 PS2, Line 7: intelvbttool: Fix some typos
… in error messages […]
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43905 )
Change subject: intelvbttool: Fix some typos in error messages ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43905 )
Change subject: intelvbttool: Fix some typos in error messages ......................................................................
intelvbttool: Fix some typos in error messages
Change-Id: Id6298883c39c21179b13696dab630818b81026ff Signed-off-by: Peter Lemenkov lemenkov@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43905 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/intelvbttool/intelvbttool.c 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/util/intelvbttool/intelvbttool.c b/util/intelvbttool/intelvbttool.c index 7d23c86..c8d7a08 100644 --- a/util/intelvbttool/intelvbttool.c +++ b/util/intelvbttool/intelvbttool.c @@ -736,7 +736,7 @@ *vbt = NULL;
if (fo->size < sizeof(struct vbt_header)) { - printerr("image is to small\n"); + printerr("image is too small\n"); return; }
@@ -810,12 +810,12 @@ static int is_valid_vbios(const struct fileobject *fo) { if (fo->size > 64 * 2 * KiB) { - printerr("VBIOS is to big\n"); + printerr("VBIOS is too big\n"); return 0; }
if (fo->size < sizeof(optionrom_header_t)) { - printerr("VBIOS is to small\n"); + printerr("VBIOS is too small\n"); return 0; }
-
Angel Pons (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Peter Lemenkov (Code Review)