Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53933 )
Change subject: soc/amd/picasso: Disable CBFS MCACHE again ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: Did this ever work and break again or was it just broken the whole time?
The error message looks like the mcache just wasn't transferred correctly from PSP memory to DRAM. Please check the transfer logic (e.g. hexdump _cbfs_mcache at the end of the PSP execution and right before this assertion, they should be the same but they probably aren't). Or maybe you're trying to make a CBFS access before the code copying the transfer buffer into DRAM runs? (Interestingly, the FMAP access before that runs fine. Are you using FMAP_CACHE? If so, that would suggest that the FMAP cache was transferred correctly already...)
-
Julius Werner (Code Review)