Attention is currently required from: Felix Singer.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/84858?usp=email )
Change subject: acpi/acpi.h: Use boolean
......................................................................
Patch Set 6:
(1 comment)
File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/84858/comment/4143d682_cfe247f2?usp... :
PS3, Line 1981: static inline int acpi_is_wakeup_s3(void)
this one, needs some work
this needs to use boolean for s3resume ....
please see
https://review.coreboot.org/c/coreboot/+/86331
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84858?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8f390bf3b472519dc41db7daa57b16458961139e
Gerrit-Change-Number: 84858
Gerrit-PatchSet: 6
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Comment-Date: Sat, 08 Feb 2025 11:22:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr