HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36082 )
Change subject: src: Remove unused 'include <string.h>' ......................................................................
src: Remove unused 'include <string.h>'
Change-Id: I2a94c3b6282e9915fd2b8136b124740c8a7b774c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/riscv/fit_payload.c M src/device/oprom/realmode/x86_interrupts.c M src/device/oprom/x86emu/sys.c M src/device/oprom/x86emu/x86emui.h M src/device/oprom/yabel/compat/functions.c M src/mainboard/google/auron/romstage.c M src/mainboard/google/butterfly/chromeos.c M src/mainboard/google/daisy/chromeos.c M src/mainboard/google/foster/chromeos.c M src/mainboard/google/jecht/romstage.c M src/mainboard/google/kukui/panel_ps8640.c M src/mainboard/google/link/chromeos.c M src/mainboard/google/parrot/chromeos.c M src/mainboard/google/peach_pit/chromeos.c M src/mainboard/google/stout/chromeos.c M src/mainboard/intel/baskingridge/chromeos.c M src/mainboard/intel/emeraldlake2/chromeos.c M src/mainboard/intel/saddlebrook/romstage.c M src/mainboard/intel/wtm2/romstage.c M src/mainboard/purism/librem_bdw/romstage.c M src/mainboard/razer/blade_stealth_kbl/romstage.c M src/mainboard/samsung/lumpy/chromeos.c M src/mainboard/samsung/stumpy/chromeos.c M src/mainboard/up/squared/ramstage.c M src/soc/amd/common/block/spi/fch_spi_special.c M src/soc/intel/cannonlake/reset.c M src/soc/intel/common/block/sgx/sgx.c M src/soc/intel/icelake/reset.c M src/soc/intel/skylake/me.c M src/soc/mediatek/mt8173/i2c.c M src/soc/mediatek/mt8183/ddp.c M src/soc/mediatek/mt8183/include/soc/spm.h M src/soc/qualcomm/qcs405/clock.c M src/soc/qualcomm/qcs405/spi.c M src/soc/qualcomm/sdm845/aop_load_reset.c M src/superio/aspeed/ast2400/superio.c 36 files changed, 0 insertions(+), 36 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/36082/1
diff --git a/src/arch/riscv/fit_payload.c b/src/arch/riscv/fit_payload.c index 60a4bc0..78e95fd 100644 --- a/src/arch/riscv/fit_payload.c +++ b/src/arch/riscv/fit_payload.c @@ -18,7 +18,6 @@ #include <bootmem.h> #include <stdlib.h> #include <program_loading.h> -#include <string.h> #include <commonlib/compression.h> #include <commonlib/cbfs_serialized.h> #include <lib.h> diff --git a/src/device/oprom/realmode/x86_interrupts.c b/src/device/oprom/realmode/x86_interrupts.c index 4e1c5ed..c38da46 100644 --- a/src/device/oprom/realmode/x86_interrupts.c +++ b/src/device/oprom/realmode/x86_interrupts.c @@ -15,7 +15,6 @@ #include <console/console.h> #include <device/pci.h> #include <device/pci_ops.h> -#include <string.h>
/* we use x86emu's register file representation */ #include <x86emu/regs.h> diff --git a/src/device/oprom/x86emu/sys.c b/src/device/oprom/x86emu/sys.c index 9c293bc..06f240c 100644 --- a/src/device/oprom/x86emu/sys.c +++ b/src/device/oprom/x86emu/sys.c @@ -50,7 +50,6 @@ #ifdef IN_MODULE #include "xf86_ansic.h" #else -#include <string.h> #endif /*------------------------- Global Variables ------------------------------*/
diff --git a/src/device/oprom/x86emu/x86emui.h b/src/device/oprom/x86emu/x86emui.h index 741153c..b1647c5 100644 --- a/src/device/oprom/x86emu/x86emui.h +++ b/src/device/oprom/x86emu/x86emui.h @@ -72,7 +72,6 @@ #ifdef IN_MODULE #include <xf86_ansic.h> #else -#include <string.h> #endif /*--------------------------- Inline Functions ----------------------------*/
diff --git a/src/device/oprom/yabel/compat/functions.c b/src/device/oprom/yabel/compat/functions.c index fa1b6b7..c9e2e4c 100644 --- a/src/device/oprom/yabel/compat/functions.c +++ b/src/device/oprom/yabel/compat/functions.c @@ -36,7 +36,6 @@ */
#include <types.h> -#include <string.h> #include <device/device.h> #include "../debug.h" #include "../biosemu.h" diff --git a/src/mainboard/google/auron/romstage.c b/src/mainboard/google/auron/romstage.c index 568c4c8..d5687f2 100644 --- a/src/mainboard/google/auron/romstage.c +++ b/src/mainboard/google/auron/romstage.c @@ -15,7 +15,6 @@ */
#include <console/console.h> -#include <string.h> #include <ec/google/chromeec/ec.h> #include <soc/pei_data.h> #include <soc/pei_wrapper.h> diff --git a/src/mainboard/google/butterfly/chromeos.c b/src/mainboard/google/butterfly/chromeos.c index 1f5939e..ea4b8ac 100644 --- a/src/mainboard/google/butterfly/chromeos.c +++ b/src/mainboard/google/butterfly/chromeos.c @@ -14,7 +14,6 @@ */
#include <console/console.h> -#include <string.h> #include <bootmode.h> #include <boot/coreboot_tables.h> #include <device/device.h> diff --git a/src/mainboard/google/daisy/chromeos.c b/src/mainboard/google/daisy/chromeos.c index 974cd49..3525a98 100644 --- a/src/mainboard/google/daisy/chromeos.c +++ b/src/mainboard/google/daisy/chromeos.c @@ -18,7 +18,6 @@ #include <ec/google/chromeec/ec_commands.h> #include <soc/cpu.h> #include <soc/gpio.h> -#include <string.h> #include <vendorcode/google/chromeos/chromeos.h> #include <bootmode.h>
diff --git a/src/mainboard/google/foster/chromeos.c b/src/mainboard/google/foster/chromeos.c index 7ce1300..e14fbcb 100644 --- a/src/mainboard/google/foster/chromeos.c +++ b/src/mainboard/google/foster/chromeos.c @@ -18,7 +18,6 @@ #include <ec/google/chromeec/ec.h> #include <ec/google/chromeec/ec_commands.h> #include <gpio.h> -#include <string.h> #include <vendorcode/google/chromeos/chromeos.h>
void fill_lb_gpios(struct lb_gpios *gpios) diff --git a/src/mainboard/google/jecht/romstage.c b/src/mainboard/google/jecht/romstage.c index 4fc2ba0c..4e32ab2 100644 --- a/src/mainboard/google/jecht/romstage.c +++ b/src/mainboard/google/jecht/romstage.c @@ -16,7 +16,6 @@
#include <bootmode.h> #include <console/console.h> -#include <string.h> #include <ec/google/chromeec/ec.h> #include <soc/pei_data.h> #include <soc/pei_wrapper.h> diff --git a/src/mainboard/google/kukui/panel_ps8640.c b/src/mainboard/google/kukui/panel_ps8640.c index 83358d3..6381228 100644 --- a/src/mainboard/google/kukui/panel_ps8640.c +++ b/src/mainboard/google/kukui/panel_ps8640.c @@ -19,7 +19,6 @@ #include <edid.h> #include <gpio.h> #include <soc/i2c.h> -#include <string.h>
#include "panel.h"
diff --git a/src/mainboard/google/link/chromeos.c b/src/mainboard/google/link/chromeos.c index a5370be..44a2bf5 100644 --- a/src/mainboard/google/link/chromeos.c +++ b/src/mainboard/google/link/chromeos.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <string.h> #include <bootmode.h> #include <boot/coreboot_tables.h> #include <southbridge/intel/bd82x6x/pch.h> diff --git a/src/mainboard/google/parrot/chromeos.c b/src/mainboard/google/parrot/chromeos.c index 4adcdb6..4587a12 100644 --- a/src/mainboard/google/parrot/chromeos.c +++ b/src/mainboard/google/parrot/chromeos.c @@ -14,7 +14,6 @@ */
#include <console/console.h> -#include <string.h> #include <bootmode.h> #include <boot/coreboot_tables.h> #include <device/pci_ops.h> diff --git a/src/mainboard/google/peach_pit/chromeos.c b/src/mainboard/google/peach_pit/chromeos.c index 8bd35be..f2b1e8c 100644 --- a/src/mainboard/google/peach_pit/chromeos.c +++ b/src/mainboard/google/peach_pit/chromeos.c @@ -19,7 +19,6 @@ #include <ec/google/chromeec/ec_commands.h> #include <soc/cpu.h> #include <soc/gpio.h> -#include <string.h> #include <vendorcode/google/chromeos/chromeos.h>
void fill_lb_gpios(struct lb_gpios *gpios) diff --git a/src/mainboard/google/stout/chromeos.c b/src/mainboard/google/stout/chromeos.c index 0914450..dc3f3ab 100644 --- a/src/mainboard/google/stout/chromeos.c +++ b/src/mainboard/google/stout/chromeos.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <string.h> #include <bootmode.h> #include <boot/coreboot_tables.h> #include <device/pci_ops.h> diff --git a/src/mainboard/intel/baskingridge/chromeos.c b/src/mainboard/intel/baskingridge/chromeos.c index 2d5919c..74eb788 100644 --- a/src/mainboard/intel/baskingridge/chromeos.c +++ b/src/mainboard/intel/baskingridge/chromeos.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <string.h> #include <bootmode.h> #include <boot/coreboot_tables.h> #include <device/device.h> diff --git a/src/mainboard/intel/emeraldlake2/chromeos.c b/src/mainboard/intel/emeraldlake2/chromeos.c index 4fb512a..470688f 100644 --- a/src/mainboard/intel/emeraldlake2/chromeos.c +++ b/src/mainboard/intel/emeraldlake2/chromeos.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <string.h> #include <bootmode.h> #include <boot/coreboot_tables.h> #include <device/device.h> diff --git a/src/mainboard/intel/saddlebrook/romstage.c b/src/mainboard/intel/saddlebrook/romstage.c index 46c2cdd..0ed6730 100644 --- a/src/mainboard/intel/saddlebrook/romstage.c +++ b/src/mainboard/intel/saddlebrook/romstage.c @@ -17,7 +17,6 @@
#include <console/console.h> #include <fsp/api.h> -#include <string.h> #include <soc/gpio.h> #include <soc/pm.h> #include <soc/romstage.h> diff --git a/src/mainboard/intel/wtm2/romstage.c b/src/mainboard/intel/wtm2/romstage.c index f4e3366..9edc170 100644 --- a/src/mainboard/intel/wtm2/romstage.c +++ b/src/mainboard/intel/wtm2/romstage.c @@ -16,7 +16,6 @@
#include <console/console.h> #include <stdint.h> -#include <string.h> #include <soc/gpio.h> #include <soc/pei_data.h> #include <soc/pei_wrapper.h> diff --git a/src/mainboard/purism/librem_bdw/romstage.c b/src/mainboard/purism/librem_bdw/romstage.c index 0e1ad88..72b3fe2 100644 --- a/src/mainboard/purism/librem_bdw/romstage.c +++ b/src/mainboard/purism/librem_bdw/romstage.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <string.h> #include <soc/pei_data.h> #include <soc/pei_wrapper.h> #include <soc/romstage.h> diff --git a/src/mainboard/razer/blade_stealth_kbl/romstage.c b/src/mainboard/razer/blade_stealth_kbl/romstage.c index f18e6c9..89903ab 100644 --- a/src/mainboard/razer/blade_stealth_kbl/romstage.c +++ b/src/mainboard/razer/blade_stealth_kbl/romstage.c @@ -16,7 +16,6 @@ * GNU General Public License for more details. */
-#include <string.h> #include <assert.h> #include <soc/romstage.h> #include <spd_bin.h> diff --git a/src/mainboard/samsung/lumpy/chromeos.c b/src/mainboard/samsung/lumpy/chromeos.c index 9e02d9a..c70ee1d 100644 --- a/src/mainboard/samsung/lumpy/chromeos.c +++ b/src/mainboard/samsung/lumpy/chromeos.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <string.h> #include <bootmode.h> #include <boot/coreboot_tables.h> #include <device/pci_ops.h> diff --git a/src/mainboard/samsung/stumpy/chromeos.c b/src/mainboard/samsung/stumpy/chromeos.c index f316b22..2cce8ad 100644 --- a/src/mainboard/samsung/stumpy/chromeos.c +++ b/src/mainboard/samsung/stumpy/chromeos.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <string.h> #include <bootmode.h> #include <boot/coreboot_tables.h> #include <device/pci_ops.h> diff --git a/src/mainboard/up/squared/ramstage.c b/src/mainboard/up/squared/ramstage.c index be70ea9..637b8d8 100644 --- a/src/mainboard/up/squared/ramstage.c +++ b/src/mainboard/up/squared/ramstage.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <string.h> #include <soc/ramstage.h> #include <fsp/api.h> #include <FspsUpd.h> diff --git a/src/soc/amd/common/block/spi/fch_spi_special.c b/src/soc/amd/common/block/spi/fch_spi_special.c index 456a389..fa3c00a 100644 --- a/src/soc/amd/common/block/spi/fch_spi_special.c +++ b/src/soc/amd/common/block/spi/fch_spi_special.c @@ -16,7 +16,6 @@ #include <console/console.h> #include <spi-generic.h> #include <amdblocks/fch_spi.h> -#include <string.h>
int non_standard_sst_byte_write(u32 offset, const void *buf) { diff --git a/src/soc/intel/cannonlake/reset.c b/src/soc/intel/cannonlake/reset.c index e01c22c..4758faf 100644 --- a/src/soc/intel/cannonlake/reset.c +++ b/src/soc/intel/cannonlake/reset.c @@ -19,7 +19,6 @@ #include <intelblocks/pmclib.h> #include <fsp/util.h> #include <soc/intel/common/reset.h> -#include <string.h> #include <soc/pci_devs.h>
void do_global_reset(void) diff --git a/src/soc/intel/common/block/sgx/sgx.c b/src/soc/intel/common/block/sgx/sgx.c index 377a719..b12e6cf 100644 --- a/src/soc/intel/common/block/sgx/sgx.c +++ b/src/soc/intel/common/block/sgx/sgx.c @@ -24,7 +24,6 @@ #include <intelblocks/systemagent.h> #include <soc/cpu.h> #include <soc/pci_devs.h> -#include <string.h>
static inline uint64_t sgx_resource(uint32_t low, uint32_t high) { diff --git a/src/soc/intel/icelake/reset.c b/src/soc/intel/icelake/reset.c index d83b3ee..5526a42 100644 --- a/src/soc/intel/icelake/reset.c +++ b/src/soc/intel/icelake/reset.c @@ -19,7 +19,6 @@ #include <intelblocks/pmclib.h> #include <fsp/util.h> #include <soc/intel/common/reset.h> -#include <string.h> #include <soc/pci_devs.h>
void do_global_reset(void) diff --git a/src/soc/intel/skylake/me.c b/src/soc/intel/skylake/me.c index 5a378a2..f90a165 100644 --- a/src/soc/intel/skylake/me.c +++ b/src/soc/intel/skylake/me.c @@ -24,7 +24,6 @@ #include <soc/pci_devs.h> #include <stdint.h> #include <stdlib.h> -#include <string.h>
/* HFSTS1[3:0] Current Working State Values */ diff --git a/src/soc/mediatek/mt8173/i2c.c b/src/soc/mediatek/mt8173/i2c.c index 67de335..22702d3 100644 --- a/src/soc/mediatek/mt8173/i2c.c +++ b/src/soc/mediatek/mt8173/i2c.c @@ -17,7 +17,6 @@ #include <console/console.h> #include <delay.h> #include <device/i2c_simple.h> -#include <string.h> #include <symbols.h> #include <timer.h> #include <device/mmio.h> diff --git a/src/soc/mediatek/mt8183/ddp.c b/src/soc/mediatek/mt8183/ddp.c index 0ae0be1..3c2b0fd 100644 --- a/src/soc/mediatek/mt8183/ddp.c +++ b/src/soc/mediatek/mt8183/ddp.c @@ -16,7 +16,6 @@ #include <device/mmio.h> #include <edid.h> #include <stdlib.h> -#include <string.h> #include <stddef.h> #include <soc/addressmap.h> #include <soc/ddp.h> diff --git a/src/soc/mediatek/mt8183/include/soc/spm.h b/src/soc/mediatek/mt8183/include/soc/spm.h index 4ca72b6..6ab9647 100644 --- a/src/soc/mediatek/mt8183/include/soc/spm.h +++ b/src/soc/mediatek/mt8183/include/soc/spm.h @@ -19,7 +19,6 @@ #include <arch/barrier.h> #include <console/console.h> #include <soc/addressmap.h> -#include <string.h> #include <stdint.h> #include <types.h>
diff --git a/src/soc/qualcomm/qcs405/clock.c b/src/soc/qualcomm/qcs405/clock.c index b7dd51b..37fd2c2 100644 --- a/src/soc/qualcomm/qcs405/clock.c +++ b/src/soc/qualcomm/qcs405/clock.c @@ -17,7 +17,6 @@ #include <types.h> #include <delay.h> #include <commonlib/helpers.h> -#include <string.h> #include <soc/clock.h>
#define DIV(div) (div ? (2*div - 1) : 0) diff --git a/src/soc/qualcomm/qcs405/spi.c b/src/soc/qualcomm/qcs405/spi.c index 13b9dae..827448c 100644 --- a/src/soc/qualcomm/qcs405/spi.c +++ b/src/soc/qualcomm/qcs405/spi.c @@ -35,7 +35,6 @@ #include <soc/spi.h> #include <soc/clock.h> #include <stdlib.h> -#include <string.h> #include <spi_flash.h> #include <timer.h>
diff --git a/src/soc/qualcomm/sdm845/aop_load_reset.c b/src/soc/qualcomm/sdm845/aop_load_reset.c index 02217f9..c1cf057 100644 --- a/src/soc/qualcomm/sdm845/aop_load_reset.c +++ b/src/soc/qualcomm/sdm845/aop_load_reset.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <string.h> #include <arch/cache.h> #include <cbfs.h> #include <halt.h> diff --git a/src/superio/aspeed/ast2400/superio.c b/src/superio/aspeed/ast2400/superio.c index 5ae630e..c5df8b5 100644 --- a/src/superio/aspeed/ast2400/superio.c +++ b/src/superio/aspeed/ast2400/superio.c @@ -18,7 +18,6 @@ #include <device/device.h> #include <device/pnp.h> #include <superio/conf_mode.h> -#include <string.h> #include <pc80/keyboard.h> #include <superio/common/ssdt.h> #include <arch/acpi.h>
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36082 )
Change subject: src: Remove unused 'include <string.h>' ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36082 )
Change subject: src: Remove unused 'include <string.h>' ......................................................................
src: Remove unused 'include <string.h>'
Change-Id: I2a94c3b6282e9915fd2b8136b124740c8a7b774c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/36082 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/arch/riscv/fit_payload.c M src/device/oprom/realmode/x86_interrupts.c M src/device/oprom/x86emu/sys.c M src/device/oprom/x86emu/x86emui.h M src/device/oprom/yabel/compat/functions.c M src/mainboard/google/auron/romstage.c M src/mainboard/google/butterfly/chromeos.c M src/mainboard/google/daisy/chromeos.c M src/mainboard/google/foster/chromeos.c M src/mainboard/google/jecht/romstage.c M src/mainboard/google/kukui/panel_ps8640.c M src/mainboard/google/link/chromeos.c M src/mainboard/google/parrot/chromeos.c M src/mainboard/google/peach_pit/chromeos.c M src/mainboard/google/stout/chromeos.c M src/mainboard/intel/baskingridge/chromeos.c M src/mainboard/intel/emeraldlake2/chromeos.c M src/mainboard/intel/saddlebrook/romstage.c M src/mainboard/intel/wtm2/romstage.c M src/mainboard/purism/librem_bdw/romstage.c M src/mainboard/razer/blade_stealth_kbl/romstage.c M src/mainboard/samsung/lumpy/chromeos.c M src/mainboard/samsung/stumpy/chromeos.c M src/mainboard/up/squared/ramstage.c M src/soc/amd/common/block/spi/fch_spi_special.c M src/soc/intel/cannonlake/reset.c M src/soc/intel/common/block/sgx/sgx.c M src/soc/intel/icelake/reset.c M src/soc/intel/skylake/me.c M src/soc/mediatek/mt8173/i2c.c M src/soc/mediatek/mt8183/ddp.c M src/soc/mediatek/mt8183/include/soc/spm.h M src/soc/qualcomm/qcs405/clock.c M src/soc/qualcomm/qcs405/spi.c M src/soc/qualcomm/sdm845/aop_load_reset.c M src/superio/aspeed/ast2400/superio.c 36 files changed, 0 insertions(+), 36 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/src/arch/riscv/fit_payload.c b/src/arch/riscv/fit_payload.c index 60a4bc0..78e95fd 100644 --- a/src/arch/riscv/fit_payload.c +++ b/src/arch/riscv/fit_payload.c @@ -18,7 +18,6 @@ #include <bootmem.h> #include <stdlib.h> #include <program_loading.h> -#include <string.h> #include <commonlib/compression.h> #include <commonlib/cbfs_serialized.h> #include <lib.h> diff --git a/src/device/oprom/realmode/x86_interrupts.c b/src/device/oprom/realmode/x86_interrupts.c index 4e1c5ed..c38da46 100644 --- a/src/device/oprom/realmode/x86_interrupts.c +++ b/src/device/oprom/realmode/x86_interrupts.c @@ -15,7 +15,6 @@ #include <console/console.h> #include <device/pci.h> #include <device/pci_ops.h> -#include <string.h>
/* we use x86emu's register file representation */ #include <x86emu/regs.h> diff --git a/src/device/oprom/x86emu/sys.c b/src/device/oprom/x86emu/sys.c index 9c293bc..06f240c 100644 --- a/src/device/oprom/x86emu/sys.c +++ b/src/device/oprom/x86emu/sys.c @@ -50,7 +50,6 @@ #ifdef IN_MODULE #include "xf86_ansic.h" #else -#include <string.h> #endif /*------------------------- Global Variables ------------------------------*/
diff --git a/src/device/oprom/x86emu/x86emui.h b/src/device/oprom/x86emu/x86emui.h index 741153c..b1647c5 100644 --- a/src/device/oprom/x86emu/x86emui.h +++ b/src/device/oprom/x86emu/x86emui.h @@ -72,7 +72,6 @@ #ifdef IN_MODULE #include <xf86_ansic.h> #else -#include <string.h> #endif /*--------------------------- Inline Functions ----------------------------*/
diff --git a/src/device/oprom/yabel/compat/functions.c b/src/device/oprom/yabel/compat/functions.c index fa1b6b7..c9e2e4c 100644 --- a/src/device/oprom/yabel/compat/functions.c +++ b/src/device/oprom/yabel/compat/functions.c @@ -36,7 +36,6 @@ */
#include <types.h> -#include <string.h> #include <device/device.h> #include "../debug.h" #include "../biosemu.h" diff --git a/src/mainboard/google/auron/romstage.c b/src/mainboard/google/auron/romstage.c index 568c4c8..d5687f2 100644 --- a/src/mainboard/google/auron/romstage.c +++ b/src/mainboard/google/auron/romstage.c @@ -15,7 +15,6 @@ */
#include <console/console.h> -#include <string.h> #include <ec/google/chromeec/ec.h> #include <soc/pei_data.h> #include <soc/pei_wrapper.h> diff --git a/src/mainboard/google/butterfly/chromeos.c b/src/mainboard/google/butterfly/chromeos.c index 1f5939e..ea4b8ac 100644 --- a/src/mainboard/google/butterfly/chromeos.c +++ b/src/mainboard/google/butterfly/chromeos.c @@ -14,7 +14,6 @@ */
#include <console/console.h> -#include <string.h> #include <bootmode.h> #include <boot/coreboot_tables.h> #include <device/device.h> diff --git a/src/mainboard/google/daisy/chromeos.c b/src/mainboard/google/daisy/chromeos.c index 974cd49..3525a98 100644 --- a/src/mainboard/google/daisy/chromeos.c +++ b/src/mainboard/google/daisy/chromeos.c @@ -18,7 +18,6 @@ #include <ec/google/chromeec/ec_commands.h> #include <soc/cpu.h> #include <soc/gpio.h> -#include <string.h> #include <vendorcode/google/chromeos/chromeos.h> #include <bootmode.h>
diff --git a/src/mainboard/google/foster/chromeos.c b/src/mainboard/google/foster/chromeos.c index 7ce1300..e14fbcb 100644 --- a/src/mainboard/google/foster/chromeos.c +++ b/src/mainboard/google/foster/chromeos.c @@ -18,7 +18,6 @@ #include <ec/google/chromeec/ec.h> #include <ec/google/chromeec/ec_commands.h> #include <gpio.h> -#include <string.h> #include <vendorcode/google/chromeos/chromeos.h>
void fill_lb_gpios(struct lb_gpios *gpios) diff --git a/src/mainboard/google/jecht/romstage.c b/src/mainboard/google/jecht/romstage.c index 4fc2ba0c..4e32ab2 100644 --- a/src/mainboard/google/jecht/romstage.c +++ b/src/mainboard/google/jecht/romstage.c @@ -16,7 +16,6 @@
#include <bootmode.h> #include <console/console.h> -#include <string.h> #include <ec/google/chromeec/ec.h> #include <soc/pei_data.h> #include <soc/pei_wrapper.h> diff --git a/src/mainboard/google/kukui/panel_ps8640.c b/src/mainboard/google/kukui/panel_ps8640.c index 83358d3..6381228 100644 --- a/src/mainboard/google/kukui/panel_ps8640.c +++ b/src/mainboard/google/kukui/panel_ps8640.c @@ -19,7 +19,6 @@ #include <edid.h> #include <gpio.h> #include <soc/i2c.h> -#include <string.h>
#include "panel.h"
diff --git a/src/mainboard/google/link/chromeos.c b/src/mainboard/google/link/chromeos.c index a5370be..44a2bf5 100644 --- a/src/mainboard/google/link/chromeos.c +++ b/src/mainboard/google/link/chromeos.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <string.h> #include <bootmode.h> #include <boot/coreboot_tables.h> #include <southbridge/intel/bd82x6x/pch.h> diff --git a/src/mainboard/google/parrot/chromeos.c b/src/mainboard/google/parrot/chromeos.c index 4adcdb6..4587a12 100644 --- a/src/mainboard/google/parrot/chromeos.c +++ b/src/mainboard/google/parrot/chromeos.c @@ -14,7 +14,6 @@ */
#include <console/console.h> -#include <string.h> #include <bootmode.h> #include <boot/coreboot_tables.h> #include <device/pci_ops.h> diff --git a/src/mainboard/google/peach_pit/chromeos.c b/src/mainboard/google/peach_pit/chromeos.c index 8bd35be..f2b1e8c 100644 --- a/src/mainboard/google/peach_pit/chromeos.c +++ b/src/mainboard/google/peach_pit/chromeos.c @@ -19,7 +19,6 @@ #include <ec/google/chromeec/ec_commands.h> #include <soc/cpu.h> #include <soc/gpio.h> -#include <string.h> #include <vendorcode/google/chromeos/chromeos.h>
void fill_lb_gpios(struct lb_gpios *gpios) diff --git a/src/mainboard/google/stout/chromeos.c b/src/mainboard/google/stout/chromeos.c index 0914450..dc3f3ab 100644 --- a/src/mainboard/google/stout/chromeos.c +++ b/src/mainboard/google/stout/chromeos.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <string.h> #include <bootmode.h> #include <boot/coreboot_tables.h> #include <device/pci_ops.h> diff --git a/src/mainboard/intel/baskingridge/chromeos.c b/src/mainboard/intel/baskingridge/chromeos.c index 2d5919c..74eb788 100644 --- a/src/mainboard/intel/baskingridge/chromeos.c +++ b/src/mainboard/intel/baskingridge/chromeos.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <string.h> #include <bootmode.h> #include <boot/coreboot_tables.h> #include <device/device.h> diff --git a/src/mainboard/intel/emeraldlake2/chromeos.c b/src/mainboard/intel/emeraldlake2/chromeos.c index 4fb512a..470688f 100644 --- a/src/mainboard/intel/emeraldlake2/chromeos.c +++ b/src/mainboard/intel/emeraldlake2/chromeos.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <string.h> #include <bootmode.h> #include <boot/coreboot_tables.h> #include <device/device.h> diff --git a/src/mainboard/intel/saddlebrook/romstage.c b/src/mainboard/intel/saddlebrook/romstage.c index 46c2cdd..0ed6730 100644 --- a/src/mainboard/intel/saddlebrook/romstage.c +++ b/src/mainboard/intel/saddlebrook/romstage.c @@ -17,7 +17,6 @@
#include <console/console.h> #include <fsp/api.h> -#include <string.h> #include <soc/gpio.h> #include <soc/pm.h> #include <soc/romstage.h> diff --git a/src/mainboard/intel/wtm2/romstage.c b/src/mainboard/intel/wtm2/romstage.c index f4e3366..9edc170 100644 --- a/src/mainboard/intel/wtm2/romstage.c +++ b/src/mainboard/intel/wtm2/romstage.c @@ -16,7 +16,6 @@
#include <console/console.h> #include <stdint.h> -#include <string.h> #include <soc/gpio.h> #include <soc/pei_data.h> #include <soc/pei_wrapper.h> diff --git a/src/mainboard/purism/librem_bdw/romstage.c b/src/mainboard/purism/librem_bdw/romstage.c index 0e1ad88..72b3fe2 100644 --- a/src/mainboard/purism/librem_bdw/romstage.c +++ b/src/mainboard/purism/librem_bdw/romstage.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <string.h> #include <soc/pei_data.h> #include <soc/pei_wrapper.h> #include <soc/romstage.h> diff --git a/src/mainboard/razer/blade_stealth_kbl/romstage.c b/src/mainboard/razer/blade_stealth_kbl/romstage.c index f18e6c9..89903ab 100644 --- a/src/mainboard/razer/blade_stealth_kbl/romstage.c +++ b/src/mainboard/razer/blade_stealth_kbl/romstage.c @@ -16,7 +16,6 @@ * GNU General Public License for more details. */
-#include <string.h> #include <assert.h> #include <soc/romstage.h> #include <spd_bin.h> diff --git a/src/mainboard/samsung/lumpy/chromeos.c b/src/mainboard/samsung/lumpy/chromeos.c index 9e02d9a..c70ee1d 100644 --- a/src/mainboard/samsung/lumpy/chromeos.c +++ b/src/mainboard/samsung/lumpy/chromeos.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <string.h> #include <bootmode.h> #include <boot/coreboot_tables.h> #include <device/pci_ops.h> diff --git a/src/mainboard/samsung/stumpy/chromeos.c b/src/mainboard/samsung/stumpy/chromeos.c index f316b22..2cce8ad 100644 --- a/src/mainboard/samsung/stumpy/chromeos.c +++ b/src/mainboard/samsung/stumpy/chromeos.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <string.h> #include <bootmode.h> #include <boot/coreboot_tables.h> #include <device/pci_ops.h> diff --git a/src/mainboard/up/squared/ramstage.c b/src/mainboard/up/squared/ramstage.c index be70ea9..637b8d8 100644 --- a/src/mainboard/up/squared/ramstage.c +++ b/src/mainboard/up/squared/ramstage.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <string.h> #include <soc/ramstage.h> #include <fsp/api.h> #include <FspsUpd.h> diff --git a/src/soc/amd/common/block/spi/fch_spi_special.c b/src/soc/amd/common/block/spi/fch_spi_special.c index 456a389..fa3c00a 100644 --- a/src/soc/amd/common/block/spi/fch_spi_special.c +++ b/src/soc/amd/common/block/spi/fch_spi_special.c @@ -16,7 +16,6 @@ #include <console/console.h> #include <spi-generic.h> #include <amdblocks/fch_spi.h> -#include <string.h>
int non_standard_sst_byte_write(u32 offset, const void *buf) { diff --git a/src/soc/intel/cannonlake/reset.c b/src/soc/intel/cannonlake/reset.c index e01c22c..4758faf 100644 --- a/src/soc/intel/cannonlake/reset.c +++ b/src/soc/intel/cannonlake/reset.c @@ -19,7 +19,6 @@ #include <intelblocks/pmclib.h> #include <fsp/util.h> #include <soc/intel/common/reset.h> -#include <string.h> #include <soc/pci_devs.h>
void do_global_reset(void) diff --git a/src/soc/intel/common/block/sgx/sgx.c b/src/soc/intel/common/block/sgx/sgx.c index 377a719..b12e6cf 100644 --- a/src/soc/intel/common/block/sgx/sgx.c +++ b/src/soc/intel/common/block/sgx/sgx.c @@ -24,7 +24,6 @@ #include <intelblocks/systemagent.h> #include <soc/cpu.h> #include <soc/pci_devs.h> -#include <string.h>
static inline uint64_t sgx_resource(uint32_t low, uint32_t high) { diff --git a/src/soc/intel/icelake/reset.c b/src/soc/intel/icelake/reset.c index d83b3ee..5526a42 100644 --- a/src/soc/intel/icelake/reset.c +++ b/src/soc/intel/icelake/reset.c @@ -19,7 +19,6 @@ #include <intelblocks/pmclib.h> #include <fsp/util.h> #include <soc/intel/common/reset.h> -#include <string.h> #include <soc/pci_devs.h>
void do_global_reset(void) diff --git a/src/soc/intel/skylake/me.c b/src/soc/intel/skylake/me.c index 5a378a2..f90a165 100644 --- a/src/soc/intel/skylake/me.c +++ b/src/soc/intel/skylake/me.c @@ -24,7 +24,6 @@ #include <soc/pci_devs.h> #include <stdint.h> #include <stdlib.h> -#include <string.h>
/* HFSTS1[3:0] Current Working State Values */ diff --git a/src/soc/mediatek/mt8173/i2c.c b/src/soc/mediatek/mt8173/i2c.c index 67de335..22702d3 100644 --- a/src/soc/mediatek/mt8173/i2c.c +++ b/src/soc/mediatek/mt8173/i2c.c @@ -17,7 +17,6 @@ #include <console/console.h> #include <delay.h> #include <device/i2c_simple.h> -#include <string.h> #include <symbols.h> #include <timer.h> #include <device/mmio.h> diff --git a/src/soc/mediatek/mt8183/ddp.c b/src/soc/mediatek/mt8183/ddp.c index 0ae0be1..3c2b0fd 100644 --- a/src/soc/mediatek/mt8183/ddp.c +++ b/src/soc/mediatek/mt8183/ddp.c @@ -16,7 +16,6 @@ #include <device/mmio.h> #include <edid.h> #include <stdlib.h> -#include <string.h> #include <stddef.h> #include <soc/addressmap.h> #include <soc/ddp.h> diff --git a/src/soc/mediatek/mt8183/include/soc/spm.h b/src/soc/mediatek/mt8183/include/soc/spm.h index 4ca72b6..6ab9647 100644 --- a/src/soc/mediatek/mt8183/include/soc/spm.h +++ b/src/soc/mediatek/mt8183/include/soc/spm.h @@ -19,7 +19,6 @@ #include <arch/barrier.h> #include <console/console.h> #include <soc/addressmap.h> -#include <string.h> #include <stdint.h> #include <types.h>
diff --git a/src/soc/qualcomm/qcs405/clock.c b/src/soc/qualcomm/qcs405/clock.c index b7dd51b..37fd2c2 100644 --- a/src/soc/qualcomm/qcs405/clock.c +++ b/src/soc/qualcomm/qcs405/clock.c @@ -17,7 +17,6 @@ #include <types.h> #include <delay.h> #include <commonlib/helpers.h> -#include <string.h> #include <soc/clock.h>
#define DIV(div) (div ? (2*div - 1) : 0) diff --git a/src/soc/qualcomm/qcs405/spi.c b/src/soc/qualcomm/qcs405/spi.c index 13b9dae..827448c 100644 --- a/src/soc/qualcomm/qcs405/spi.c +++ b/src/soc/qualcomm/qcs405/spi.c @@ -35,7 +35,6 @@ #include <soc/spi.h> #include <soc/clock.h> #include <stdlib.h> -#include <string.h> #include <spi_flash.h> #include <timer.h>
diff --git a/src/soc/qualcomm/sdm845/aop_load_reset.c b/src/soc/qualcomm/sdm845/aop_load_reset.c index 02217f9..c1cf057 100644 --- a/src/soc/qualcomm/sdm845/aop_load_reset.c +++ b/src/soc/qualcomm/sdm845/aop_load_reset.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <string.h> #include <arch/cache.h> #include <cbfs.h> #include <halt.h> diff --git a/src/superio/aspeed/ast2400/superio.c b/src/superio/aspeed/ast2400/superio.c index 5ae630e..c5df8b5 100644 --- a/src/superio/aspeed/ast2400/superio.c +++ b/src/superio/aspeed/ast2400/superio.c @@ -18,7 +18,6 @@ #include <device/device.h> #include <device/pnp.h> #include <superio/conf_mode.h> -#include <string.h> #include <pc80/keyboard.h> #include <superio/common/ssdt.h> #include <arch/acpi.h>
-
Felix Held (Code Review) -
HAOUAS Elyes (Code Review)