Attention is currently required from: Cliff Huang, Intel coreboot Reviewers, Jérémy Compostella.
Kapil Porwal has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/87085?usp=email )
Change subject: drivers/intel/touch: Conditionally add ACPI _PRW based on wake source
......................................................................
Patch Set 2:
(1 comment)
File src/drivers/intel/touch/touch.c:
https://review.coreboot.org/c/coreboot/+/87085/comment/a7f6bff0_7554fb52?usp... :
PS2, Line 208: acpigen_write_name_integer("_S0W", ACPI_DEVICE_SLEEP_D3_HOT);
Why remove _S0W?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87085?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I56fc8486c7494ff37c1d580d57838fee286128a6
Gerrit-Change-Number: 87085
Gerrit-PatchSet: 2
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Kyoung Il Kim
kyoung.il.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Comment-Date: Wed, 02 Apr 2025 20:46:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No