HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42343 )
Change subject: soc/qualcomm/sc7180/qupv3_config.c: Add missing <string.h> ......................................................................
soc/qualcomm/sc7180/qupv3_config.c: Add missing <string.h>
Also add missing 'commonlib/bsd/cbfs_serialized.h'
Change-Id: I7e66a3cbf50fa27b4f6be6885b324de90eddd387 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/qualcomm/sc7180/qupv3_config.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/42343/1
diff --git a/src/soc/qualcomm/sc7180/qupv3_config.c b/src/soc/qualcomm/sc7180/qupv3_config.c index 2c4554d..8878a1a 100644 --- a/src/soc/qualcomm/sc7180/qupv3_config.c +++ b/src/soc/qualcomm/sc7180/qupv3_config.c @@ -1,6 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */
+#include <commonlib/bsd/cbfs_serialized.h> #include <soc/qupv3_config.h> +#include <string.h>
static struct elf_se_hdr *fw_list[SE_PROTOCOL_MAX];
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42343 )
Change subject: soc/qualcomm/sc7180/qupv3_config.c: Add missing <string.h> ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42343/1/src/soc/qualcomm/sc7180/qup... File src/soc/qualcomm/sc7180/qupv3_config.c:
https://review.coreboot.org/c/coreboot/+/42343/1/src/soc/qualcomm/sc7180/qup... PS1, Line 3: #include <commonlib/bsd/cbfs_serialized.h> I agree that the header situation here could use fixing, but this should be <cbfs.h> instead if anything. (And if you're adding it here, can you please also remove it from <soc/qupv3_config.h> where it is not really needed?)
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42343
to look at the new patch set (#2).
Change subject: soc/qualcomm/sc7180/qupv3_config.c: Clean up includes ......................................................................
soc/qualcomm/sc7180/qupv3_config.c: Clean up includes
Also add missing <string.h> and <cbfs.h>.
Change-Id: I7e66a3cbf50fa27b4f6be6885b324de90eddd387 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/qualcomm/sc7180/qupv3_config.c 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/42343/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42343 )
Change subject: soc/qualcomm/sc7180/qupv3_config.c: Clean up includes ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42343/1/src/soc/qualcomm/sc7180/qup... File src/soc/qualcomm/sc7180/qupv3_config.c:
https://review.coreboot.org/c/coreboot/+/42343/1/src/soc/qualcomm/sc7180/qup... PS1, Line 3: #include <commonlib/bsd/cbfs_serialized.h>
I agree that the header situation here could use fixing, but this should be <cbfs. […]
Done Thank you.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42343
to look at the new patch set (#3).
Change subject: soc/qualcomm/sc7180/qupv3_config.c: Add missing includes ......................................................................
soc/qualcomm/sc7180/qupv3_config.c: Add missing includes
Add <string.h> and <cbfs.h>
Change-Id: I7e66a3cbf50fa27b4f6be6885b324de90eddd387 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/qualcomm/sc7180/include/soc/qupv3_config.h M src/soc/qualcomm/sc7180/qupv3_config.c 2 files changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/42343/3
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42343 )
Change subject: soc/qualcomm/sc7180/qupv3_config.c: Add missing includes ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42343 )
Change subject: soc/qualcomm/sc7180/qupv3_config.c: Add missing includes ......................................................................
soc/qualcomm/sc7180/qupv3_config.c: Add missing includes
Add <string.h> and <cbfs.h>
Change-Id: I7e66a3cbf50fa27b4f6be6885b324de90eddd387 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/42343 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Julius Werner jwerner@chromium.org --- M src/soc/qualcomm/sc7180/include/soc/qupv3_config.h M src/soc/qualcomm/sc7180/qupv3_config.c 2 files changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved
diff --git a/src/soc/qualcomm/sc7180/include/soc/qupv3_config.h b/src/soc/qualcomm/sc7180/include/soc/qupv3_config.h index d67c0b5..b595984 100644 --- a/src/soc/qualcomm/sc7180/include/soc/qupv3_config.h +++ b/src/soc/qualcomm/sc7180/include/soc/qupv3_config.h @@ -4,7 +4,6 @@ #define _SC7180_QUPV3_CONFIG_H_
#include <assert.h> -#include <cbfs.h> #include <soc/clock.h> #include <soc/qcom_qup_se.h>
diff --git a/src/soc/qualcomm/sc7180/qupv3_config.c b/src/soc/qualcomm/sc7180/qupv3_config.c index 2c4554d..b5adee2 100644 --- a/src/soc/qualcomm/sc7180/qupv3_config.c +++ b/src/soc/qualcomm/sc7180/qupv3_config.c @@ -1,5 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
+#include <cbfs.h> +#include <string.h> #include <soc/qupv3_config.h>
static struct elf_se_hdr *fw_list[SE_PROTOCOL_MAX];