Matt Delco has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46465 )
Change subject: soc/intel/skl,acpi/acpigen: convert global CPPC package to local one
......................................................................
Patch Set 16: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/46465/16/src/acpi/acpigen.c
File src/acpi/acpigen.c:
https://review.coreboot.org/c/coreboot/+/46465/16/src/acpi/acpigen.c@1588
PS16, Line 1588: acpigen_emit_namestring("\_SB.CP00.GCPC");
Seems alright though an approach like the following approach on hard-coding might be easier to swallow (while being within reason for some compilers to compute at build-time instead of run-time).
#define CPPC_PACKAGE_NAME "GCPC"
// acpigen_write_CPPC_package()
acpigen_write_name(CPPC_PACKAGE_NAME);
// acpigen_write_CPPC_method()
char pscope[16];
snprintf(pscope, sizeof(pscope), CONFIG_ACPI_CPU_STRING "." CPPC_PACKAGE_NAME, 0);
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46465
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40b9fd644622196da434128895eb6fb96fdf254d
Gerrit-Change-Number: 46465
Gerrit-PatchSet: 16
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Matt Delco
delco@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 23 Oct 2020 22:55:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment