Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31931 )
Change subject: util/sconfig: Declare the repeated devicetree storage ......................................................................
Patch Set 5:
(1 comment)
This change is ready for review.
https://review.coreboot.org/#/c/31931/4/util/sconfig/main.c File util/sconfig/main.c:
https://review.coreboot.org/#/c/31931/4/util/sconfig/main.c@932 PS4, Line 932: static
so everything is now static all the time?
The names are nonsense and not referenced outside the generated static.c, so 'static' currently makes sense?
My longterm plan would be to encode PCI BDF in the names such that early stages resolve node addresses at build-time. This allows dropping the topology links and lets garbage collection to optimise the size for stages other than ramstage.
Experiments show that passing struct *device is as efficient, and sometimes better, than pci_devfn_t in romstage. I'd like to deprecate __SIMPLE_DEVICE__.
-
Kyösti Mälkki (Code Review)